<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/sqlite3/php_sqlite3_structs.h, branch php-7.3.20</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Fix #79294: ::columnType() may fail after SQLite3Stmt::reset()</title>
<updated>2020-02-21T12:36:29+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-21T12:24:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=f133f0024ec801dc9636ee5bf84a93de1300d4b2'/>
<id>f133f0024ec801dc9636ee5bf84a93de1300d4b2</id>
<content type='text'>
The fix for feature request #53466 did not properly handle resetting of
the corresponding statement; the problem with this is that the
statement does not know about its result sets.  But even if we could
fix this, the `complete` handling still appears to be brittle, since
the `sqlite3_column_type()`docs[1] state:

| If the SQL statement does not currently point to a valid row, or if
| the column index is out of range, the result is undefined.

Fortunately, we can use `sqlite3_data_count()` instead, since[2]:

| If prepared statement P does not have results ready to return (via
| calls to the sqlite3_column() family of interfaces) then
| sqlite3_data_count(P) returns 0.

Thus, we guard `SQLite3::columnType()` with `sqlite3_data_count()`, and
completely drop updating the `php_sqlite3_result_object.complete`
field, but keep it for ABI BC purposes.

[1] &lt;https://www.sqlite.org/c3ref/column_blob.html&gt;
[2] &lt;https://www.sqlite.org/c3ref/data_count.html&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The fix for feature request #53466 did not properly handle resetting of
the corresponding statement; the problem with this is that the
statement does not know about its result sets.  But even if we could
fix this, the `complete` handling still appears to be brittle, since
the `sqlite3_column_type()`docs[1] state:

| If the SQL statement does not currently point to a valid row, or if
| the column index is out of range, the result is undefined.

Fortunately, we can use `sqlite3_data_count()` instead, since[2]:

| If prepared statement P does not have results ready to return (via
| calls to the sqlite3_column() family of interfaces) then
| sqlite3_data_count(P) returns 0.

Thus, we guard `SQLite3::columnType()` with `sqlite3_data_count()`, and
completely drop updating the `php_sqlite3_result_object.complete`
field, but keep it for ABI BC purposes.

[1] &lt;https://www.sqlite.org/c3ref/column_blob.html&gt;
[2] &lt;https://www.sqlite.org/c3ref/data_count.html&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused Git attributes ident</title>
<updated>2018-07-24T22:53:25+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-07-03T00:52:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=8d3f8ca12a0b00f2a74a27424790222536235502'/>
<id>8d3f8ca12a0b00f2a74a27424790222536235502</id>
<content type='text'>
The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.
</pre>
</div>
</content>
</entry>
<entry>
<title>year++</title>
<updated>2018-01-02T04:57:58+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@gmail.com</email>
</author>
<published>2018-01-02T04:57:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=a6519d051463f211fc1a23661e5dc4814bfbcf83'/>
<id>a6519d051463f211fc1a23661e5dc4814bfbcf83</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Update copyright headers to 2017</title>
<updated>2017-01-02T15:30:12+00:00</updated>
<author>
<name>Sammy Kaye Powers</name>
<email>sammyk@sammykmedia.com</email>
</author>
<published>2017-01-02T15:30:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=9e29f841ce3711488781be958ffdfc42d738de4a'/>
<id>9e29f841ce3711488781be958ffdfc42d738de4a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-5.6' into PHP-7.0</title>
<updated>2016-01-01T17:48:25+00:00</updated>
<author>
<name>Lior Kaplan</name>
<email>kaplanlior@gmail.com</email>
</author>
<published>2016-01-01T17:47:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=ed35de784f4ea53927e906ba4af335778de4d16a'/>
<id>ed35de784f4ea53927e906ba4af335778de4d16a</id>
<content type='text'>
* PHP-5.6:
  Happy new year (Update copyright to 2016)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-5.6:
  Happy new year (Update copyright to 2016)
</pre>
</div>
</content>
</entry>
<entry>
<title>Happy new year (Update copyright to 2016)</title>
<updated>2016-01-01T17:21:47+00:00</updated>
<author>
<name>Lior Kaplan</name>
<email>kaplanlior@gmail.com</email>
</author>
<published>2016-01-01T17:19:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=49493a2dcfb2cd1758b69b13d9006ead3be0e066'/>
<id>49493a2dcfb2cd1758b69b13d9006ead3be0e066</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>bump year</title>
<updated>2015-01-15T15:27:30+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@php.net</email>
</author>
<published>2015-01-15T15:27:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=fc33f52d8c25997dd0711de3e07d0dc260a18c11'/>
<id>fc33f52d8c25997dd0711de3e07d0dc260a18c11</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>bump year</title>
<updated>2015-01-15T15:26:37+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@php.net</email>
</author>
<published>2015-01-15T15:26:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=0579e8278dad43c7ebc070468b56caddf1c660b8'/>
<id>0579e8278dad43c7ebc070468b56caddf1c660b8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>trailing whitespace removal</title>
<updated>2015-01-10T23:07:38+00:00</updated>
<author>
<name>Stanislav Malyshev</name>
<email>stas@php.net</email>
</author>
<published>2015-01-03T09:22:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=b7a7b1a624c97945c0aaa49d46ae996fc0bdb6bc'/>
<id>b7a7b1a624c97945c0aaa49d46ae996fc0bdb6bc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>s/PHP 5/PHP 7/</title>
<updated>2014-09-19T16:33:14+00:00</updated>
<author>
<name>Johannes Schlüter</name>
<email>johannes@php.net</email>
</author>
<published>2014-09-19T16:33:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=d0cb715373c3fbe9dc095378ec5ed8c71f799f67'/>
<id>d0cb715373c3fbe9dc095378ec5ed8c71f799f67</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
