delta/php-git.git/ext/spl/spl_array.c, branch php-7.0.8 git.php.net: repository/php-src.git Fix bug #71334 2016-03-30T20:49:27+00:00 Nikita Popov nikic@php.net 2016-01-12T15:31:58+00:00 b1e854f7762b2e0648ddc240835cb446ee4d20a7 Always duplicate the array before doing a sort with user-defined comparison function, to avoid access to the intermediate inconsistent state. I've also dropped the "array modification" warning, as protection against modifications is no longer relevant if we're always working on a copy anyway. This also required some changes to how SplArray forwards calls to sorting functions. 
Always duplicate the array before doing a sort with user-defined
comparison function, to avoid access to the intermediate
inconsistent state.

I've also dropped the "array modification" warning, as protection
against modifications is no longer relevant if we're always working
on a copy anyway.

This also required some changes to how SplArray forwards calls to
sorting functions.
Fixed bug #62059 2016-03-20T17:17:44+00:00 Nikita Popov nikic@php.net 2016-03-20T17:17:44+00:00 f3309173f916e3c5cf37910975f04310706336b5 






Fix construction of AO with overloaded object error
2016-02-24T21:34:50+00:00

Nikita Popov
nikic@php.net

2016-02-24T21:31:17+00:00

fd561505f4142730684eacaba6f0ac5f293a8f0e

a) Fix uses of zend_string in error message
b) Don't assign the overloaded object as the backing storage, that
   sort of defeats the point. Instead leave the previous value.





a) Fix uses of zend_string in error message
b) Don't assign the overloaded object as the backing storage, that
   sort of defeats the point. Instead leave the previous value.







Fix AO object properties separation
2016-02-24T21:34:50+00:00

Nikita Popov
nikic@php.net

2016-02-24T18:08:18+00:00

0aa716381643c2746ddef019681e762d4e3f4233












Forbid exchangeArray() during sorting
2016-02-24T21:34:50+00:00

Nikita Popov
nikic@php.net

2016-02-24T17:27:56+00:00

079f2f7eb31659569cd2663e2c5b4c9f9eaa32d7

Previously this would leak.





Previously this would leak.







Fix leak on assignment to illegal AO offset
2016-02-24T16:39:16+00:00

Nikita Popov
nikic@php.net

2016-02-24T16:39:16+00:00

eb885e9d6ebc6670d1ccc6d5c0fa26e411ffb0fb












Don't use ht applyCount for AO sorting protection
2016-02-24T16:18:07+00:00

Nikita Popov
nikic@php.net

2016-02-24T16:18:07+00:00

ea02f5765608c13cb92b5b7879878b981c99b33e

Instead use the AOs own applyCount that just got freed up. Using the
apply count of the HashTable has various side effects, e.g. preventing
the ArrayObject from being dumped.





Instead use the AOs own applyCount that just got freed up. Using the
apply count of the HashTable has various side effects, e.g. preventing
the ArrayObject from being dumped.







Remove recursion checks from AO get_properties
2016-02-24T16:10:28+00:00

Nikita Popov
nikic@php.net

2016-02-24T16:10:28+00:00

38db6ff306bd6fca4ed37823ea8abfeef3b9796c

These are pointless, there is no recursion (of that kind) happening
there.





These are pointless, there is no recursion (of that kind) happening
there.







Remove check_std_props arg from get_hash_table
2016-02-22T12:09:54+00:00

Nikita Popov
nikic@php.net

2016-02-22T12:09:54+00:00

78b29310bc594502b117ccd96a5ffcc03e0b7b89

get_properties() is the only place using it, so handle it only
there.





get_properties() is the only place using it, so handle it only
there.







Don't recurse into USE_OTHER checking STD_PROP_LIST
2016-02-22T12:04:19+00:00

Nikita Popov
nikic@php.net

2016-02-22T12:04:19+00:00

3f5c80e8c27b3d74f60ef7ce1a6933c7752ef8e4

If STD_PROP_LIST is explicitly disabled in the constructor, it
should really be disabled.





If STD_PROP_LIST is explicitly disabled in the constructor, it
should really be disabled.