<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/mbstring/tests, branch php-8.0.1</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Normalize mb_ereg() return value</title>
<updated>2020-10-13T18:40:55+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2020-10-13T14:17:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=5582490bf2caa9a416d56378b29c2a2f5e595d60'/>
<id>5582490bf2caa9a416d56378b29c2a2f5e595d60</id>
<content type='text'>
mb_ereg()/mb_eregi() currently have an inconsistent return value
based on whether the $matches parameter is passed or not:

&gt; Returns the byte length of the matched string if a match for
&gt; pattern was found in string, or FALSE if no matches were found
&gt; or an error occurred.
&gt;
&gt; If the optional parameter regs was not passed or the length of
&gt; the matched string is 0, this function returns 1.

Coupling this behavior to the $matches parameter doesn't make sense
-- we know the match length either way, there is no technical
reason to distinguish them. However, returning the match length
is not particularly useful either, especially due to the need to
convert 0-length into 1-length to satisfy "truthy" checks. We
could always return 1, which would kind of match the behavior of
preg_match() -- however, preg_match() actually returns the number
of matches, which is 0 or 1 for preg_match(), while false signals
an error. However, mb_ereg() returns false both for no match and
for an error. This would result in an odd 1|false return value.

The patch canonicalizes mb_ereg() to always return a boolean,
where true indicates a match and false indicates no match or error.
This also matches the behavior of the mb_ereg_match() and
mb_ereg_search() functions.

This fixes the default value integrity violation in PHP 8.

Closes GH-6331.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
mb_ereg()/mb_eregi() currently have an inconsistent return value
based on whether the $matches parameter is passed or not:

&gt; Returns the byte length of the matched string if a match for
&gt; pattern was found in string, or FALSE if no matches were found
&gt; or an error occurred.
&gt;
&gt; If the optional parameter regs was not passed or the length of
&gt; the matched string is 0, this function returns 1.

Coupling this behavior to the $matches parameter doesn't make sense
-- we know the match length either way, there is no technical
reason to distinguish them. However, returning the match length
is not particularly useful either, especially due to the need to
convert 0-length into 1-length to satisfy "truthy" checks. We
could always return 1, which would kind of match the behavior of
preg_match() -- however, preg_match() actually returns the number
of matches, which is 0 or 1 for preg_match(), while false signals
an error. However, mb_ereg() returns false both for no match and
for an error. This would result in an odd 1|false return value.

The patch canonicalizes mb_ereg() to always return a boolean,
where true indicates a match and false indicates no match or error.
This also matches the behavior of the mb_ereg_match() and
mb_ereg_search() functions.

This fixes the default value integrity violation in PHP 8.

Closes GH-6331.
</pre>
</div>
</content>
</entry>
<entry>
<title>Update mbstring parameter names</title>
<updated>2020-09-28T07:51:58+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2020-09-24T14:14:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=cafceea7424edca6bfe969cba39068dbe6aa64ba'/>
<id>cafceea7424edca6bfe969cba39068dbe6aa64ba</id>
<content type='text'>
Closes GH-6207.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-6207.
</pre>
</div>
</content>
</entry>
<entry>
<title>Standardize mbstring and string on using 'string' as a parameter name.</title>
<updated>2020-09-21T10:06:50+00:00</updated>
<author>
<name>Larry Garfield</name>
<email>larry@garfieldtech.com</email>
</author>
<published>2020-09-20T00:04:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=94854e0dff581e3cdf3ab635e8cdb30f22020c3f'/>
<id>94854e0dff581e3cdf3ab635e8cdb30f22020c3f</id>
<content type='text'>
Closes GH-6171.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-6171.
</pre>
</div>
</content>
</entry>
<entry>
<title>Consolidate the usage of "either" and "one of" in error messages</title>
<updated>2020-09-20T17:41:47+00:00</updated>
<author>
<name>Máté Kocsis</name>
<email>kocsismate@woohoolabs.com</email>
</author>
<published>2020-09-20T08:41:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=e950ca13ea2e8f012ded007ac1251eea01269542'/>
<id>e950ca13ea2e8f012ded007ac1251eea01269542</id>
<content type='text'>
Closes GH-6173
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-6173
</pre>
</div>
</content>
</entry>
<entry>
<title>Run tidy</title>
<updated>2020-09-18T12:28:32+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2020-09-18T12:28:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=c5401854fcea27ff9aabfd0682ff4d81bbb3c888'/>
<id>c5401854fcea27ff9aabfd0682ff4d81bbb3c888</id>
<content type='text'>
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
</pre>
</div>
</content>
</entry>
<entry>
<title>Promote a few remaining errors in ext/standard</title>
<updated>2020-09-15T12:26:16+00:00</updated>
<author>
<name>Máté Kocsis</name>
<email>kocsismate@woohoolabs.com</email>
</author>
<published>2020-09-10T11:28:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=c37a1cd650a5399c4a89543759deedcc7280becd'/>
<id>c37a1cd650a5399c4a89543759deedcc7280becd</id>
<content type='text'>
Closes GH-6110
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-6110
</pre>
</div>
</content>
</entry>
<entry>
<title>Throw ValueError on null bytes in mb_send_mail()</title>
<updated>2020-09-11T08:46:59+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2020-09-11T08:46:59+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=f33fd9b7fec635ca155c22cfa26b0592a2046ce9'/>
<id>f33fd9b7fec635ca155c22cfa26b0592a2046ce9</id>
<content type='text'>
Instead of silently replacing with spaces.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of silently replacing with spaces.
</pre>
</div>
</content>
</entry>
<entry>
<title>Promote some warnings in MBString Regexes</title>
<updated>2020-09-09T12:55:07+00:00</updated>
<author>
<name>George Peter Banyard</name>
<email>girgias@php.net</email>
</author>
<published>2020-04-02T15:05:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=04441585292e4c75d57a2679c62766701b94ce81'/>
<id>04441585292e4c75d57a2679c62766701b94ce81</id>
<content type='text'>
Closes GH-5341
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Closes GH-5341
</pre>
</div>
</content>
</entry>
<entry>
<title>Throw on invalid mb_http_input() type</title>
<updated>2020-09-07T07:59:51+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2020-09-07T07:59:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=623bf96e7e37a05622df163a228c8e1c3f7d0b02'/>
<id>623bf96e7e37a05622df163a228c8e1c3f7d0b02</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Handle null encoding in mb_http_input()</title>
<updated>2020-09-04T15:15:35+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2020-09-04T15:15:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=d57f9e5ea41aac7e40d37b6335cd2e03bf3b73fa'/>
<id>d57f9e5ea41aac7e40d37b6335cd2e03bf3b73fa</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
