<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/mbstring/libmbfl, branch php-7.2.31</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Fix bug #79037 (global buffer-overflow in `mbfl_filt_conv_big5_wchar`)</title>
<updated>2020-01-21T05:43:42+00:00</updated>
<author>
<name>Stanislav Malyshev</name>
<email>stas@php.net</email>
</author>
<published>2020-01-21T05:42:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=2bcbc95f033c31b00595ed39f79c3a99b4ed0501'/>
<id>2bcbc95f033c31b00595ed39f79c3a99b4ed0501</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Sync leading and final newlines in source code files</title>
<updated>2018-10-14T10:54:08+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-10-14T10:54:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=60a69daec60f1886e166e8060556777819c66f98'/>
<id>60a69daec60f1886e166e8060556777819c66f98</id>
<content type='text'>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</pre>
</div>
</content>
</entry>
<entry>
<title>Trim trailing whitespace in source code files</title>
<updated>2018-10-13T12:14:50+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-10-13T12:14:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=902d39a3a79c6efe93c8879575fdd5a759cf03de'/>
<id>902d39a3a79c6efe93c8879575fdd5a759cf03de</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.1' into PHP-7.2</title>
<updated>2018-06-28T21:05:09+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2018-06-28T21:04:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=00c0d7702ce92ed132ad7234ca63bdec28e56421'/>
<id>00c0d7702ce92ed132ad7234ca63bdec28e56421</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #76532 (excessive memory usage in mb_strimwidth)</title>
<updated>2018-06-28T21:02:28+00:00</updated>
<author>
<name>Marcus Schwarz</name>
<email>schwarz@sc-networks.com</email>
</author>
<published>2018-06-28T12:10:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=bf5a802f5a87010cee94df1cda2918f3be8ae96e'/>
<id>bf5a802f5a87010cee94df1cda2918f3be8ae96e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.1' into PHP-7.2</title>
<updated>2018-03-19T13:34:09+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2018-03-19T13:25:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=cd2912af5ead4174cb8e3e91a755e471fd7ec08a'/>
<id>cd2912af5ead4174cb8e3e91a755e471fd7ec08a</id>
<content type='text'>
* PHP-7.1:
  Fix #75944: Wrong cp1251 detection
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.1:
  Fix #75944: Wrong cp1251 detection
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #75944: Wrong cp1251 detection</title>
<updated>2018-03-19T13:24:27+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2018-03-19T12:51:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=47461368ca4ea2d2c23482cbd655bd96b2acbfc8'/>
<id>47461368ca4ea2d2c23482cbd655bd96b2acbfc8</id>
<content type='text'>
`\xFF` is a valid character of CP-1251.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`\xFF` is a valid character of CP-1251.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.1' into PHP-7.2</title>
<updated>2018-03-11T16:54:45+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2018-03-11T16:53:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=2b02e6dff3750e58d8b3e6c5ede0ad3ccb68d353'/>
<id>2b02e6dff3750e58d8b3e6c5ede0ad3ccb68d353</id>
<content type='text'>
* PHP-7.1:
  Fix #62545: wrong unicode mapping in some charsets
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.1:
  Fix #62545: wrong unicode mapping in some charsets
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #62545: wrong unicode mapping in some charsets</title>
<updated>2018-03-11T16:38:28+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2018-02-24T21:34:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=01ea314e8cfd6c1c6a2c7db9e13be1f581f5d0a1'/>
<id>01ea314e8cfd6c1c6a2c7db9e13be1f581f5d0a1</id>
<content type='text'>
Undefined characters are best mapped to Unicode REPLACEMENT characters.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Undefined characters are best mapped to Unicode REPLACEMENT characters.
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert/fix substitution character fallback</title>
<updated>2017-08-03T19:53:59+00:00</updated>
<author>
<name>Nikita Popov</name>
<email>nikita.ppv@gmail.com</email>
</author>
<published>2017-08-03T19:53:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=fb9bf5b64b6c09b9d93bbd1dadd64884e0af66f3'/>
<id>fb9bf5b64b6c09b9d93bbd1dadd64884e0af66f3</id>
<content type='text'>
The introduced checks were not correct in two respects:
 * It was checked whether the source encoding of the string matches
   the internal encoding, while the actually relevant encoding is
   the *target* encoding.
 * Even if the correct encoding is used, the checks are still too
   conservative. Just because something is not a "Unicode-encoding"
   does not mean that it does not map any non-ASCII characters.

I've reverted the added checks and instead adjusted mbfl_convert
to first try to use the provided substitution character and if
that fails, perform the fallback to '?' at that point. This means
that any codepoint mapped in the target encoding should now be
correctly supported and anything else should fall back to '?'.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The introduced checks were not correct in two respects:
 * It was checked whether the source encoding of the string matches
   the internal encoding, while the actually relevant encoding is
   the *target* encoding.
 * Even if the correct encoding is used, the checks are still too
   conservative. Just because something is not a "Unicode-encoding"
   does not mean that it does not map any non-ASCII characters.

I've reverted the added checks and instead adjusted mbfl_convert
to first try to use the provided substitution character and if
that fails, perform the fallback to '?' at that point. This means
that any codepoint mapped in the target encoding should now be
correctly supported and anything else should fall back to '?'.
</pre>
</div>
</content>
</entry>
</feed>
