<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/libxml, branch php-7.4.3</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Merge branch 'PHP-7.3' into PHP-7.4</title>
<updated>2020-02-03T22:33:20+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-03T22:32:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=3fb41c202801ef26cd20c5778c17a899913eb3d1'/>
<id>3fb41c202801ef26cd20c5778c17a899913eb3d1</id>
<content type='text'>
* PHP-7.3:
  Fix #79191: Error in SoapClient ctor disables DOMDocument::save()
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.3:
  Fix #79191: Error in SoapClient ctor disables DOMDocument::save()
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79191: Error in SoapClient ctor disables DOMDocument::save()</title>
<updated>2020-02-03T22:31:46+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-03T22:10:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=fe1bfb78d65d28dd151da417477a0cee51de8afb'/>
<id>fe1bfb78d65d28dd151da417477a0cee51de8afb</id>
<content type='text'>
The culprit is the too restrictive fix for bug #71536, which prevents
`php_libxml_streams_IO_write()` from properly executing when unclean
shutdown is flagged.  A *more* suitable solution is to move the
`xmlwriter_free_resource_ptr()` call from the `free_obj` handler to an
added `dtor_obj` handler, to avoid to write to a closed stream in case
of late object freeing.  This makes the `EG(active)` guard superfluous.

We also fix bug79029.phpt which has to use different variables for the
three parts to actually check the original shutdown issue.

Thanks to bwoebi and daverandom for helping to investigate this issue.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The culprit is the too restrictive fix for bug #71536, which prevents
`php_libxml_streams_IO_write()` from properly executing when unclean
shutdown is flagged.  A *more* suitable solution is to move the
`xmlwriter_free_resource_ptr()` call from the `free_obj` handler to an
added `dtor_obj` handler, to avoid to write to a closed stream in case
of late object freeing.  This makes the `EG(active)` guard superfluous.

We also fix bug79029.phpt which has to use different variables for the
three parts to actually check the original shutdown issue.

Thanks to bwoebi and daverandom for helping to investigate this issue.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make MSVCRT memory leak checking usable for the test suite</title>
<updated>2020-01-23T10:47:20+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-01-15T22:04:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=4130fe437a5db7ead1444d3748bd0fbad9829cb2'/>
<id>4130fe437a5db7ead1444d3748bd0fbad9829cb2</id>
<content type='text'>
While basic support for MSVCRT debugging has been added long
ago[1], the leak checking is not usable for the test suite, because we
are no longer calling `xmlCleanupParser()` on RSHUTDOWN of
ext/libxml[2], and therefore a few bogus leaks are reported whenever
ext/libxml is unloaded.

We therefore ignore memory leaks for this case.  We introduce
`ZEND_IGNORE_LEAKS_BEGIN()` and `ZEND_IGNORE_LEAKS_END()` to keep
those ignores better readable, and also because these *might* be
useful for other leak checkers as well.

We also explicitly free the `zend_handlers_table` and the `p5s` to
avoid spurious leak reports.

[1] &lt;http://git.php.net/?p=php-src.git;a=commit;h=d756e1db2324c1f4ab6f9b52e329959ce6a02bc3&gt;
[2] &lt;http://git.php.net/?p=php-src.git;a=commit;h=8742276eb3905eb97a585417000c7b8df85006d4&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
While basic support for MSVCRT debugging has been added long
ago[1], the leak checking is not usable for the test suite, because we
are no longer calling `xmlCleanupParser()` on RSHUTDOWN of
ext/libxml[2], and therefore a few bogus leaks are reported whenever
ext/libxml is unloaded.

We therefore ignore memory leaks for this case.  We introduce
`ZEND_IGNORE_LEAKS_BEGIN()` and `ZEND_IGNORE_LEAKS_END()` to keep
those ignores better readable, and also because these *might* be
useful for other leak checkers as well.

We also explicitly free the `zend_handlers_table` and the `p5s` to
avoid spurious leak reports.

[1] &lt;http://git.php.net/?p=php-src.git;a=commit;h=d756e1db2324c1f4ab6f9b52e329959ce6a02bc3&gt;
[2] &lt;http://git.php.net/?p=php-src.git;a=commit;h=8742276eb3905eb97a585417000c7b8df85006d4&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #79029 (Use After Free's in XMLReader / XMLWriter).</title>
<updated>2019-12-25T11:33:30+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@gmail.com</email>
</author>
<published>2019-12-25T11:05:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=27bb3289aceb5225e4dd39f082a48823756a8190'/>
<id>27bb3289aceb5225e4dd39f082a48823756a8190</id>
<content type='text'>
We backport the fix PHP 7.3, since this branch is affected as well.

(cherry picked from commit b5e004379647bd1ebb75eb2eac8826fb6abdd3d8)
(cherry picked from commit e36daa6927c05d2e687bb77495ef206cde118b33)
(cherry picked from commit 2704ee6844c03348de9d15e74646d09007ef0f7c)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We backport the fix PHP 7.3, since this branch is affected as well.

(cherry picked from commit b5e004379647bd1ebb75eb2eac8826fb6abdd3d8)
(cherry picked from commit e36daa6927c05d2e687bb77495ef206cde118b33)
(cherry picked from commit 2704ee6844c03348de9d15e74646d09007ef0f7c)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #79029 (Use After Free's in XMLReader / XMLWriter).</title>
<updated>2019-12-25T07:55:15+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@gmail.com</email>
</author>
<published>2019-12-25T07:55:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=e36daa6927c05d2e687bb77495ef206cde118b33'/>
<id>e36daa6927c05d2e687bb77495ef206cde118b33</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Fixed bug #79029 (Use After Free's in XMLReader / XMLWriter)"</title>
<updated>2019-12-25T07:27:10+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@gmail.com</email>
</author>
<published>2019-12-25T07:27:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=4c6e170c576ca92b7015eabe4ea6ac32383639d6'/>
<id>4c6e170c576ca92b7015eabe4ea6ac32383639d6</id>
<content type='text'>
This reverts commit d8ad2f4695ebd6dc2d4e668d9baeac1c071791a6.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit d8ad2f4695ebd6dc2d4e668d9baeac1c071791a6.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #79029 (Use After Free's in XMLReader / XMLWriter)</title>
<updated>2019-12-25T05:14:08+00:00</updated>
<author>
<name>Xinchen Hui</name>
<email>laruence@gmail.com</email>
</author>
<published>2019-12-25T05:14:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=d8ad2f4695ebd6dc2d4e668d9baeac1c071791a6'/>
<id>d8ad2f4695ebd6dc2d4e668d9baeac1c071791a6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.3' into PHP-7.4</title>
<updated>2019-09-22T16:43:24+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-09-22T16:43:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=3a937c46e0b81da62b00ab78776cc345a9316a31'/>
<id>3a937c46e0b81da62b00ab78776cc345a9316a31</id>
<content type='text'>
* PHP-7.3:
  Fix test to be skipped if dom is not available
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.3:
  Fix test to be skipped if dom is not available
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.2' into PHP-7.3</title>
<updated>2019-09-22T16:42:40+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-09-22T16:42:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=9c89f43d55e758525c1b948915d99b5c20fd9b04'/>
<id>9c89f43d55e758525c1b948915d99b5c20fd9b04</id>
<content type='text'>
* PHP-7.2:
  Fix test to be skipped if dom is not available
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.2:
  Fix test to be skipped if dom is not available
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix test to be skipped if dom is not available</title>
<updated>2019-09-22T16:42:02+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-09-22T16:39:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=697945aa89c060548e003d8ca6785faf5a35e898'/>
<id>697945aa89c060548e003d8ca6785faf5a35e898</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
