delta/php-git.git/ext/interbase, branch php-7.3.2 git.php.net: repository/php-src.git Sync leading and final newlines in *.phpt sections 2018-10-15T02:32:30+00:00 Peter Kokot peterkokot@gmail.com 2018-10-15T02:32:30+00:00 b746e6988743b46ccb0542d5d568eef0608ee296 This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2 
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.

According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
Trim trailing whitespace in *.phpt 2018-10-14T17:45:12+00:00 Peter Kokot peterkokot@gmail.com 2018-10-14T15:45:48+00:00 782352c54ad69c517e3c32b0dd2c25d74842647a 






Trim trailing whitespace in source code files
2018-10-13T12:16:33+00:00

Peter Kokot
peterkokot@gmail.com

2018-10-13T12:16:33+00:00

3362620b5f8716ce480b6f12269596c2d2351a52












Trim trailing whitespaces in build files
2018-07-29T01:43:45+00:00

Peter Kokot
petk@php.net

2018-07-29T01:43:45+00:00

cf3b852109a88a11370d0207cd3b72a53b6a64c3

Some editors utilizing .editorconfig automatically trim whitespaces. For
convenience this patch removes whitespaces in certain build files:
- ext/*/config*.m4
- configure.ac
- acinclude.m4





Some editors utilizing .editorconfig automatically trim whitespaces. For
convenience this patch removes whitespaces in certain build files:
- ext/*/config*.m4
- configure.ac
- acinclude.m4







Use variables that already received ZEND_NUM_ARGS()
2018-07-22T18:54:00+00:00

Gabriel Caruso
carusogabriel34@gmail.com

2018-07-22T18:54:00+00:00

8ca1f47a7a25f61fcc63313a771e6922e3258046












Fix failing test upstream
2018-07-16T02:40:00+00:00

Gabriel Caruso
carusogabriel34@gmail.com

2018-07-16T02:40:00+00:00

cf5f26b260adbcaf0349810724accb1dcc146878

There was a trailing tab when a error message was generated. Removing
it, test is passing now.





There was a trailing tab when a error message was generated. Removing
it, test is passing now.







Use zval_ptr_dtor() imstead of zval_dtor()
2018-07-05T14:55:54+00:00

Dmitry Stogov
dmitry@zend.com

2018-07-05T14:55:54+00:00

169d4545931a43df258608c6cfb59b3e4bb92776












Use zval_ptr_dtor_nogc() instead of zval_dtor() inplaces where circular-references are not possible
2018-07-05T12:25:55+00:00

Dmitry Stogov
dmitry@zend.com

2018-07-05T12:25:55+00:00

5f83904a5d76eb09afb8690509598645b84eb1f6












Use zval_ptr_dtor() instead of legacy zval_dtor(), to destroy unused values returned from PHP functions (they may be circular data structures).
2018-07-05T11:09:47+00:00

Dmitry Stogov
dmitry@zend.com

2018-07-05T11:09:47+00:00

83f6f8563cf776de2267124e0ebe8b6c0e9043a8












Replace legacy zval_dtor() by zval_ptr_dtor_nogc() or even more specialized destructors.
2018-07-04T16:22:24+00:00

Dmitry Stogov
dmitry@zend.com

2018-07-04T16:22:24+00:00

4a475a4976db92e71949786cdf5990c61514261e

zval_dtor() doesn't make a lot of sense in PHP-7.* and it's used incorrectly in some places.
Its occurances should be replaced by zval_ptr_dtor() or zval_ptr_dtor_nogc(), or even more specialized destructors.





zval_dtor() doesn't make a lot of sense in PHP-7.* and it's used incorrectly in some places.
Its occurances should be replaced by zval_ptr_dtor() or zval_ptr_dtor_nogc(), or even more specialized destructors.