<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/com_dotnet, branch php-7.3.20</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Add missing 'skip' to bug79332.phpt skip message</title>
<updated>2020-03-26T22:14:10+00:00</updated>
<author>
<name>Lukas Berger</name>
<email>berger.lukas@gmail.com</email>
</author>
<published>2020-03-26T17:39:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=7f9b534e3a3c8129b7ddcb86454483c43a309387'/>
<id>7f9b534e3a3c8129b7ddcb86454483c43a309387</id>
<content type='text'>
The skip message must start with the word 'skip', otherwise the test will not be skipped.

*Before:*
Running selected tests.
TEST 1/1 [ext/com_dotnet/tests/bug79332.phpt]
========DIFF========
001+ Fatal error: Uncaught Error: Class 'COMPersistHelper' not found in /srv/php/ext/com_dotnet/tests/bug79332.php:2
001- A com_exception has been thrown
002+ Stack trace:
003+ #0 {main}
004+   thrown in /srv/php/ext/com_dotnet/tests/bug79332.php on line 2
========DONE========
FAIL Bug #79332 (php_istreams are never freed) [ext/com_dotnet/tests/bug79332.phpt]

*After:*
Running selected tests.
SKIP Bug #79332 (php_istreams are never freed) [ext/com_dotnet/tests/bug79332.phpt] reason: com_dotnet extension not available
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The skip message must start with the word 'skip', otherwise the test will not be skipped.

*Before:*
Running selected tests.
TEST 1/1 [ext/com_dotnet/tests/bug79332.phpt]
========DIFF========
001+ Fatal error: Uncaught Error: Class 'COMPersistHelper' not found in /srv/php/ext/com_dotnet/tests/bug79332.php:2
001- A com_exception has been thrown
002+ Stack trace:
003+ #0 {main}
004+   thrown in /srv/php/ext/com_dotnet/tests/bug79332.php on line 2
========DONE========
FAIL Bug #79332 (php_istreams are never freed) [ext/com_dotnet/tests/bug79332.phpt]

*After:*
Running selected tests.
SKIP Bug #79332 (php_istreams are never freed) [ext/com_dotnet/tests/bug79332.phpt] reason: com_dotnet extension not available
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79333: com_print_typeinfo() leaks memory</title>
<updated>2020-03-02T10:36:30+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-03-02T10:36:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=53140e5c567af6cba0779e178394404f92213713'/>
<id>53140e5c567af6cba0779e178394404f92213713</id>
<content type='text'>
We have to free the `ansiname`s, regardless of whether they have been
put into the hashtable or not.

Since bug79299.phpt already shows the leak when run with a leak
checker, there is no need for another regression test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We have to free the `ansiname`s, regardless of whether they have been
put into the hashtable or not.

Since bug79299.phpt already shows the leak when run with a leak
checker, there is no need for another regression test.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79332: php_istreams are never freed</title>
<updated>2020-03-02T09:45:37+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-03-02T09:45:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=2adf1c4d23467424012db1971d0a0a678d10d782'/>
<id>2adf1c4d23467424012db1971d0a0a678d10d782</id>
<content type='text'>
Releasing the `com_dotnet_istream_wrapper` in `istream_destructor()` is
pointless, since `istream_destructor()` is only called when the
resource is going to be released.  This recursion is not a real issue,
though, since the resource is never exposed to userland, and has at
most refcount 1, so due to well defined unsigned integer underflow, it
never is released twice.  However, returning early in this case causes
a memory leak which needs to be fixed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Releasing the `com_dotnet_istream_wrapper` in `istream_destructor()` is
pointless, since `istream_destructor()` is only called when the
resource is going to be released.  This recursion is not a real issue,
though, since the resource is never exposed to userland, and has at
most refcount 1, so due to well defined unsigned integer underflow, it
never is released twice.  However, returning early in this case causes
a memory leak which needs to be fixed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79299: com_print_typeinfo prints duplicate variables</title>
<updated>2020-02-23T22:31:36+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-23T22:23:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=9e6358af36e71fa867b3de24dae2ec76d678c428'/>
<id>9e6358af36e71fa867b3de24dae2ec76d678c428</id>
<content type='text'>
`lastid` has to retain its value during the traversal, so we move it to
an outer scope.

Patch contributed by Litiano Moura.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`lastid` has to retain its value during the traversal, so we move it to
an outer scope.

Patch contributed by Litiano Moura.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79248: Traversing empty VT_ARRAY throws com_exception</title>
<updated>2020-02-08T16:05:29+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-08T15:56:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=f649adedfe3f0797cd0d6248e1b01c65b326f443'/>
<id>f649adedfe3f0797cd0d6248e1b01c65b326f443</id>
<content type='text'>
If the `VT_ARRAY` is empty, i.e. its upperbound is less than its lower
bound, we must not call `php_com_safearray_get_elem()`, because that
function throws in this case.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If the `VT_ARRAY` is empty, i.e. its upperbound is less than its lower
bound, we must not call `php_com_safearray_get_elem()`, because that
function throws in this case.
</pre>
</div>
</content>
</entry>
<entry>
<title>Skip test case on x86 where it otherwise fails [ci skip]</title>
<updated>2020-02-07T20:09:35+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-07T20:00:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=674d44ad7c03a0f815b00c8849e104676a398651'/>
<id>674d44ad7c03a0f815b00c8849e104676a398651</id>
<content type='text'>
`-2200000000` can't be converted to integer on x86, so the constructor
call would fail.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`-2200000000` can't be converted to integer on x86, so the constructor
call would fail.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #79242: COM error constants don't match com_exception codes</title>
<updated>2020-02-07T17:04:14+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-07T17:04:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=b9738f5802d15ba5d593ae09a6e63e49f9d7880f'/>
<id>b9738f5802d15ba5d593ae09a6e63e49f9d7880f</id>
<content type='text'>
Because a `HRESULT` is a `LONG`[1], no special treatment is required on
x86 platforms to get appropriate values.  On x64 platforms we prefer
positive values, what we could accomplish by casting the `HRESULT`
value to `ULONG` and then to `zend_long`, but since the current
behavior is correct and the performance improvement is negligible, we
defer that to master.

[1] &lt;https://docs.microsoft.com/en-us/windows/win32/winprog/windows-data-types#hresult&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Because a `HRESULT` is a `LONG`[1], no special treatment is required on
x86 platforms to get appropriate values.  On x64 platforms we prefer
positive values, what we could accomplish by casting the `HRESULT`
value to `ULONG` and then to `zend_long`, but since the current
behavior is correct and the performance improvement is negligible, we
defer that to master.

[1] &lt;https://docs.microsoft.com/en-us/windows/win32/winprog/windows-data-types#hresult&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #66322: COMPersistHelper::SaveToFile can save to wrong location</title>
<updated>2020-02-06T13:59:55+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2020-02-06T13:59:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=5e2ea00b1539d6003548f7698ece1f737c14fb51'/>
<id>5e2ea00b1539d6003548f7698ece1f737c14fb51</id>
<content type='text'>
Saving under the given `filename` may also work, but since
`::LoadFromFile` uses the `fullpath` we follow suit.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Saving under the given `filename` may also work, but since
`::LoadFromFile` uses the `fullpath` we follow suit.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.2' into PHP-7.3</title>
<updated>2019-10-19T09:49:18+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-10-19T09:48:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=ce035dc4a0732c090741c85f179f36a4b4b6b92d'/>
<id>ce035dc4a0732c090741c85f179f36a4b4b6b92d</id>
<content type='text'>
* PHP-7.2:
  Fix #78694: Appending to a variant array causes segfault
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.2:
  Fix #78694: Appending to a variant array causes segfault
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix #78694: Appending to a variant array causes segfault</title>
<updated>2019-10-19T09:47:00+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2019-10-19T09:41:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=45a7723267741be4867306d18b15a4a27d67b0f7'/>
<id>45a7723267741be4867306d18b15a4a27d67b0f7</id>
<content type='text'>
`write_dimension` object handlers have to be able to handle `NULL`
`offset`s; for now we simply throw an exception instead of following
the `NULL` pointer.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`write_dimension` object handlers have to be able to handle `NULL`
`offset`s; for now we simply throw an exception instead of following
the `NULL` pointer.
</pre>
</div>
</content>
</entry>
</feed>
