<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/php-git.git/ext/bcmath/libbcmath, branch php-7.3.2</title>
<subtitle>git.php.net: repository/php-src.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/'/>
<entry>
<title>Sync leading and final newlines in source code files</title>
<updated>2018-10-14T10:55:24+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-10-14T10:55:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=1c850bfcca97e0456a716a1889b5cf6c5e477cd8'/>
<id>1c850bfcca97e0456a716a1889b5cf6c5e477cd8</id>
<content type='text'>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines.

According to POSIX, a line is a sequence of zero or more non-' &lt;newline&gt;'
characters plus a terminating '&lt;newline&gt;' character. [1] Files should
normally have at least one final newline character.

C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."

Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
</pre>
</div>
</content>
</entry>
<entry>
<title>Trim trailing whitespace in source code files</title>
<updated>2018-10-13T12:16:33+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-10-13T12:16:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=3362620b5f8716ce480b6f12269596c2d2351a52'/>
<id>3362620b5f8716ce480b6f12269596c2d2351a52</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove build system files of bundled library libbcmath</title>
<updated>2018-05-29T16:56:50+00:00</updated>
<author>
<name>Peter Kokot</name>
<email>peterkokot@gmail.com</email>
</author>
<published>2018-05-28T06:08:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=28136b071a7eacac9ee78356c6a02c16bdabe265'/>
<id>28136b071a7eacac9ee78356c6a02c16bdabe265</id>
<content type='text'>
The bundled library libbcmath is maintained in the php-src and its
build system files are outdated and not used.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The bundled library libbcmath is maintained in the php-src and its
build system files are outdated and not used.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'pull-request/2742'</title>
<updated>2017-09-18T13:21:22+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-18T13:04:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=73af7a847c5f08d32802d41fc45ed4b01ec9fb9c'/>
<id>73af7a847c5f08d32802d41fc45ed4b01ec9fb9c</id>
<content type='text'>
* pull-request/2742:
  Fixed bug #66364 (BCMath bcmul ignores scale parameter)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* pull-request/2742:
  Fixed bug #66364 (BCMath bcmul ignores scale parameter)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'pull-request/2745'</title>
<updated>2017-09-13T14:21:30+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-13T14:16:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=18adc6f0fc974a6958f719db996a99a7e49ca9ef'/>
<id>18adc6f0fc974a6958f719db996a99a7e49ca9ef</id>
<content type='text'>
* pull-request/2745:
  Fixed bug #75169 (BCMath errors/warnings bypass error handling)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* pull-request/2745:
  Fixed bug #75169 (BCMath errors/warnings bypass error handling)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.2'</title>
<updated>2017-09-11T21:58:31+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-11T21:58:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=0d890025ec338b767afd8433d3d852d7a4bba1d8'/>
<id>0d890025ec338b767afd8433d3d852d7a4bba1d8</id>
<content type='text'>
* PHP-7.2:
  Fixed bug #46781 (BC math handles minus zero incorrectly)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.2:
  Fixed bug #46781 (BC math handles minus zero incorrectly)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.1' into PHP-7.2</title>
<updated>2017-09-11T21:52:14+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-11T21:51:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=77f3cef35ced72f4aa873427ec053763ed3f3771'/>
<id>77f3cef35ced72f4aa873427ec053763ed3f3771</id>
<content type='text'>
* PHP-7.1:
  Fixed bug #46781 (BC math handles minus zero incorrectly)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.1:
  Fixed bug #46781 (BC math handles minus zero incorrectly)
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'PHP-7.0' into PHP-7.1</title>
<updated>2017-09-11T21:46:21+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-11T21:45:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=87a91aef835c2c361e93b4352636f0dcb3275ac9'/>
<id>87a91aef835c2c361e93b4352636f0dcb3275ac9</id>
<content type='text'>
* PHP-7.0:
  Fixed bug #46781 (BC math handles minus zero incorrectly)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* PHP-7.0:
  Fixed bug #46781 (BC math handles minus zero incorrectly)
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #46781 (BC math handles minus zero incorrectly)</title>
<updated>2017-09-11T21:44:23+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-11T21:44:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=9aa6898b9be78bb1e138488c3204bb745a31aca7'/>
<id>9aa6898b9be78bb1e138488c3204bb745a31aca7</id>
<content type='text'>
Actually, there is no negative zero at all.  We obey Postel's law, and
still accept negative zeroes, but we store them as positive zeroes
after the conversion from string, i.e. we normalize before further
processing.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Actually, there is no negative zero at all.  We obey Postel's law, and
still accept negative zeroes, but we store them as positive zeroes
after the conversion from string, i.e. we normalize before further
processing.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed bug #75169 (BCMath errors/warnings bypass error handling)</title>
<updated>2017-09-09T21:57:22+00:00</updated>
<author>
<name>Christoph M. Becker</name>
<email>cmbecker69@gmx.de</email>
</author>
<published>2017-09-09T21:57:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/php-git.git/commit/?id=fd73a54c30a0851ae40a1a361ee4022236be6bcb'/>
<id>fd73a54c30a0851ae40a1a361ee4022236be6bcb</id>
<content type='text'>
Instead of writing warning messages to `stderr`, we employ PHP's error
handling to raise `E_WARNING` even for the single case where
`bc_rt_error()` has been called, since that did not actually error out.
We choose to call `php_error_docref()` directly in libbcmath, since
there is no upstream, and since other PHP core functionality is already
used in our bundled libbcmath. Accordingly, we remove `rt.c` so it will
not be accidentally used in the future.

Besides adapting a few existing tests, we add new tests so that the
warnings are tested at least once. We also get rid of the Windows
specific tests, since the warning behavior is now supposed to be
platform-agnostic.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of writing warning messages to `stderr`, we employ PHP's error
handling to raise `E_WARNING` even for the single case where
`bc_rt_error()` has been called, since that did not actually error out.
We choose to call `php_error_docref()` directly in libbcmath, since
there is no upstream, and since other PHP core functionality is already
used in our bundled libbcmath. Accordingly, we remove `rt.c` so it will
not be accidentally used in the future.

Besides adapting a few existing tests, we add new tests so that the
warnings are tested at least once. We also get rid of the Windows
specific tests, since the warning behavior is now supposed to be
platform-agnostic.
</pre>
</div>
</content>
</entry>
</feed>
