From af4c193250c891af3d50973aaf995b6279fda0a1 Mon Sep 17 00:00:00 2001 From: Octavian Ciuhandu Date: Tue, 18 Mar 2014 19:54:00 +0200 Subject: Fixes blocking issue on Windows On Windows, environment variables can not be unicode. Change-Id: I8c7fd7627d7f733e0db8690a39e7128b7fe2ebcf Closes-bug: #1294246 --- pbr/packaging.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pbr/packaging.py b/pbr/packaging.py index c39f5f7..21b2b82 100644 --- a/pbr/packaging.py +++ b/pbr/packaging.py @@ -87,9 +87,11 @@ def _pip_install(links, requires, root=None, option_dict=dict()): for link in links: cmd.append("-f") cmd.append(link) + + # NOTE(ociuhandu): popen on Windows does not accept unicode strings _run_shell_command( cmd + requires, - throw_on_error=True, buffer=False, env=dict(PIP_USE_WHEEL="true")) + throw_on_error=True, buffer=False, env=dict(PIP_USE_WHEEL=b"true")) def _any_existing(file_list): -- cgit v1.2.1