delta/patch.git/src, branch baserock/morph

maint: enable the useless_cpp_parens syntax-check rule

2012-01-01T10:12:43+00:00

* cfg.mk (local-checks-to-skip): Remove sc_useless_cpp_parens,
thus enabling this syntax-check rule.
* src/patch.c: Remove unneeded parentheses.

maint: update all copyright year number ranges

2012-01-01T09:26:02+00:00

Run "make update-copyright".

build: update to latest gnulib and adapt

2011-12-14T15:34:45+00:00

Mark functions as pure of const, per recommendations enabled by
new gcc -W options.  Apply _GL_ATTRIBUTE_PURE and _GL_ATTRIBUTE_CONST.
* src/common.h: Apply new function attributes.
* src/pch.c: Likewise.
* src/pch.h: Likewise.
* src/util.c: Likewise.
* src/util.h: Likewise.
* configure.ac: Use -Wno-format-nonliteral.
* m4/.gitignore: Update.
* gnulib: Update to latest.
* cfg.mk: Exempt src/util.c from two tests, to avoid new
"make syntax-check" failures.

Timestamp not set when creating files with --set-time or --set-utc

2011-12-08T23:53:38+00:00

* src/util.h (enum file_attributes): Add FA_XATTRS flag for extended
attributes.
* src/patch.c (main): Use set_file_attributes() even when the infile doesn't
exist: it may still set the file time (FA_TIMES).  Omit all other FA_ flags if
infile doesn't exist.  Otherwise, add FA_XATTRS as well.
* src/util.c (set_file_attributes): Only copy extended attributes if FA_XATTRS
is set.  Avoid using st where it may be undefined.
* tests/preserve-mode-and-timestamp: Add file create test.

give a diagnostic rather than a failed assertion for a mangled patch

2011-10-11T01:31:57+00:00

* src/pch.c (another_hunk): Rather than asserting(C), issue the
"replacement text or line numbers mangled ..." diagnostic when !C.
* tests/mangled-numbers-abort: New test for the above.
* tests/Makefile.am (TESTS): Add it.
* NEWS: Mention it.
Reported by Gabriel Vlasiu via Tim Waugh.
See also http://bugzilla.redhat.com/738959

don't call fdopen with a negative FD upon dup failure

2011-05-25T14:47:33+00:00

* src/patch.c (open_outfile): If dup fails, don't clobber its
errno value by calling fdopen with -1.

plug a leak in inp.c's plan_a

2011-05-25T14:47:33+00:00

* src/inp.c (plan_a): Don't leak "buffer" upon early return.

emit one more diagnostic with the required "program_name: " prefix

2011-05-25T14:47:33+00:00

* src/util.c: Include "error.h".
(ask): Use error, not perror.  The latter would not have included
the usual "program name: " prefix.

remove side effect from assert

2011-05-25T14:47:33+00:00

* src/util.c (parse_c_string): Don't increment "s" in assert.

explicitly ignore close return value to placate static analyzers

2011-05-25T14:47:33+00:00

* src/util.c: Include "ignore-value.h".
(ask): Use ignore_value to tell tools that yes, we really do
mean to ignore any close failure on this error path.
* bootstrap.conf (gnulib_modules): Add ignore-value.