delta/patch.git/src/util.c, branch baserock/morph

maint: update all copyright year number ranges

2012-01-01T09:26:02+00:00

Run "make update-copyright".

build: update to latest gnulib and adapt

2011-12-14T15:34:45+00:00

Mark functions as pure of const, per recommendations enabled by
new gcc -W options.  Apply _GL_ATTRIBUTE_PURE and _GL_ATTRIBUTE_CONST.
* src/common.h: Apply new function attributes.
* src/pch.c: Likewise.
* src/pch.h: Likewise.
* src/util.c: Likewise.
* src/util.h: Likewise.
* configure.ac: Use -Wno-format-nonliteral.
* m4/.gitignore: Update.
* gnulib: Update to latest.
* cfg.mk: Exempt src/util.c from two tests, to avoid new
"make syntax-check" failures.

Timestamp not set when creating files with --set-time or --set-utc

2011-12-08T23:53:38+00:00

* src/util.h (enum file_attributes): Add FA_XATTRS flag for extended
attributes.
* src/patch.c (main): Use set_file_attributes() even when the infile doesn't
exist: it may still set the file time (FA_TIMES).  Omit all other FA_ flags if
infile doesn't exist.  Otherwise, add FA_XATTRS as well.
* src/util.c (set_file_attributes): Only copy extended attributes if FA_XATTRS
is set.  Avoid using st where it may be undefined.
* tests/preserve-mode-and-timestamp: Add file create test.

emit one more diagnostic with the required "program_name: " prefix

2011-05-25T14:47:33+00:00

* src/util.c: Include "error.h".
(ask): Use error, not perror.  The latter would not have included
the usual "program name: " prefix.

remove side effect from assert

2011-05-25T14:47:33+00:00

* src/util.c (parse_c_string): Don't increment "s" in assert.

explicitly ignore close return value to placate static analyzers

2011-05-25T14:47:33+00:00

* src/util.c: Include "ignore-value.h".
(ask): Use ignore_value to tell tools that yes, we really do
mean to ignore any close failure on this error path.
* bootstrap.conf (gnulib_modules): Add ignore-value.

plug a leak in fetchname

2011-05-25T14:47:32+00:00

* src/util.c (fetchname): Don't leak "timestr" when returning early.

avoid a used-uninitialized error in fetchname

2011-05-25T14:47:00+00:00

* src/util.c (fetchname): Avoid a used-uninitialized error.
Before, when "*t == '\n'", stamp.tv_nsec would have been
used undefined.  The fix is to set that member rather than
stamp.tv_sec, which is already set to the desired value.
This was reported by coverity.

maint: remove now-unneeded macro definitions

2011-03-27T07:19:46+00:00

* bootstrap.conf (gnulib_modules): Include gnulib's signal module,
so that signal.h guarantees definition of certain macros.
* src/util.c (SIG_BLOCK, SIG_UNBLOCK, SIG_SETMASK): Remove definition.
Now, gnulib guarantees that these are defined.
* src/common.h (SIZE_MAX): Likewise.
* cfg.mk (local-checks-to-skip): Enable the
sc_prohibit_always-defined_macros check, now that it passes.

Ignore dangerous filenames instead of failing immediately

2011-02-16T11:01:19+00:00

* src/pch.c (name_is_valid): New function.
(intuit_diff_type, best_name): Use name_is_valid() here.
(strip_leading_slashes): Remove name validation tests from here.
* tests/bad-filenames: Add more tests for covering more of the
file name guessing corner cases in intuit_diff_type(), update the
existing tests.
* NEWS: Update.