From f25b46a303bda213107c4493ed52c8a023b6205d Mon Sep 17 00:00:00 2001 From: Jean-Marc Valin Date: Fri, 2 Sep 2016 02:36:16 -0400 Subject: misc fixes to update draft --- doc/draft-ietf-codec-opus-update.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/draft-ietf-codec-opus-update.xml b/doc/draft-ietf-codec-opus-update.xml index ea5a7a67..767f4f98 100644 --- a/doc/draft-ietf-codec-opus-update.xml +++ b/doc/draft-ietf-codec-opus-update.xml @@ -229,8 +229,8 @@ RESAMPLER_ORDER_FIR_12 * sizeof( opus_int16 ) ); It was discovered through decoder fuzzing that some bitstreams could produce integer values exceeding 32-bits in LPC_inverse_pred_gain_QA(), causing a wrap-around. Although the error is harmless in practice, the C standard considers - the behaviour as undefined, so the following patch detects values - that would cause wrap-around and considers the corresponding filters unstable: + the behavior as undefined, so the following patch to line 87 of silk/LPC_inv_pred_gain.c + detects values that do not fit in a 32-bit integer and considers the corresponding filters unstable:
- To address the issue, we change the folding behaviour so that it is + To address the issue, we change the folding behavior so that it is never forced to fall back to LCG due to the first band not containing enough coefficients to fold onto the second band. This is achieved by simply repeating part of the first band in the folding @@ -345,7 +345,7 @@ effective_lowband+N); The fix does not impact compatibility, because the improvement does not depend on the encoder doing anything special. There is also no - reasonable way for an encoder to use the original behaviour to + reasonable way for an encoder to use the original behavior to improve quality over the proposed change. -- cgit v1.2.1