From e6b5b8a98ce21d4b8374370b5d7592ead4b351e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Tue, 8 Dec 2020 17:29:57 +0100 Subject: Fix extra compiler warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes following -Wextra compiler warnings: uclient.c:195:16: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] for (i = 0; i < ARRAY_SIZE(backends); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~ uclient-http.c:619:2: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] blobmsg_for_each_attr(cur, uh->headers.head, rem) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ uclient-http.c:619:2: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] blobmsg_for_each_attr(cur, uh->headers.head, rem) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ uclient-http.c:993:16: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] for (i = 0; i < ARRAY_SIZE(request_types); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ uclient.c:195:16: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] for (i = 0; i < ARRAY_SIZE(backends); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~ uclient-http.c:619:2: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] blobmsg_for_each_attr(cur, uh->headers.head, rem) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ uclient-http.c:619:2: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] blobmsg_for_each_attr(cur, uh->headers.head, rem) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ uclient-http.c:993:16: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] for (i = 0; i < ARRAY_SIZE(request_types); i++) { ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ uclient-fetch.c:551:67: error: missing field 'flag' initializer [-Werror,-Wmissing-field-initializers] [L_NO_CHECK_CERTIFICATE] = { "no-check-certificate", no_argument }, Signed-off-by: Petr Štetiar --- uclient-fetch.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) (limited to 'uclient-fetch.c') diff --git a/uclient-fetch.c b/uclient-fetch.c index 061f0fd..5f7ac62 100644 --- a/uclient-fetch.c +++ b/uclient-fetch.c @@ -497,7 +497,7 @@ static int usage(const char *progname) static void init_ca_cert(void) { glob_t gl; - int i; + unsigned int i; glob("/etc/ssl/certs/*.crt", 0, NULL, &gl); for (i = 0; i < gl.gl_pathc; i++) @@ -548,20 +548,20 @@ enum { }; static const struct option longopts[] = { - [L_NO_CHECK_CERTIFICATE] = { "no-check-certificate", no_argument }, - [L_CA_CERTIFICATE] = { "ca-certificate", required_argument }, - [L_CIPHERS] = { "ciphers", required_argument }, - [L_USER] = { "user", required_argument }, - [L_PASSWORD] = { "password", required_argument }, - [L_USER_AGENT] = { "user-agent", required_argument }, - [L_POST_DATA] = { "post-data", required_argument }, - [L_POST_FILE] = { "post-file", required_argument }, - [L_SPIDER] = { "spider", no_argument }, - [L_TIMEOUT] = { "timeout", required_argument }, - [L_CONTINUE] = { "continue", no_argument }, - [L_PROXY] = { "proxy", required_argument }, - [L_NO_PROXY] = { "no-proxy", no_argument }, - [L_QUIET] = { "quiet", no_argument }, + [L_NO_CHECK_CERTIFICATE] = { "no-check-certificate", no_argument, NULL, 0 }, + [L_CA_CERTIFICATE] = { "ca-certificate", required_argument, NULL, 0 }, + [L_CIPHERS] = { "ciphers", required_argument, NULL, 0 }, + [L_USER] = { "user", required_argument, NULL, 0 }, + [L_PASSWORD] = { "password", required_argument, NULL, 0 }, + [L_USER_AGENT] = { "user-agent", required_argument, NULL, 0 }, + [L_POST_DATA] = { "post-data", required_argument, NULL, 0 }, + [L_POST_FILE] = { "post-file", required_argument, NULL, 0 }, + [L_SPIDER] = { "spider", no_argument, NULL, 0 }, + [L_TIMEOUT] = { "timeout", required_argument, NULL, 0 }, + [L_CONTINUE] = { "continue", no_argument, NULL, 0 }, + [L_PROXY] = { "proxy", required_argument, NULL, 0 }, + [L_NO_PROXY] = { "no-proxy", no_argument, NULL, 0 }, + [L_QUIET] = { "quiet", no_argument, NULL, 0 }, {} }; -- cgit v1.2.1