delta/openvswitch.git, branch branch-2.4

travis: Remove sparse support.

2019-03-18T20:37:42+00:00

"sparse" failed to build with this old branch, see e.g.
https://travis-ci.org/openvswitch/ovs/jobs/436851158

Signed-off-by: Ben Pfaff

list: New macro OVS_LIST_POISON for initializing a poisoned list.

2019-03-18T20:17:25+00:00

To be used in an upcoming commit.

Signed-off-by: Ben Pfaff 
Acked-by: Jarno Rajahalme

ofpbuf: New macro OFPBUF_STUB_INITIALIZER.

2019-03-18T20:17:20+00:00

To be used in an upcoming commit.

Signed-off-by: Ben Pfaff 
Acked-by: Jarno Rajahalme

travis: Remove 'sudo' configuration.

2019-03-06T22:31:17+00:00

Since TravisCI migrated jobs from containers to VMs, 'sudo' is always
available. Setting 'sudo: false' is misleading because it makes no
effect.

https://docs.travis-ci.com/user/reference/trusty/#container-based-infrastructure

 "Container-based infrastructure is currently being deprecated.
  Please remove any sudo: false keys in your .travis.yml file to use
  the default fully-virtualized Linux infrastructure instead."

Acked-by: Aaron Conole 
Signed-off-by: Ilya Maximets 
Signed-off-by: Ben Pfaff

odp-util: Stop parse odp actions if nlattr is overflow

2019-02-04T20:44:59+00:00

`encap = nl_msg_start_nested(key, OVS_KEY_ATTR_ENCAP)` ensures that
key->size >= (encap + NLA_HDRLEN), so the `if` statement is safe.

Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11306
Signed-off-by: Yifeng Sun 
Signed-off-by: Ben Pfaff

netdev-linux: Fix function argument order in sfq_tc_load().

2019-01-18T00:33:09+00:00

sfq_install__() takes quantum before perturb.

Acked-by: Justin Pettit 
Reported-by: shaoke xi 
Signed-off-by: Ben Pfaff

python: Escape backslashes while formatting logs.

2019-01-15T17:13:06+00:00

Since python version 3.7 (and some 3.6+ versions) regexp engine
changed to treat the wrong escape sequences as errors. Previously,
if the replace string had something like '\u0000', '\u' was
qualified as a bad escape sequence and treated just as a sequence
of characters '\' and 'u'. But know this triggers an error:

  Traceback (most recent call last):
    File "/usr/lib/python3.7/sre_parse.py", line 1021, in parse_template
      this = chr(ESCAPES[this][1])
  KeyError: '\\u'

From the documentation [1]:

  Unknown escapes consisting of '\' and an ASCII letter in replacement
  templates for re.sub() were deprecated in Python 3.5, and will now
  cause an error.

[1] https://docs.python.org/3/whatsnew/3.7.html#api-and-feature-removals

We need to escape the backslash by another one to keep regexp engine
from errors. In case of '\\u000', '\\' is a valid escape sequence
and the 'u' is a simple character.

To be 100% safe we need to use 're.escape(replace)', but it escapes
too many characters making the logs hard to read.

This change fixes Python 3 tests on systems with python 3.7.
Should be backward compatible.

Reported-by: Ben Pfaff 
Signed-off-by: Ilya Maximets 
Signed-off-by: Ben Pfaff

cmap: Fix hashing in cmap_find_protected().

2018-12-24T17:32:20+00:00

cmap_find_protected calculated wrong h2 hash which causing entries with
duplicated id inserted into the cmap.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-December/047945.html
Signed-off-by: Zang MingJie 
Signed-off-by: Ben Pfaff

python: Catch setsockopt exceptions for TCP stream.

2018-12-20T18:12:28+00:00

'sock.setsockopt' could throw exceptions. For example, if non-blocking
connection failed before the call:

  Traceback (most recent call last):
    File "../.././test-ovsdb.py", line 896, in 
      main(sys.argv)
    File "../.././test-ovsdb.py", line 891, in main
      func(*args)
    File "../.././test-ovsdb.py", line 604, in do_idl
      ovs.stream.Stream.open(r))
    File "/root/git_/ovs/python/ovs/stream.py", line 190, in open
      error, sock = cls._open(suffix, dscp)
    File "/root/git_/ovs/python/ovs/stream.py", line 744, in _open
      sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
    File "/usr/local/lib/python2.7/socket.py", line 228, in meth
      return getattr(self._sock,name)(*args)
  socket.error: [Errno 54] Connection reset by peer

This fixes tests on FreeBSD.

Signed-off-by: Ilya Maximets 
Signed-off-by: Ben Pfaff

datapath-windows: Fix invalid reference in Buffermgmt.c

2018-11-15T15:00:58+00:00

OVS_BUFFER_CONTEXT gets cleared as part of NdisFreeNetBufferListContext
function call. This causes an invalid reference error.

Found while testing with driver verifier enabled.

Signed-off-by: Sairam Venugopal 
Acked-by: Anand Kumar 
Acked-by: Alin Gabriel Serdean 
Signed-off-by: Alin Gabriel Serdean