From 9aeafe9f5e0aa8e16638325efd86ffe96ddfa128 Mon Sep 17 00:00:00 2001 From: Matthew Treinish Date: Tue, 23 Jun 2015 14:19:12 +0000 Subject: Revert "Adding support for neutron-debug CLI." There isn't a reason to have a function to call this command live in tempest-lib. The neutron-debug CLI is only used for local debug and isn't actually a client. It's for running locally on the same node as neutron. It's completely out of scope for living in tempest-lib. Just because there is a CLI for something in an OpenStack project running doesn't mean we need to have a dedicated function to call it. It's a simple matter to locally subclass the CLIClient class and add local functions to call commands for a particular test suite. So let's revert this before it's included in a release. If it were to be included in a release the effort to remove it goes up quite a bit, because we need a proper deprecation cycle. This reverts commit 43c45b2b9dc6b5369556feb94431ed3e22185d34. Change-Id: I8e77dd92abd482e6cdbaceff81dc12b9f224e2ec --- tempest_lib/cli/base.py | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/tempest_lib/cli/base.py b/tempest_lib/cli/base.py index 5717e07..ec966ca 100644 --- a/tempest_lib/cli/base.py +++ b/tempest_lib/cli/base.py @@ -285,29 +285,6 @@ class CLIClient(object): return self.cmd_with_auth( 'neutron', action, flags, params, fail_ok, merge_stderr) - def neutron_debug(self, action, flags='', params='', fail_ok=False, - endpoint_type='publicURL', merge_stderr=False): - """Executes neutron-debug command for the given action. - - :param action: the cli command to run using neutron - :type action: string - :param flags: any optional cli flags to use - :type flags: string - :param params: any optional positional args to use - :type params: string - :param fail_ok: if True an exception is not raised when the - cli return code is non-zero - :type fail_ok: boolean - :param endpoint_type: the type of endpoint for the service - :type endpoint_type: string - :param merge_stderr: if True the stderr buffer is merged into stdout - :type merge_stderr: boolean - """ - - return execute( - 'neutron-debug', action, flags, params, fail_ok, merge_stderr, - self.cli_dir) - def sahara(self, action, flags='', params='', fail_ok=False, endpoint_type='publicURL', merge_stderr=True): """Executes sahara command for the given action. -- cgit v1.2.1