<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/taskflow.git/taskflow/tests, branch 2.9.0</title>
<subtitle>opendev.org: openstack/taskflow.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/'/>
<entry>
<title>Use assertIs(Not)None to check for None</title>
<updated>2016-11-07T08:50:39+00:00</updated>
<author>
<name>howardlee</name>
<email>lihongweibj@inspur.com</email>
</author>
<published>2016-11-07T08:50:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=51a6a8b687c0508707c62bbb1adfd5744d119cce'/>
<id>51a6a8b687c0508707c62bbb1adfd5744d119cce</id>
<content type='text'>
[H203] Use assertIs(Not)None to check for None (off by default) Unit
test assertions tend to give better messages for more specific
assertions. As a result, assertIsNone(...) is preferred over
assertEqual(None, ...) and assertIs(None, ...), and assertIsNotNone(...)
is preferred over assertNotEqual(None, ...) and assertIsNot(None,
...). Off by default.

Trivial fix

Change-Id: I5b6ac7d99f0689843eb98cb3e9b9b10531322640
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
[H203] Use assertIs(Not)None to check for None (off by default) Unit
test assertions tend to give better messages for more specific
assertions. As a result, assertIsNone(...) is preferred over
assertEqual(None, ...) and assertIs(None, ...), and assertIsNotNone(...)
is preferred over assertNotEqual(None, ...) and assertIsNot(None,
...). Off by default.

Trivial fix

Change-Id: I5b6ac7d99f0689843eb98cb3e9b9b10531322640
</pre>
</div>
</content>
</entry>
<entry>
<title>Using assertIsNone() instead of assertIs(None, ..)</title>
<updated>2016-10-10T08:50:21+00:00</updated>
<author>
<name>qinchunhua</name>
<email>qin.chunhua@zte.com.cn</email>
</author>
<published>2016-10-10T08:43:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=e68032929cd241baab782a5bbaa45fe46df70b05'/>
<id>e68032929cd241baab782a5bbaa45fe46df70b05</id>
<content type='text'>
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None).

Change-Id: I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None).

Change-Id: I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d
</pre>
</div>
</content>
</entry>
<entry>
<title>Some classes not define __ne__() built-in function</title>
<updated>2016-08-31T10:57:50+00:00</updated>
<author>
<name>Ji-Wei</name>
<email>ji.wei3@zte.com.cn</email>
</author>
<published>2016-08-31T10:23:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=e26f09e0d14d7a1a763596dd8a6029237e5ce530'/>
<id>e26f09e0d14d7a1a763596dd8a6029237e5ce530</id>
<content type='text'>
Some classes defines __eq__() built-in function, but does
not define __ne__() built-in function, so self.assertEqual works
but self.assertNotEqual does not work at all in this test case in
python2. This patch fixes it.

Change-Id: I3e4f213081268bad44583a63a84795d39094117f
Closes-Bug: #1586268
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some classes defines __eq__() built-in function, but does
not define __ne__() built-in function, so self.assertEqual works
but self.assertNotEqual does not work at all in this test case in
python2. This patch fixes it.

Change-Id: I3e4f213081268bad44583a63a84795d39094117f
Closes-Bug: #1586268
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace assertEqual(None, *) with assertIsNone in tests</title>
<updated>2016-07-12T03:46:19+00:00</updated>
<author>
<name>weiweigu</name>
<email>gu.weiwei@zte.com.cn</email>
</author>
<published>2016-07-12T03:41:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=38c58123caa559104f0ad7cfd52dd6373792398f'/>
<id>38c58123caa559104f0ad7cfd52dd6373792398f</id>
<content type='text'>
Replace assertEqual(None, *) with assertIsNone in tests to have more
clear messages in case of failure.

Change-Id: I74452af6d840bcf612fd3bb2521db9134460dd63
Closes-Bug: #1280522
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace assertEqual(None, *) with assertIsNone in tests to have more
clear messages in case of failure.

Change-Id: I74452af6d840bcf612fd3bb2521db9134460dd63
Closes-Bug: #1280522
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Make tests less dependent on transient state"</title>
<updated>2016-07-08T19:58:06+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-07-08T19:58:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=66e2399a45ec9fcb3aaf35b1df850d5a3ec6d658'/>
<id>66e2399a45ec9fcb3aaf35b1df850d5a3ec6d658</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Fix some misspellings in the function name and descriptions"</title>
<updated>2016-07-08T19:49:36+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-07-08T19:49:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=7be8c9873aad6cbbed835d9648bec2caa2ef903a'/>
<id>7be8c9873aad6cbbed835d9648bec2caa2ef903a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix some misspellings in the function name and descriptions</title>
<updated>2016-06-30T15:44:49+00:00</updated>
<author>
<name>Pablo Iranzo Gómez</name>
<email>Pablo.Iranzo@gmail.com</email>
</author>
<published>2016-06-30T14:28:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=74221942ef29f75a6bacf461e95df88c792136f5'/>
<id>74221942ef29f75a6bacf461e95df88c792136f5</id>
<content type='text'>
Change-Id: I7e3451feb94b1f25b00c5e7b197bb6b527548306
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I7e3451feb94b1f25b00c5e7b197bb6b527548306
</pre>
</div>
</content>
</entry>
<entry>
<title>Add tests to verify kwargs behavior on revert validation</title>
<updated>2016-06-09T13:03:46+00:00</updated>
<author>
<name>Greg Hill</name>
<email>greg.hill@rackspace.com</email>
</author>
<published>2016-06-09T13:03:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=599b2709b0c6662676b2ec883a67b8e07e52881b'/>
<id>599b2709b0c6662676b2ec883a67b8e07e52881b</id>
<content type='text'>
A bug was reported where a task's revert method was throwing an
'extra args' exception even though it had a **kwargs to slurp up
any extra args.  I added some tests to duplicate the behavior but
the tests all pass.  I'm hoping pushing this up will cause CI to
reproduce the bug so I can diagnose it further.

Change-Id: I9f4d0f065f11370f7981e93349f473df2bb1015d
Closes-Bug: #1589848
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A bug was reported where a task's revert method was throwing an
'extra args' exception even though it had a **kwargs to slurp up
any extra args.  I added some tests to duplicate the behavior but
the tests all pass.  I'm hoping pushing this up will cause CI to
reproduce the bug so I can diagnose it further.

Change-Id: I9f4d0f065f11370f7981e93349f473df2bb1015d
Closes-Bug: #1589848
</pre>
</div>
</content>
</entry>
<entry>
<title>Make tests less dependent on transient state</title>
<updated>2016-06-02T17:46:55+00:00</updated>
<author>
<name>Greg Hill</name>
<email>greg.hill@rackspace.com</email>
</author>
<published>2016-06-02T17:46:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=6e21e3192058f58e19596b7eb7c9cfa887bd49e2'/>
<id>6e21e3192058f58e19596b7eb7c9cfa887bd49e2</id>
<content type='text'>
Having to update the endpoint count every time  you add a test
class is really obnoxious and leads to a ton of pointless rebasing.
Now we just check that it finds at least the task it knows about
and call that good.

Change-Id: I96b8c6cd6cbc1fdc58dee4b18cab5699e3daa844
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Having to update the endpoint count every time  you add a test
class is really obnoxious and leads to a ton of pointless rebasing.
Now we just check that it finds at least the task it knows about
and call that good.

Change-Id: I96b8c6cd6cbc1fdc58dee4b18cab5699e3daa844
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Add a simple sanity test for pydot outputting"</title>
<updated>2016-05-31T00:13:58+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-05-31T00:13:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/taskflow.git/commit/?id=8d1fb6fe1659494a48b16a184f11590ad459ed76'/>
<id>8d1fb6fe1659494a48b16a184f11590ad459ed76</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
