delta/openstack/python-troveclient.git/troveclient/compat, branch stable/train

Update hacking version

2019-01-02T15:57:05+00:00

1. update hacking version to latest
2. fix pep8 failed

Change-Id: I49a6d46466b06bd56bed1f15632c9c80ef539b38

Fix python3 compatibility issues

2018-08-31T12:51:32+00:00

While executing functional tests in trove project, with baseptyhon
python3 in change [1], there appears few incompatibilities
in troveclient.

All of them are directly related to differences in PY3 version.

This change removes these issues and will allow to execute functional
tests seamlessly.

Change details:
  * troveclient/compat/base.py - dict.iteritems was removed in PY3
    because dict.items now does the thing dict.iteritems did in PY2
  * troveclient/compat/client.py - json.loads expects string, and
    PY3 doesnt convert bytes to string. We have to use explicity call
    decode() which will decode given bytes to string
  * troveclient/apiclient/base.py - to avoid infinite recursion
    exception raised when pickling class attributes

[1] I9ee34642c700d1e6ba9c2f3891b7fa1f7f7e1e1d

Change-Id: I8989fd4798e80eae27408017e1543819a68b4ab1
Signed-off-by: Marcin Piwowarczyk

Enable Keystone v3 support for compat client

2017-10-09T19:40:44+00:00

Enable Keystone v3 auth support in the compat client.
This is needed for the Trove integration and scenario tests which
use the compat client. The Keystone v2 APIs have been removed in
the Queens release and this stop-gap fix of putting Keystone v3
support in the compat client is needed to fix the Trove gate.

Change-Id: I60ea2188443d8905c03c24607703e69c6490420b

Handle log message interpolation by the logger

2017-03-08T18:00:34+00:00

According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

Also, upgraded hacking requirement, to enable H904 check.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Co-Authored-By: jiansong 
Change-Id: I3f020b6bcb1b9bf6d18a3b4f738c13cccd1bbff8
Closes-Bug: #1596829

Avoid use xx=[] for parameter in function

2016-10-19T02:08:46+00:00

Use xx = [] for the parameter for function, this parameter will
only be initialized at the first call, this is should be avoided.
Better choice is to set the initial value to None, then the initialization
time use xx= xx or []

more information:http://effbot.org/zone/default-values.htm

Change-Id: Icbade7dd4c7d231ae65fd4f8de673b484bab721c

Using assertIsNotNone() instead of assertNotEqual(None)

2016-10-03T02:33:04+00:00

Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNotNone(...) is preferred
over assertNotEqual(None, ...) and assertIsNot(None, ...)

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: Ie2631ce6d5f1756fe520850be0e0d304f41ba760

Use strutils.to_slug() instead of utils.slugify()

2016-09-06T01:17:51+00:00

Oslo provides a function, to_slug() in strutils that is substantially
similar to slugify() provided in utils by python-troveclient. Remove
slugify() and use to_slug() instead.

Change-Id: I97bc7cfc2c0e7d14e7617037bff431cdc1eee50f
Closes-Bug: #1266127
Author: Christian Berendt

Make dict.keys() PY3 compatible

2016-06-21T15:08:32+00:00

The dict.keys()[0] will raise a TypeError in PY3,
as dict.keys() doesn't return a list any more in PY3
but a view of list.

Change-Id: Id9c7d3725c01bd0a193d8fc6705443efe9c25c34
Partially implements: blueprint trove-python3
Closes-Bug: #1583419

Remove Rackspace auth references from troveclient

2016-05-18T18:16:25+00:00

Removing the Rackspace Auth references that are not
supported by an openstack deployment.

Co-Authored-By: Craig Vyvial 

Change-Id: I7e630a77eaeb31de0962b31bc2f86becf2975dd8
Closes-Bug: #1401804

Add suport for module maintenance commands

2016-02-25T01:05:39+00:00

This adds support in the python API and Trove CLI
for module maintenance commands.  These commands include:

    - module-list
    - module-show
    - module-create
    - module-update
    - module-delete

Partially Implements: blueprint module-management
Change-Id: I54d37025275dee4731ad49ebbd21612c4464e4c4