From 1626b63f5698918ac73ec407b1922fc006b0db66 Mon Sep 17 00:00:00 2001 From: Bin Zhou Date: Fri, 2 Sep 2016 12:05:58 +0800 Subject: Use assertIn(A, B) instead of assertTrue(A in B ) Developers should use assertIn(A, B) instead of assertTrue(A in B ). TrivialFix Change-Id: I0d7c542272315590536c427a8865e49660361e55 --- openstackclient/tests/common/test_module.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'openstackclient/tests/common') diff --git a/openstackclient/tests/common/test_module.py b/openstackclient/tests/common/test_module.py index 7d08dae7..8d5bb5f1 100644 --- a/openstackclient/tests/common/test_module.py +++ b/openstackclient/tests/common/test_module.py @@ -106,8 +106,8 @@ class TestModuleList(utils.TestCommand): columns, data = self.cmd.take_action(parsed_args) # Additional modules may be present, just check our additions - self.assertTrue(module_name_1 in columns) - self.assertTrue(module_version_1 in data) + self.assertIn(module_name_1, columns) + self.assertIn(module_version_1, data) def test_module_list_all(self): arglist = [ @@ -124,7 +124,7 @@ class TestModuleList(utils.TestCommand): columns, data = self.cmd.take_action(parsed_args) # Additional modules may be present, just check our additions - self.assertTrue(module_name_1 in columns) - self.assertTrue(module_name_2 in columns) - self.assertTrue(module_version_1 in data) - self.assertTrue(module_version_2 in data) + self.assertIn(module_name_1, columns) + self.assertIn(module_name_2, columns) + self.assertIn(module_version_1, data) + self.assertIn(module_version_2, data) -- cgit v1.2.1