From 258c1102cc6b93a860bcd7cc083d4e14ae0025ce Mon Sep 17 00:00:00 2001
From: Akihiro Motoki <motoki@da.jp.nec.com>
Date: Sun, 10 Jan 2016 21:54:53 +0900
Subject: log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
---
 openstackclient/identity/v3/domain.py | 26 ++++----------------------
 1 file changed, 4 insertions(+), 22 deletions(-)

(limited to 'openstackclient/identity/v3/domain.py')

diff --git a/openstackclient/identity/v3/domain.py b/openstackclient/identity/v3/domain.py
index 8278a300..cec967b8 100644
--- a/openstackclient/identity/v3/domain.py
+++ b/openstackclient/identity/v3/domain.py
@@ -15,24 +15,19 @@
 
 """Identity v3 Domain action implementations"""
 
-import logging
 import six
 import sys
 
-from cliff import command
-from cliff import lister
-from cliff import show
 from keystoneauth1 import exceptions as ks_exc
 
+from openstackclient.common import command
 from openstackclient.common import utils
 from openstackclient.i18n import _  # noqa
 
 
-class CreateDomain(show.ShowOne):
+class CreateDomain(command.ShowOne):
     """Create new domain"""
 
-    log = logging.getLogger(__name__ + '.CreateDomain')
-
     def get_parser(self, prog_name):
         parser = super(CreateDomain, self).get_parser(prog_name)
         parser.add_argument(
@@ -63,7 +58,6 @@ class CreateDomain(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -92,8 +86,6 @@ class CreateDomain(show.ShowOne):
 class DeleteDomain(command.Command):
     """Delete domain"""
 
-    log = logging.getLogger(__name__ + '.DeleteDomain')
-
     def get_parser(self, prog_name):
         parser = super(DeleteDomain, self).get_parser(prog_name)
         parser.add_argument(
@@ -103,7 +95,6 @@ class DeleteDomain(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         domain = utils.find_resource(identity_client.domains,
@@ -112,12 +103,9 @@ class DeleteDomain(command.Command):
         return
 
 
-class ListDomain(lister.Lister):
+class ListDomain(command.Lister):
     """List domains"""
 
-    log = logging.getLogger(__name__ + '.ListDomain')
-
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         columns = ('ID', 'Name', 'Enabled', 'Description')
         data = self.app.client_manager.identity.domains.list()
@@ -131,8 +119,6 @@ class ListDomain(lister.Lister):
 class SetDomain(command.Command):
     """Set domain properties"""
 
-    log = logging.getLogger(__name__ + '.SetDomain')
-
     def get_parser(self, prog_name):
         parser = super(SetDomain, self).get_parser(prog_name)
         parser.add_argument(
@@ -163,7 +149,6 @@ class SetDomain(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         domain = utils.find_resource(identity_client.domains,
@@ -186,11 +171,9 @@ class SetDomain(command.Command):
         return
 
 
-class ShowDomain(show.ShowOne):
+class ShowDomain(command.ShowOne):
     """Display domain details"""
 
-    log = logging.getLogger(__name__ + '.ShowDomain')
-
     def get_parser(self, prog_name):
         parser = super(ShowDomain, self).get_parser(prog_name)
         parser.add_argument(
@@ -200,7 +183,6 @@ class ShowDomain(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         domain = utils.find_resource(identity_client.domains,
-- 
cgit v1.2.1