delta/openstack/python-openstackclient.git/openstackclient/volume/v2/consistency_group_snapshot.py, branch 6.2.0 opendev.org: openstack/python-openstackclient Merge "Fix faulthy state argument choice" 2020-03-24T21:34:44+00:00 Zuul zuul@review.opendev.org 2020-03-24T21:34:44+00:00 81dcc91214c7b449e74ed5d0fe6854590431e6ef 






Replace six.iteritems() with .items()
2020-01-09T09:41:29+00:00

lihaijing
lihaijing@fiberhome.com

2017-07-07T03:48:48+00:00

d15bbada73f81136c966007d9c564dd6cfb2fd9c

1. As mentioned in [1], we should avoid using six.iteritems to achieve
   iterators. We can use dict.items instead, as it will return iterators
   in PY3 as well. And dict.items/keys will more readable.

2. In py2, the performance about list should be negligible,
   see the link [2].

[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85
Implements: blueprint replace-iteritems-with-items





1. As mentioned in [1], we should avoid using six.iteritems to achieve
   iterators. We can use dict.items instead, as it will return iterators
   in PY3 as well. And dict.items/keys will more readable.

2. In py2, the performance about list should be negligible,
   see the link [2].

[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85
Implements: blueprint replace-iteritems-with-items







Fix faulthy state argument choice
2019-12-19T08:48:17+00:00

Bram Verschueren
verschueren.bram@gmail.com

2019-12-13T10:13:54+00:00

69870ae439f18863979949f5728543a0fb1cbe83

The correct state name for a failing volume snapshot deletion is
'error_deleting' instead of 'error-deleting'. [1]

[1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126

Task: #37844
Story: #2007037

Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556





The correct state name for a failing volume snapshot deletion is
'error_deleting' instead of 'error-deleting'. [1]

[1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126

Task: #37844
Story: #2007037

Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556







Add commands for "consistency group snapshot"
2016-11-19T01:20:15+00:00

Huanxuan Ao
huanxuan.ao@easystack.cn

2016-11-16T12:55:21+00:00

3907137f5824e359bcdcfcdd8ab3d15a83d10bca

Add commands:
    consistency group snapshot create
    consistency group snapshot delete
    consistency group snapshot list
    consistency group snapshot show
in volume v2 (v2 only)

Change-Id: Ib4115f8ff00fb5aa8194588223032657eb1346b5
Closes-Bug: #1642238
Implements: bp cinder-command-support





Add commands:
    consistency group snapshot create
    consistency group snapshot delete
    consistency group snapshot list
    consistency group snapshot show
in volume v2 (v2 only)

Change-Id: Ib4115f8ff00fb5aa8194588223032657eb1346b5
Closes-Bug: #1642238
Implements: bp cinder-command-support