delta/openstack/python-openstackclient.git/openstackclient/volume/v1/volume_snapshot.py, branch 5.8.0 opendev.org: openstack/python-openstackclient Merge "Fix faulthy state argument choice" 2020-03-24T21:34:44+00:00 Zuul zuul@review.opendev.org 2020-03-24T21:34:44+00:00 81dcc91214c7b449e74ed5d0fe6854590431e6ef 






Replace six.iteritems() with .items()
2020-01-09T09:41:29+00:00

lihaijing
lihaijing@fiberhome.com

2017-07-07T03:48:48+00:00

d15bbada73f81136c966007d9c564dd6cfb2fd9c

1. As mentioned in [1], we should avoid using six.iteritems to achieve
   iterators. We can use dict.items instead, as it will return iterators
   in PY3 as well. And dict.items/keys will more readable.

2. In py2, the performance about list should be negligible,
   see the link [2].

[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85
Implements: blueprint replace-iteritems-with-items





1. As mentioned in [1], we should avoid using six.iteritems to achieve
   iterators. We can use dict.items instead, as it will return iterators
   in PY3 as well. And dict.items/keys will more readable.

2. In py2, the performance about list should be negligible,
   see the link [2].

[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85
Implements: blueprint replace-iteritems-with-items







Fix faulthy state argument choice
2019-12-19T08:48:17+00:00

Bram Verschueren
verschueren.bram@gmail.com

2019-12-13T10:13:54+00:00

69870ae439f18863979949f5728543a0fb1cbe83

The correct state name for a failing volume snapshot deletion is
'error_deleting' instead of 'error-deleting'. [1]

[1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126

Task: #37844
Story: #2007037

Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556





The correct state name for a failing volume snapshot deletion is
'error_deleting' instead of 'error-deleting'. [1]

[1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126

Task: #37844
Story: #2007037

Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556







Use cliff formattable columns in volume v1 commands
2019-06-22T19:53:28+00:00

Akihiro Motoki
amotoki@gmail.com

2017-05-15T07:55:41+00:00

1af3056e301807e4474cde49eef3e00931ab08c2

Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: Ib4c5798171e32a8ddc08a37ee1d416e366a71d76





Partial-Bug: #1687955
Partially implement blueprint osc-formattable-columns

Change-Id: Ib4c5798171e32a8ddc08a37ee1d416e366a71d76







Fix NoneType error for volume snapshot create command
2017-04-26T16:07:08+00:00

Huanxuan Ao
huanxuan.ao@easystack.cn

2017-03-08T02:01:16+00:00

1c49a1f01da73b8eed701809de88b408e738dfed

In volume snapshot command, <volume> is the same
as <snapshot-name> when --volume is not specified,
but <volume> cannot be None, so when <snapshot-name>
is not specified (<snapshot-name> is None), a NoneType
error appears.
So make <snapshot-name> no longer optional, it should
be always present.

Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f
Closes-bug: #1659894





In volume snapshot command, <volume> is the same
as <snapshot-name> when --volume is not specified,
but <volume> cannot be None, so when <snapshot-name>
is not specified (<snapshot-name> is None), a NoneType
error appears.
So make <snapshot-name> no longer optional, it should
be always present.

Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f
Closes-bug: #1659894







Support "--no-property" option in volume snapshot set
2017-01-25T23:32:58+00:00

zhiyong.dai
zhiyong.dai@easystack.cn

2017-01-02T09:55:32+00:00

26d50be79a401322f4e74b94c066257ddf0f287c

Supporting "--no-property" option will apply user a convenient
way to clean all properties of volume snapshot in a short command,
and this kind of behavior is the recommended way to devref.
The patch adds "--no-property" option in "volume snapshot set" command,
and update related test cases and devref document.

Change-Id: I5f10cc2b5814553699920c4343995b2e11416e4e
Implements: blueprint allow-overwrite-set-options





Supporting "--no-property" option will apply user a convenient
way to clean all properties of volume snapshot in a short command,
and this kind of behavior is the recommended way to devref.
The patch adds "--no-property" option in "volume snapshot set" command,
and update related test cases and devref document.

Change-Id: I5f10cc2b5814553699920c4343995b2e11416e4e
Implements: blueprint allow-overwrite-set-options







Update the description format
2017-01-03T13:31:54+00:00

zhiyong.dai
zhiyong.dai@easystack.cn

2017-01-03T10:45:49+00:00

be9e60be4b34ed65206cc0fc69e1b43e3217c2f7

In network_qos_rule_type.py, network_service_provider.py, server.py and
volume_snapshot.py, the description format is using """ """.
In this patch, the former format is replaced with "_description = _( )".

Change-Id: I6863b01d3534e033df745070037ee45286745c92





In network_qos_rule_type.py, network_service_provider.py, server.py and
volume_snapshot.py, the description format is using """ """.
In this patch, the former format is replaced with "_description = _( )".

Change-Id: I6863b01d3534e033df745070037ee45286745c92







Add options to "volume snapshot list" command
2016-11-26T15:13:50+00:00

jiahui.qiang
jiahui.qiang@easystack.cn

2016-11-22T09:27:34+00:00

6ca4dc3533d009866f82515c34cb3881f993c750

Add "--name", "--status" and "--volume" options
to "volume snapshot list" command for filtering results.

Change-Id: I72db1abce7701f31598deec34801a4d1f5713870
Closes-Bug:#1645252





Add "--name", "--status" and "--volume" options
to "volume snapshot list" command for filtering results.

Change-Id: I72db1abce7701f31598deec34801a4d1f5713870
Closes-Bug:#1645252







Refactor "snapshot" commands
2016-11-03T08:15:02+00:00

Huanxuan Ao
huanxuan.ao@easystack.cn

2016-09-14T06:54:29+00:00

23ee2fd8f060ed312a84eb03c99494e8af2ffb6f

1.change the command name ``snapshot create/delete/list/
show/set/unset`` to ``volume snapshot create/delete/list/
show/set/unset``.

2.change the optional parameter "--name <name>" to a
positional parameter "<snapshot-name>"; Change the
positional parameter "<volume>" to a optional
parameter "--volume <volume>"

Change-Id: If03276ecdf6f0d96893d5ecf91c2aaa64929cff3
Implements: bp backup-snapshot-renamed-for-volume-resource
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>





1.change the command name ``snapshot create/delete/list/
show/set/unset`` to ``volume snapshot create/delete/list/
show/set/unset``.

2.change the optional parameter "--name <name>" to a
positional parameter "<snapshot-name>"; Change the
positional parameter "<volume>" to a optional
parameter "--volume <volume>"

Change-Id: If03276ecdf6f0d96893d5ecf91c2aaa64929cff3
Implements: bp backup-snapshot-renamed-for-volume-resource
Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>