<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-openstackclient.git/openstackclient/tests/volume/v1, branch 3.0.0</title>
<subtitle>opendev.org: openstack/python-openstackclient
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/'/>
<entry>
<title>Use identity fake classes instead of old unit tests data</title>
<updated>2016-07-26T10:38:12+00:00</updated>
<author>
<name>Huanxuan Ao</name>
<email>huanxuan.ao@easystack.cn</email>
</author>
<published>2016-07-15T11:02:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=1b2ea91420e297d51e66b985b8fb04c45059bd85'/>
<id>1b2ea91420e297d51e66b985b8fb04c45059bd85</id>
<content type='text'>
Use FakeProject, FakeDomain and FakeUser classes instead
of old test data in image, compute and volume. (This work
has done in network)

Change-Id: Ic37d5d9db98f0f2acc6c714a9646063dcbde4ff3
Partially-Implements: blueprint use-fake-project
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use FakeProject, FakeDomain and FakeUser classes instead
of old test data in image, compute and volume. (This work
has done in network)

Change-Id: Ic37d5d9db98f0f2acc6c714a9646063dcbde4ff3
Partially-Implements: blueprint use-fake-project
</pre>
</div>
</content>
</entry>
<entry>
<title>fix a few spelling mistakes</title>
<updated>2016-07-04T15:15:23+00:00</updated>
<author>
<name>gecong1973</name>
<email>ge.cong@zte.com.cn</email>
</author>
<published>2016-07-04T08:36:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=6115dfe9f85e0972a01d6d50a91a19096540505e'/>
<id>6115dfe9f85e0972a01d6d50a91a19096540505e</id>
<content type='text'>
 - overwriten should be overwritten
 - retrun should be return

Change-Id: I1567402f4d5c7253e6a54d8753e3f201af7e6a54
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 - overwriten should be overwritten
 - retrun should be return

Change-Id: I1567402f4d5c7253e6a54d8753e3f201af7e6a54
</pre>
</div>
</content>
</entry>
<entry>
<title>Add "--force" option to "volume qos delete" command</title>
<updated>2016-06-28T08:12:40+00:00</updated>
<author>
<name>Huanxuan Ao</name>
<email>huanxuan.ao@easystack.cn</email>
</author>
<published>2016-06-28T07:54:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=4e46c04f921c81927ded78f17fd28d5a55ebf9e2'/>
<id>4e46c04f921c81927ded78f17fd28d5a55ebf9e2</id>
<content type='text'>
Add ``--force`` option to ``volume qos delete`` command in volume
v1 and v2 to allow users to delete in-use QoS specification(s).

Change-Id: I46036e5f55ced8b8a1be54c521f2a5c242b89160
Closes-Bug: #1596821
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add ``--force`` option to ``volume qos delete`` command in volume
v1 and v2 to allow users to delete in-use QoS specification(s).

Change-Id: I46036e5f55ced8b8a1be54c521f2a5c242b89160
Closes-Bug: #1596821
</pre>
</div>
</content>
</entry>
<entry>
<title>Standardize logger usage in volume</title>
<updated>2016-06-14T21:37:57+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-06-07T06:29:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=0e9862be7af9a88c9c0e6a9ef4e11e48a1192727'/>
<id>0e9862be7af9a88c9c0e6a9ef4e11e48a1192727</id>
<content type='text'>
self.app.log is the logger in class OpenStackShell,
which should be used to record logs that have nothing
to do with any specific command.

So, use the file logger instead.

This patch also fixes some usage that doesn't follow
rules in:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html
1. add variables to logger as an argument
2. do not wrap variables with str()

Change-Id: I248861a38a4de0412a080046aa7a6f6473c3e082
Implements: blueprint log-usage
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
self.app.log is the logger in class OpenStackShell,
which should be used to record logs that have nothing
to do with any specific command.

So, use the file logger instead.

This patch also fixes some usage that doesn't follow
rules in:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html
1. add variables to logger as an argument
2. do not wrap variables with str()

Change-Id: I248861a38a4de0412a080046aa7a6f6473c3e082
Implements: blueprint log-usage
</pre>
</div>
</content>
</entry>
<entry>
<title>osc-lib: utils</title>
<updated>2016-06-13T15:50:44+00:00</updated>
<author>
<name>Dean Troyer</name>
<email>dtroyer@gmail.com</email>
</author>
<published>2016-05-13T21:14:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=e5e29a8fef7ba2396015918545a49e717fe75d15'/>
<id>e5e29a8fef7ba2396015918545a49e717fe75d15</id>
<content type='text'>
Use osc-lib directly for utils.

Leave openstackclient.common.utils for deprecation period.

Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use osc-lib directly for utils.

Leave openstackclient.common.utils for deprecation period.

Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Make set/unset commands in volume return normally when nothing specified"</title>
<updated>2016-06-06T21:48:12+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-06-06T21:48:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=376e3379ee358a15987234e4d1917835f7098658'/>
<id>376e3379ee358a15987234e4d1917835f7098658</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for volume transfer request list</title>
<updated>2016-06-04T18:26:59+00:00</updated>
<author>
<name>Sheel Rana</name>
<email>ranasheel2000@gmail.com</email>
</author>
<published>2016-05-01T15:44:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=2178cedef1fbd1fbf2adda2ca40161414dc75c1b'/>
<id>2178cedef1fbd1fbf2adda2ca40161414dc75c1b</id>
<content type='text'>
OSC does not support to list volume transfer from one user
to other user.
This patch will provide support for listning volume transfer
requests.

Closes-Bug:#1554886

Implements: bp cinder-command-support

Change-Id: Ie659bc39cb1d1e931cca7a40b2f126a067ee484c
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
OSC does not support to list volume transfer from one user
to other user.
This patch will provide support for listning volume transfer
requests.

Closes-Bug:#1554886

Implements: bp cinder-command-support

Change-Id: Ie659bc39cb1d1e931cca7a40b2f126a067ee484c
</pre>
</div>
</content>
</entry>
<entry>
<title>Make set/unset commands in volume return normally when nothing specified</title>
<updated>2016-06-04T13:29:44+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-06-04T13:29:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=2672e37ee211bf08a4b6078668bd36a08c9c606a'/>
<id>2672e37ee211bf08a4b6078668bd36a08c9c606a</id>
<content type='text'>
set/unset commands should ends up normally instead of
logging an error when nothing is specified to modify.
The main reason is: When nothing is specified, the
command sets/unsets nothing, which is a normal behavior,
and ends up normally. No API call fails. No error happens.

Change-Id: Ib03a512650e5da90aa1ef38019772448383d0d33
Partial-bug: #1588588
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
set/unset commands should ends up normally instead of
logging an error when nothing is specified to modify.
The main reason is: When nothing is specified, the
command sets/unsets nothing, which is a normal behavior,
and ends up normally. No API call fails. No error happens.

Change-Id: Ib03a512650e5da90aa1ef38019772448383d0d33
Partial-bug: #1588588
</pre>
</div>
</content>
</entry>
<entry>
<title>Support for volume service list</title>
<updated>2016-04-25T17:42:12+00:00</updated>
<author>
<name>Sheel Rana</name>
<email>ranasheel2000@gmail.com</email>
</author>
<published>2016-03-30T11:35:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=4072554608abd4828f281dcc0e20ce99ed6611b9'/>
<id>4072554608abd4828f281dcc0e20ce99ed6611b9</id>
<content type='text'>
OSC does not support to list volume services.
This patch will provide support for adding volume service related
support.

Closes-bug:#1550999

Implements: bp cinder-command-support

Change-Id: I50ac14aeb96c4b8ddbf7b33e519feea0d126f752
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
OSC does not support to list volume services.
This patch will provide support for adding volume service related
support.

Closes-bug:#1550999

Implements: bp cinder-command-support

Change-Id: I50ac14aeb96c4b8ddbf7b33e519feea0d126f752
</pre>
</div>
</content>
</entry>
<entry>
<title>Test take_action() instead of run() in unit tests</title>
<updated>2016-03-05T09:12:42+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-03-05T09:12:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=eb1574281b84e86ee4c4b65d900e1de82c24471e'/>
<id>eb1574281b84e86ee4c4b65d900e1de82c24471e</id>
<content type='text'>
Some of the unit tests test run(), but not take_action().

For example, in openstackclient/tests/volume/v1/test_volume.py, there is:

    def test_volume_set_size_smaller(self):
        ......

        result = self.cmd.run(parsed_args)

        self.assertEqual(0, result)
        ......

run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.

Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some of the unit tests test run(), but not take_action().

For example, in openstackclient/tests/volume/v1/test_volume.py, there is:

    def test_volume_set_size_smaller(self):
        ......

        result = self.cmd.run(parsed_args)

        self.assertEqual(0, result)
        ......

run() is defined in class Command in cliff. We don't need to test it in OSC
unit tests. On the contrary, we should test take_action(), which is
overwritten in each command classes in OSC.

Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b
Closes-bug: #1553468
</pre>
</div>
</content>
</entry>
</feed>
