delta/openstack/python-openstackclient.git/openstackclient/tests/unit/identity/v3/test_group.py, branch 3.16.2 opendev.org: openstack/python-openstackclient Support to add/remove multi users for "group add/remove user" 2017-03-21T02:39:42+00:00 Huanxuan Ao huanxuan.ao@easystack.cn 2017-03-17T05:28:49+00:00 ef5a7caf85bd6169701371da67029457abdaf47f Similar delete commands in OSC, we can also support add/remove multi users for one specified group, this review implement it. Change-Id: I8ccf99d4ee83a18778fa3ff5c0a42bc7c6ff21fb Implements: bp support-multi-add-remove 
Similar delete commands in OSC, we can also support add/remove
multi users for one specified group, this review implement it.

Change-Id: I8ccf99d4ee83a18778fa3ff5c0a42bc7c6ff21fb
Implements: bp support-multi-add-remove
Narrow expected responses for CheckUserInGroup 2017-03-14T08:23:19+00:00 Colleen Murphy comurphy@suse.com 2017-03-14T00:24:31+00:00 853ea5ab59e5d7845d389e46527038575c3c170c When checking whether a given user is in a given group, keystone will return a 404 Not Found if all went well but the user was not in the group. It may also return a 403 if the user and the group are in different backends, which would also mean that the user was not in the group[1]. Any other 400 response is a client error and any 500 response is a server error to which the user should be alerted. Without this patch, openstackclient treats any exception as a valid "not found" and may end up hiding server errors. This patch reduces the caught exceptions to 403 and 404 responses and treats everything else as an error. [1] https://developer.openstack.org/api-ref/identity/v3/?expanded=check-whether-user-belongs-to-group-detail#check-whether-user-belongs-to-group Closes-bug: #1672634 Change-Id: Id3f3b2409b7cee480ee3c19b6d6c3070599ffe8f 
When checking whether a given user is in a given group, keystone will
return a 404 Not Found if all went well but the user was not in the
group. It may also return a 403 if the user and the group are in
different backends, which would also mean that the user was not in the
group[1]. Any other 400 response is a client error and any 500 response
is a server error to which the user should be alerted.

Without this patch, openstackclient treats any exception as a valid "not
found" and may end up hiding server errors. This patch reduces the
caught exceptions to 403 and 404 responses and treats everything else as
an error.

[1] https://developer.openstack.org/api-ref/identity/v3/?expanded=check-whether-user-belongs-to-group-detail#check-whether-user-belongs-to-group

Closes-bug: #1672634

Change-Id: Id3f3b2409b7cee480ee3c19b6d6c3070599ffe8f
Modify error handling for role and group commands 2017-02-09T11:49:55+00:00 Huanxuan Ao huanxuan.ao@easystack.cn 2017-02-09T10:05:32+00:00 cfd4e2a7228c1e7f6ad677f2dd6dbd09e638dfb7 if command failed, we usually raise exception, if command success, sometimes there is not any output (such as set, add commands) So modify the error handling for role and group commands. Change-Id: I1c0f86c04dcedd9c0d725fd73f3436be9da75ee0 
if command failed, we usually raise exception,
if command success, sometimes there is not any
output (such as set, add commands)
So modify the error handling for role and group
commands.

Change-Id: I1c0f86c04dcedd9c0d725fd73f3436be9da75ee0
Error handling for delete commands in identity 2017-01-03T15:30:49+00:00 Huanxuan Ao huanxuan.ao@easystack.cn 2016-12-30T05:22:07+00:00 96578cb8ab9a4b95144c33d0af38863fce8d8892 Add missing multi deletion error handling for identity delete commands. All delete commands in identity support error handling now. Change-Id: I05626dcb5e516a423d610906347b02236ba7eeaf 
Add missing multi deletion error handling for
identity delete commands.
All delete commands in identity support
error handling now.

Change-Id: I05626dcb5e516a423d610906347b02236ba7eeaf
Replace 'MagicMock' with 'Mock' 2016-09-14T09:59:31+00:00 qtang qtang@vmware.com 2016-09-14T05:27:31+00:00 bc222e97b155152be3c8cced987ef1d443076d10 Change-Id: I7aeceede6bd3cb88cf04f398454f9758dbee20f1 Closes-Bug: #1475722 
Change-Id: I7aeceede6bd3cb88cf04f398454f9758dbee20f1
Closes-Bug: #1475722
move unit tests to new "unit" test module 2016-09-08T22:19:50+00:00 Steve Martinelli s.martinelli@gmail.com 2016-09-06T05:14:33+00:00 39839def2e356e8d145be89380c73a71423cf06d this will better isolate the unit tests from the functional tests. unfortunately, the "integration" tests had to be lumped into the "unit" tests since we need the separation in testr.conf Change-Id: Ifd12198c1f90e4e3c951c73bfa1884ab300d8ded 
this will better isolate the unit tests from the functional tests.
unfortunately, the "integration" tests had to be lumped into the
"unit" tests since we need the separation in testr.conf

Change-Id: Ifd12198c1f90e4e3c951c73bfa1884ab300d8ded