<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-openstackclient.git/openstackclient/tests/identity/v3/test_token.py, branch 2.5.0</title>
<subtitle>opendev.org: openstack/python-openstackclient
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/'/>
<entry>
<title>[Identity] Check return value is None in identity v3 unit tests</title>
<updated>2016-03-08T07:58:25+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-03-05T08:29:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=762c4c9bdf66995198fa03751b861a859b9d44a1'/>
<id>762c4c9bdf66995198fa03751b861a859b9d44a1</id>
<content type='text'>
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec
Partial-Bug: #1550636
</pre>
</div>
</content>
</entry>
<entry>
<title>Support unscoped token request</title>
<updated>2016-02-20T00:07:13+00:00</updated>
<author>
<name>guang-yee</name>
<email>guang.yee@hpe.com</email>
</author>
<published>2016-02-08T19:16:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=41e1bd0be64e15a5e0c12b45bdf3dcde5fabf244'/>
<id>41e1bd0be64e15a5e0c12b45bdf3dcde5fabf244</id>
<content type='text'>
Make scope check optional for the "token issue" command as unscoped token is
a valid Keystone V2/V3 API.

Change-Id: Ie1cded4dbfdafd3a78c0ebdf89e3f66762509930
Closes-Bug: #1543214
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make scope check optional for the "token issue" command as unscoped token is
a valid Keystone V2/V3 API.

Change-Id: Ie1cded4dbfdafd3a78c0ebdf89e3f66762509930
Closes-Bug: #1543214
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Add "token revoke" for identity v3"</title>
<updated>2016-02-17T20:31:07+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-02-17T20:31:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=f15a75428de6c75bcff27dc4447962f8eee61bed'/>
<id>f15a75428de6c75bcff27dc4447962f8eee61bed</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Identity: Fix DisplayCommandBase comments for cliff ShowOne subclass tests</title>
<updated>2016-02-10T15:11:58+00:00</updated>
<author>
<name>Tang Chen</name>
<email>chen.tang@easystack.cn</email>
</author>
<published>2016-02-10T15:11:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=9f71b777ac7357c96ac7fa662ba18fa67b93baa0'/>
<id>9f71b777ac7357c96ac7fa662ba18fa67b93baa0</id>
<content type='text'>
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--&gt; Command
     |--&gt; DisplayCommandBase
          |--&gt; Lister
          |--&gt; ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 3 in all identity tests.

Change-Id: I1f05e833cdacd30915954e4220b6e1f16ac1ed40
Closes-bug: #1477199
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--&gt; Command
     |--&gt; DisplayCommandBase
          |--&gt; Lister
          |--&gt; ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.
* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of columns
  and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple of
  columns and a tuple of data.

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes inheriting
   from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class Lister in cliff. Lister.take_action() returns a tuple and
   a generator.
3. Fix all DisplayCommandBase comments for tests of classes inheriting
   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.

This patch finishes step 3 in all identity tests.

Change-Id: I1f05e833cdacd30915954e4220b6e1f16ac1ed40
Closes-bug: #1477199
</pre>
</div>
</content>
</entry>
<entry>
<title>Add "token revoke" for identity v3</title>
<updated>2016-02-10T00:49:11+00:00</updated>
<author>
<name>lin-hua-cheng</name>
<email>os.lcheng@gmail.com</email>
</author>
<published>2016-02-10T00:49:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=686a26973809eaba3deb9aed63daddba3bb0521e'/>
<id>686a26973809eaba3deb9aed63daddba3bb0521e</id>
<content type='text'>
Change-Id: Ie631600d02942fe6ce035f31af46abe44e543631
Closes-bug: #1543226
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: Ie631600d02942fe6ce035f31af46abe44e543631
Closes-bug: #1543226
</pre>
</div>
</content>
</entry>
<entry>
<title>fix the wrong order of assertEqual args</title>
<updated>2015-01-27T09:02:41+00:00</updated>
<author>
<name>wanghong</name>
<email>w.wanghong@huawei.com</email>
</author>
<published>2015-01-27T09:02:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=127af151ff60d11e7b2f88555678cf18b8828e48'/>
<id>127af151ff60d11e7b2f88555678cf18b8828e48</id>
<content type='text'>
Let's fix them thoroughly.

Change-Id: I8a1f042fb614b05c9836a49041f3883638b870b0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Let's fix them thoroughly.

Change-Id: I8a1f042fb614b05c9836a49041f3883638b870b0
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix token issue after auth changeup</title>
<updated>2014-10-20T18:21:51+00:00</updated>
<author>
<name>Dean Troyer</name>
<email>dtroyer@gmail.com</email>
</author>
<published>2014-10-20T17:47:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=cd368bb81690af5b4e99c0fd71b35fb00c9e0786'/>
<id>cd368bb81690af5b4e99c0fd71b35fb00c9e0786</id>
<content type='text'>
IssueToken.take_action() was missed in updating the structure of
the ClientManager.

Also, TOKEN_WITH_TENANT_ID in v3 is just wrong...

Closes-Bug: #1383396

Change-Id: If2dd82a26af1d743ee9df73e0c1aebce497bf22e
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
IssueToken.take_action() was missed in updating the structure of
the ClientManager.

Also, TOKEN_WITH_TENANT_ID in v3 is just wrong...

Closes-Bug: #1383396

Change-Id: If2dd82a26af1d743ee9df73e0c1aebce497bf22e
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix issue token for v3</title>
<updated>2014-10-12T00:34:09+00:00</updated>
<author>
<name>Steve Martinelli</name>
<email>stevemar@ca.ibm.com</email>
</author>
<published>2014-10-10T18:17:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=1b3c7ec122504a41dc35aaf3f0693c9e20015df8'/>
<id>1b3c7ec122504a41dc35aaf3f0693c9e20015df8</id>
<content type='text'>
Currently the code is broken as it references a part of
keystoneclient that does not exist.

Change-Id: I7fbc754537fbb4acffb166b5854840acfaef1fb8
Closes-Bug: #1379871
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently the code is broken as it references a part of
keystoneclient that does not exist.

Change-Id: I7fbc754537fbb4acffb166b5854840acfaef1fb8
Closes-Bug: #1379871
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename token classes to match command</title>
<updated>2014-06-27T14:14:58+00:00</updated>
<author>
<name>Dean Troyer</name>
<email>dtroyer@gmail.com</email>
</author>
<published>2014-06-26T23:20:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=1fca946890be22f51463975c1bf6449b8680c23a'/>
<id>1fca946890be22f51463975c1bf6449b8680c23a</id>
<content type='text'>
The token create/delete commands were renamed but not the class names.
Rename them to match.

Change-Id: Icbf9c0a954ed0332fa4c99e4ee2612bb11f89e3a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The token create/delete commands were renamed but not the class names.
Rename them to match.

Change-Id: Icbf9c0a954ed0332fa4c99e4ee2612bb11f89e3a
</pre>
</div>
</content>
</entry>
<entry>
<title>Add token create subcommand for identity v3 api</title>
<updated>2014-01-29T07:59:12+00:00</updated>
<author>
<name>Qiu Yu</name>
<email>qiuyu@ebaysf.com</email>
</author>
<published>2014-01-29T07:57:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-openstackclient.git/commit/?id=a8d828f330119502fc18107c264f2944548a7fb9'/>
<id>a8d828f330119502fc18107c264f2944548a7fb9</id>
<content type='text'>
Implements token create subcommand which is an equivalent of keystone
token-get command. Original "wrap" parameter for keystone token-get is
not implemented yet due to cliff Bug #1269299

This is a part of: blueprint add-identity-token-support

Change-Id: I2255021c9d1f10f757686583b1ebe40b5f3a9ecb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implements token create subcommand which is an equivalent of keystone
token-get command. Original "wrap" parameter for keystone token-get is
not implemented yet due to cliff Bug #1269299

This is a part of: blueprint add-identity-token-support

Change-Id: I2255021c9d1f10f757686583b1ebe40b5f3a9ecb
</pre>
</div>
</content>
</entry>
</feed>
