delta/openstack/python-openstackclient.git/openstackclient/tests/compute/v2/test_flavor.py, branch 2.3.0

Merge "Make SetFlavor and UnsetFlavor inherit from cliff.Command"

2016-02-29T18:37:44+00:00

[Compute] Check return value is None in compute unit tests.

2016-02-27T07:38:04+00:00

take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of
these commands.

Change-Id: I953480ecff3b5beb12255d866d0e1df45f130efd
Partial-Bug: #1550636

Make SetFlavor and UnsetFlavor inherit from cliff.Command

2016-02-26T19:46:30+00:00

set/unset comamnd classes should inherit from cliff.Command class.

Change-Id: I54e5608ac0768d7d94b7f7d516ea1948daefdc1b
Partial-Bug: 1546065

Add unit test for "flavor show" command

2016-02-20T09:16:01+00:00

Change-Id: I1591649e5b97a885707042fcccad3335ee8c7aec

Trivial: Fix "abstractmethod" to "abstract method"

2016-02-10T11:01:52+00:00

As Richard  has pointed out, "abstractmethod"
should be "abstract method". This is a small typo I have made
when I fix DisplayCommandBase comment bug.

Change-Id: I84f1a3158896257686a0a7efa1123eef1b85139f
Partial-bug: #1477199

Compute: Fix DisplayCommandBase comments for cliff Lister subclass tests

2016-02-06T02:30:34+00:00

As bug #1477199 describes, the wrong comment below is all over the
unit test code of OSC.

    # DisplayCommandBase.take_action() returns two tuples

There is no such class named DisplayCommandBase in OSC. It is in cliff.

All OSC command classes inherit from the base classes in cliff,
class Command, class Lister and class ShowOne. It is like this:

Object
|--> Command
     |--> DisplayCommandBase
         |--> Lister
         |--> ShowOne

take_action() is an abstract method of class Command, and generally is
overwritten by subclasses.

* Command.take_action() returns nothing.
* Lister.take_action() returns a tuple which contains a tuple of
  columns and a generator used to generate the data.
* ShowOne.take_action() returns an iterator which contains a tuple
  of columns and a tuple of data

So, this problem should be fixed in 3 steps:
1. Remove all DisplayCommandBase comments for tests of classes
   inheriting from class Command in cliff as it returns nothing.
2. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class Lister in cliff. Lister.take_action()
   returns a tuple and a generator.
3. Fix all DisplayCommandBase comments for tests of classes
   inheriting from class ShowOne in cliff. ShowOne.take_action()
   returns two tuples.

This patch finishes step 2 in compute tests.

Change-Id: Idc54ad21eaa1371ebd601327b8d962c7039f2de0
Partial-bug: #1477199

Trivial: Coding style fix in test_flavor.py

2015-12-08T05:35:51+00:00

Change-Id: I3dcb3c4fbd9ff9c351426ae2ad9da009208a6485

Add unit testcases for "openstack flavor delete"

2015-11-30T05:48:32+00:00

Change-Id: If23a71c678193e5c9c91300fddd17e79f674bf82

Use FakeFlavor in TestFlavorUnset.

2015-11-28T08:14:18+00:00

Change-Id: Ifbd360db39d380efd9632300367b13283ac75f54
Implements: blueprint improve-flavor-unit-test

Use FakeFlavor in TestFlavorSet.

2015-11-28T08:14:12+00:00

Change-Id: I335298b07afb3f969c76748527dda06cb5393fa8
Implements: blueprint improve-flavor-unit-test