From a71611f9165bf168706707f06708acbdfa0ba250 Mon Sep 17 00:00:00 2001 From: Stanislav Kudriashev Date: Thu, 21 Aug 2014 16:04:21 +0300 Subject: Small improve of str2dict function Change-Id: Ifa8974f2cbdac4fdc0cbd47d7ad9910a5bd31cb7 --- neutronclient/common/utils.py | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/neutronclient/common/utils.py b/neutronclient/common/utils.py index b26166d..87dec4c 100644 --- a/neutronclient/common/utils.py +++ b/neutronclient/common/utils.py @@ -138,22 +138,17 @@ def get_item_properties(item, fields, mixed_case_fields=[], formatters={}): def str2bool(strbool): if strbool is None: return None - else: - return strbool.lower() == 'true' + return strbool.lower() == 'true' def str2dict(strdict): - '''Convert key1=value1,key2=value2,... string into dictionary. - - :param strdict: key1=value1,key2=value2 - ''' - _info = {} - if not strdict: - return _info - for kv_str in strdict.split(","): - k, v = kv_str.split("=", 1) - _info.update({k: v}) - return _info + """Convert key1=value1,key2=value2,... string into dictionary. + + :param strdict: key1=value1,key2=value2 + """ + if not strdict: + return {} + return dict([kv.split('=', 1) for kv in strdict.split(',')]) def http_log_req(_logger, args, kwargs): -- cgit v1.2.1