delta/openstack/python-keystoneclient.git/keystoneclient/tests/unit/test_session.py, branch mitaka-eol opendev.org: openstack/python-keystoneclient.git Only log application/json content type 2017-01-11T05:10:06+00:00 Tobias Diaz tobias.deb@gmail.com 2016-08-23T15:13:24+00:00 a0c67b860b3c5ff6f5fbb0e406dcbc3fd7aa9f88 This is a combination of 2 commits. The first commit's message is: Prevent MemoryError when logging response bodies Response bodies are loaded into memory prior to being logged. Loading huge response bodies may result in a MemoryError. This patch proposes that only JSON and TEXT responses be logged, i.e when the Content-Type header is application/json or application/text. Responses that do not include or have a different Content-Type header will have their body omitted. This is a sort of backport of the fix for keystoneauth sessions, see I93b6fff73368c4f58bdebf8566c4948b50980cee Co-Authored-By: Samuel de Medeiros Queiroz <samueldmq@gmail.com> Closes-bug: 1616105 Change-Id: I8f43eee3a0b35041c6cf672e476f8151cf2f8d14 (cherry-picked from: 3e56e0d7e5e1a76d806a3bc1f6d5ef9070f95771) Only log application/json in session to start When whitelisting content types to debug print from session we chose application/json and application/text. application/text is not a real mime type, text is typically text/plain. Rather than guess at mime types only print application/json to start with, but make it easy for additional types to be added later. Adapted from keystoneauth: Ica5fee076cdab8b1d5167161d28af7313fad9477 Related-Bug: 1616105 Change-Id: Ieaa8fb3ea8d25e09b89498f23b70b18c0f6153f1 (cherry-picked from: 51d16fa344829aadf454faf5e0c4535a8f96a7c8) 
This is a combination of 2 commits. The first commit's
message is:

Prevent MemoryError when logging response bodies

Response bodies are loaded into memory prior to
being logged.

Loading huge response bodies may result in a
MemoryError.

This patch proposes that only JSON and TEXT
responses be logged, i.e when the Content-Type
header is application/json or application/text.

Responses that do not include or have a different
Content-Type header will have their body omitted.

This is a sort of backport of the fix for
keystoneauth sessions, see
I93b6fff73368c4f58bdebf8566c4948b50980cee

Co-Authored-By: Samuel de Medeiros Queiroz <samueldmq@gmail.com>

Closes-bug: 1616105

Change-Id: I8f43eee3a0b35041c6cf672e476f8151cf2f8d14
(cherry-picked from: 3e56e0d7e5e1a76d806a3bc1f6d5ef9070f95771)

Only log application/json in session to start

When whitelisting content types to debug print from session we chose
application/json and application/text. application/text is not a real
mime type, text is typically text/plain.

Rather than guess at mime types only print application/json to start
with, but make it easy for additional types to be added later.

Adapted from keystoneauth: Ica5fee076cdab8b1d5167161d28af7313fad9477
Related-Bug: 1616105

Change-Id: Ieaa8fb3ea8d25e09b89498f23b70b18c0f6153f1
(cherry-picked from: 51d16fa344829aadf454faf5e0c4535a8f96a7c8)
Merge "Do not log binary data during request" into stable/mitaka 2017-01-10T00:33:45+00:00 Jenkins jenkins@review.openstack.org 2017-01-10T00:33:45+00:00 a71593b19e52bb4469432d682bacecfb80843d73 






Do not log binary data during request
2017-01-09T20:06:44+00:00

Steve Martinelli
s.martinelli@gmail.com

2017-01-03T14:55:09+00:00

e5bc019840c2dd08a4e48fd26a23bff8d1ab644c

Do not log binary data during debug logging of a session.
Replace the binary data with the string <binary_data> instead.

sort of a backport of: I5184002f3a21c5e0ee510b21b9a7884c8dccd1e3

Change-Id: I07ddbc3967f297597542f1975004d94c490f6e6b
Related-Bug: 1616105
(cherry picked from commit af770f17b705a66bd4292b2a54df46ec5fdaa12b)





Do not log binary data during debug logging of a session.
Replace the binary data with the string <binary_data> instead.

sort of a backport of: I5184002f3a21c5e0ee510b21b9a7884c8dccd1e3

Change-Id: I07ddbc3967f297597542f1975004d94c490f6e6b
Related-Bug: 1616105
(cherry picked from commit af770f17b705a66bd4292b2a54df46ec5fdaa12b)







X-Serivce-Token should be hashed in the log
2017-01-09T19:53:53+00:00

Tin Lam
tinlam@gmail.com

2017-01-09T16:31:35+00:00

398c8fb5160a05d4b28fb11147a9a295e11bcf31

Currently, logs display the hash values of X-Auth-Token,
Authorization, and X-Subject-Token, but not the value of
the X-Service-Token.  This patch set adds the X-Service-Token
to the list of header fields to be hashed for logging purposes.

Change-Id: Iaa3a27f4b6c3baf964fa0c71328ffe9df43b2c0a
Closes-Bug: #1654847
(cherry picked from commit 56af8c90ecbb3cb5d29036151108b1e4e7a69bcc)





Currently, logs display the hash values of X-Auth-Token,
Authorization, and X-Subject-Token, but not the value of
the X-Service-Token.  This patch set adds the X-Service-Token
to the list of header fields to be hashed for logging purposes.

Change-Id: Iaa3a27f4b6c3baf964fa0c71328ffe9df43b2c0a
Closes-Bug: #1654847
(cherry picked from commit 56af8c90ecbb3cb5d29036151108b1e4e7a69bcc)







Merge "Handle exception on UnicodeDecodError in logging of request"
2016-02-12T04:37:43+00:00

Jenkins
jenkins@review.openstack.org

2016-02-12T04:37:43+00:00

9fa98872cc7b4390bdefb5ae1ced0ef7c383061c












Handle exception on UnicodeDecodError in logging of request
2016-02-10T19:04:47+00:00

Trevor McKay
tmckay@redhat.com

2016-02-09T18:40:39+00:00

96fbfeab973cf61cd5ba129056cf4e6634d805b8

If the logging of an HTTP request causes a UnicodeDecodeError,
modify the log entry using oslo_utils.encodeutils.safe_decode
with errors='replace' and try again

Co-Authored-By: Nikita Konovalov <nkonovalov@mirantis.com>

Change-Id: Ic365c654ebca4045208c6c30e232665145db7b4c
Closes-Bug: #1453953





If the logging of an HTTP request causes a UnicodeDecodeError,
modify the log entry using oslo_utils.encodeutils.safe_decode
with errors='replace' and try again

Co-Authored-By: Nikita Konovalov <nkonovalov@mirantis.com>

Change-Id: Ic365c654ebca4045208c6c30e232665145db7b4c
Closes-Bug: #1453953







Deprecate Session
2016-02-03T01:06:07+00:00

Jamie Lennox
jamielennox@gmail.com

2015-12-16T06:41:18+00:00

c1c2043da966ad8fb61f93739b11da609ee52d43

Deprecate the keystoneclient Session object in favour of keystoneauth's
Session.

Change-Id: I26e000d626a466f63d10d2a961adc698f8de0636
Implements: bp deprecate-to-ksa





Deprecate the keystoneclient Session object in favour of keystoneauth's
Session.

Change-Id: I26e000d626a466f63d10d2a961adc698f8de0636
Implements: bp deprecate-to-ksa







Replace TestResponse with requests_mock
2016-01-24T22:56:34+00:00

Jamie Lennox
jamielennox@gmail.com

2015-12-17T00:41:36+00:00

59ba76535cb3c2f945a9440ae6efc50470cc08e1

The TestResponse object doesn't do the right thing with regards to
content vs text. Just reuse the one from requests_mock rather that try
and fix it.

Change-Id: Ia8bcae126babb0e616329928c57f875a50a957d6





The TestResponse object doesn't do the right thing with regards to
content vs text. Just reuse the one from requests_mock rather that try
and fix it.

Change-Id: Ia8bcae126babb0e616329928c57f875a50a957d6







remove the default arguments "{}"
2015-12-14T17:59:30+00:00

Javeme
zhangmei.li@easystack.cn

2015-12-07T13:03:41+00:00

7a4f019764c21c8e97ff6c91718cb1221d865f03

remove the default arguments "{}" when the function is defined.

Change-Id: I81efaf299bc058208a5f553432068e93712cba83
ref: http://docs.python-guide.org/en/latest/writing/gotchas/





remove the default arguments "{}" when the function is defined.

Change-Id: I81efaf299bc058208a5f553432068e93712cba83
ref: http://docs.python-guide.org/en/latest/writing/gotchas/







Merge "Fixes missing socket attribute error during init_poolmanager"
2015-09-08T23:09:42+00:00

Jenkins
jenkins@review.openstack.org

2015-09-08T23:09:42+00:00

f630894f66e6048daf299fb2bab2ffeff6666693