delta/openstack/python-keystoneclient.git/keystoneclient/service_catalog.py, branch stable/zed

Remove use of positional decorator

2017-08-07T20:14:55+00:00

The positional decorator results in poorly maintainable code in
a misguided effort to emulate python3's key-word-arg only notation
and functionality. This patch removes keystoneclient's dependance
on the positional decorator.

Change-Id: I9e691cc8b0c04992f4a8dabd67e1b413d3220d23

Increase readability of 'find()' method and small improvements

2016-10-21T17:00:46+00:00

Assigments replaced with argument assigment: endpoints.py, service_catalog.py
Note added: 'original_ip' value is never used: session.py
Refactor 'find()' method to increase readability: base.py

Change-Id: I469331b123fdf03e9e7c5d93e1c95da57d30fbbe

Removing bandit.yaml in favor of defaults

2016-04-19T15:35:00+00:00

Removing old configuration options for build-in defaults of latest
bandit functionality. Also, marking flagged items with _# nosec_
with a descriptive comment on why the code is acceptable as is.

Co-Authored-By: Christopher J Schaefer 
Co-Authored-By: Tom Cocozzello 

Change-Id: I138ebd46a8be195177361a9c3306bb70423b639d

use positional library instead of utils

2016-01-25T06:54:35+00:00

swap instances of utils.positional with the positional library.

Change-Id: Id8a9961e68d287a802f25512fc970829e9feb5c2

Address hacking check H405

2016-01-13T21:03:51+00:00

Previously, there were a string of commits to keystone that addresed ignored
hacking checks. This commit does the same for H405 in keystoneclient. This
also modifies our tox.ini so that we no longer ignore H405 violations.

Change-Id: I2af152e5425a0e9c82314039fdbb90d661c22680
Closes-Bug: 1482773

Mark abstractmethod bodies with nocover

2015-10-21T18:35:53+00:00

abstractmethod bodies aren't going to be called by unit tests, so
there's no way to get coverage. The code in an abstractmethod body
should be marked with "# pragma: no cover" so that they don't show
up as missed in the coverage report.

Change-Id: I88a7481ab22f2ce1abfd62badc5f5048acc6929f

pass on @abc.abstractmethods

2015-10-21T15:32:33+00:00

Although a bare docstring is entirely valid grammar, those new to Python find
that pattern baffling, *especially* when other similar methods contain pass
statements. So, for consistency, add a pass statement to otherwise bare
@abc.abstractmethods.

Note that the implementation of an @abc.abstractmethod (in the abstract
base class) can still be called by concrete children, so suddenly
raising a NotImplementedError() instead might be "surprising" to
implementors. A no-op such as "pass" or "return None" is preferable.

Change-Id: I79969ad1a3429516ea785c649a165ead54944225

Deprecate ServiceCatalog.get_urls() with no attr

2015-08-13T23:58:27+00:00

There was a TODO to deprecate calling ServiceCatalog.get_urls() with
an attr but no filter_value.

bp deprecations

Change-Id: Idd97ce6920d63e1abb4f10ba4965035ba40f0155

Deprecate ServiceCatalog(region_name)

2015-08-13T23:57:31+00:00

There was a FIXME to deprecate ServiceCatalog's region_name
parameter and property. This is now deprecated.

Note that debtcollector isn't used here since the deprecation
happens on ServiceCatalog's __init__() to catch use in
subclasses of ServiceCatalog. ServiceCatalog also has a
factory function that constructs the correct instance and
the factory function always passes region_name, so it's
always using the deprecated kwarg even when region_name
isn't passed to the factory. It's not worth figuring out
how to do this with debtcollector.

bp deprecations

Change-Id: I0e64712474ca2767f3c0ade919359132450f6776

Allow handling multiple service_types

2015-02-26T03:29:18+00:00

If the same service_type was mentioned in the catalog more than once
then only the last entry would be parsed and any possible other matches
would be lost.

This was something that novaclient used to do, and as we are pushing
sessions as the way that clients should all work we need to maintain
that compatibility.

Change-Id: I6964515ed1975bce1998897abfc02a1ec36e2584
Closes-Bug: #1425766