delta/openstack/python-keystoneclient.git/keystoneclient/httpclient.py, branch 3.8.0 opendev.org: openstack/python-keystoneclient.git Merge "Fix missing service_catalog parameter in Client object" 2016-12-01T00:08:44+00:00 Jenkins jenkins@review.openstack.org 2016-12-01T00:08:44+00:00 f7c1d45a04bb2b024a985b8e30245d38f2bf8442 






Fix typo in httpclient.py
2016-11-08T06:25:11+00:00

zhangyanxian
zhangyanxianmail@163.com

2016-11-08T06:23:23+00:00

e7d7ea4da226b76ffe979d3b9ecba6cededf8e89

TrivialFix

Change-Id: I248e0548fc0242d9f164df901be3c87ae3a75413





TrivialFix

Change-Id: I248e0548fc0242d9f164df901be3c87ae3a75413







Fix missing service_catalog parameter in Client object
2016-08-05T12:21:17+00:00

Mikhail Nikolaenko
mnikolaenko@mirantis.com

2016-07-07T16:30:59+00:00

b405d71a5f9562414ce6b08f7eb4556f534dd273

Return None if service_catalog parameter does not exist.

service_catalog is the property and it is not initialized on object creation.
service_catalog tries to get value from auth_ref and raises AttributeError
exception if auth_ref is not initialized. It worked before we introduced
sessions, because authentication happened on client instantiation. Now,
when sessions are used, auth_ref is not initialized until the first
request. This change adds try-catch block in service_catalog property
to catch this error.

Change-Id: I58eb888f0989241f9e5626564bd48d901b324d36
Closes-Bug: #1508374





Return None if service_catalog parameter does not exist.

service_catalog is the property and it is not initialized on object creation.
service_catalog tries to get value from auth_ref and raises AttributeError
exception if auth_ref is not initialized. It worked before we introduced
sessions, because authentication happened on client instantiation. Now,
when sessions are used, auth_ref is not initialized until the first
request. This change adds try-catch block in service_catalog property
to catch this error.

Change-Id: I58eb888f0989241f9e5626564bd48d901b324d36
Closes-Bug: #1508374







Merge "Fixing D105 PEP257"
2016-05-04T23:31:52+00:00

Jenkins
jenkins@review.openstack.org

2016-05-04T23:31:52+00:00

fb2fef9100beeaaa281e1e7ddef48e9eea327c70












Merge "Fixing D200 PEP257 violation."
2016-05-04T23:31:46+00:00

Jenkins
jenkins@review.openstack.org

2016-05-04T23:31:46+00:00

9f217b63ade96bf1fdcc8ef73d79143eb321dc2b












Merge "Fixing D202 and D203 PEP257 violation."
2016-05-04T23:31:40+00:00

Jenkins
jenkins@review.openstack.org

2016-05-04T23:31:39+00:00

2f2fc1a07146bb7e9be72c0e3a409cb59bda5abe












Fixing D105 PEP257
2016-05-04T19:47:14+00:00

Navid Pustchi
npustchi@gmail.com

2016-05-04T19:14:01+00:00

01500be7fb8d4fdf6d072a1eacf4df87abe86c8c

Currently tox ignores D105.
D105: Missing docstring in magic method.
This change removes it and make keystoneclient docstring compliant with it.

Change-Id: I34dfc164891880425f542f8f8aa3426ec8640c96





Currently tox ignores D105.
D105: Missing docstring in magic method.
This change removes it and make keystoneclient docstring compliant with it.

Change-Id: I34dfc164891880425f542f8f8aa3426ec8640c96







Fixing D200 PEP257 violation.
2016-05-04T19:47:00+00:00

Navid Pustchi
npustchi@gmail.com

2016-05-03T19:01:12+00:00

4c180e691fe1deed3b253016c28e8f6987436074

Currently tox ignores D200.
D200: One-line docstring should fit on one line with quotes.
This change removes D200 ignore in tox and fix violations.

Change-Id: Icbf8cc1d4f1c00daeedeffe4397369f9e468b191





Currently tox ignores D200.
D200: One-line docstring should fit on one line with quotes.
This change removes D200 ignore in tox and fix violations.

Change-Id: Icbf8cc1d4f1c00daeedeffe4397369f9e468b191







Fixing D202 and D203 PEP257 violation.
2016-05-04T19:45:30+00:00

Navid Pustchi
npustchi@gmail.com

2016-05-03T18:54:12+00:00

bca112c8ba5636becd6951fbfb8cb8f2474279fe

Currently tox ignores D202 and D203.
D202: No blank lines allowed after function docstring.
D203: 1 blank required before class docstring.
This change removes D202 and D203 ignores in tox and fix violations.

Change-Id: I97ef88c9cfd56774e47f789cbbcf8ccfe85d7737





Currently tox ignores D202 and D203.
D202: No blank lines allowed after function docstring.
D203: 1 blank required before class docstring.
This change removes D202 and D203 ignores in tox and fix violations.

Change-Id: I97ef88c9cfd56774e47f789cbbcf8ccfe85d7737







httpclient: remove unused debug kwargs
2016-05-02T22:23:54+00:00

Julien Danjou
julien@danjou.info

2015-10-18T19:55:51+00:00

14900dd683ba49f085456101118dd12105d2d98e

This has been deprecated for a while and is now not even used anymore.

Indeed, nothing in the code use the attribute
keystoneclient.httpclient.HTTPClient.debug_log.
Furthermore, removing the debug keyword argument from the signature of
keystoneclient.httpclient.HTTPClient.__init__ has no impact since this
signature include **kwargs, which in Python means that you it will
accept any keyword-argument. Any code that would still pass the debug
argument to that method will therefore not notice any difference and
will not fail.

Change-Id: Iaae4febf3f13f6a66ad0e792dc2347b4699f65c0





This has been deprecated for a while and is now not even used anymore.

Indeed, nothing in the code use the attribute
keystoneclient.httpclient.HTTPClient.debug_log.
Furthermore, removing the debug keyword argument from the signature of
keystoneclient.httpclient.HTTPClient.__init__ has no impact since this
signature include **kwargs, which in Python means that you it will
accept any keyword-argument. Any code that would still pass the debug
argument to that method will therefore not notice any difference and
will not fail.

Change-Id: Iaae4febf3f13f6a66ad0e792dc2347b4699f65c0