delta/openstack/python-ironicclient.git/ironicclient/tests/unit/test_shell.py, branch stable/liberty opendev.org: openstack/python-ironicclient.git Mock keystone call to avoid test failure 2015-10-13T21:53:48+00:00 Lucas Alvares Gomes lucasagomes@gmail.com 2015-10-08T16:06:02+00:00 cd84edd2bec0e71d9a7f83c6fe1b9ab9b18fcecf The test test_password_prompted() was expecting a keystone failure, but because of an error in the requests/urllib3 library it was returning a different exception and causing our tests to fail, see[1]. Independent of the the problem above on tests we should not rely on some external library failing like that, we should mock this failures to make our tests more reliable and that's what this patch is doing. [1] https://bugs.launchpad.net/ospurge/+bug/1503768 Change-Id: I3e6091eb2bc221a16fdc18b998ba138058818894 Closes-Bug: #1504197 (cherry picked from commit 42d52af3c2238900eb69217bba5dbbcdca63abf0) 
The test test_password_prompted() was expecting a keystone failure, but
because of an error in the requests/urllib3 library it was returning a
different exception and causing our tests to fail, see[1].

Independent of the the problem above on tests we should not rely on some
external library failing like that, we should mock this failures to make
our tests more reliable and that's what this patch is doing.

[1] https://bugs.launchpad.net/ospurge/+bug/1503768

Change-Id: I3e6091eb2bc221a16fdc18b998ba138058818894
Closes-Bug: #1504197
(cherry picked from commit 42d52af3c2238900eb69217bba5dbbcdca63abf0)
Register global Keystone args first 2015-06-16T18:15:35+00:00 Ben Nemec bnemec@redhat.com 2015-06-09T22:45:30+00:00 e6ae41c537fe8bec300937df5c4392816f60e426 As described in the referenced bug, registering the Keystone args last causes their default values to be ignored. Registering them first seems to prevent the problem. Change-Id: I8eb7882a0153fedbd6591dde2157df13fa2e5ba3 Closes-Bug: 1463581 
As described in the referenced bug, registering the Keystone args
last causes their default values to be ignored.  Registering them
first seems to prevent the problem.

Change-Id: I8eb7882a0153fedbd6591dde2157df13fa2e5ba3
Closes-Bug: 1463581
Remove unneeded 'utf-8' coding lines 2015-04-21T16:44:47+00:00 John L. Villalovos john.l.villalovos@intel.com 2015-04-20T18:49:38+00:00 2df670cf3045c2c430eaaac6f48919d6d1586afc This is basically a revert of commit: af741ec2236619880fa902d68aef4a6ae6cef534 It was decided that only files that need to have the line: # -*- coding: utf-8 -*- Should have the line[1] as a general principle This patch removes the 'utf-8' coding line from files that consist entirely of ASCII characters. [1] http://eavesdrop.openstack.org/meetings/ironic/2015/ironic.2015-04-20-17.00.html Partial-bug: #1325193 Change-Id: I88c1c37f7b580aa805eae9d4a1e66d33302a325f 
This is basically a revert of commit:
  af741ec2236619880fa902d68aef4a6ae6cef534

It was decided that only files that need to have the line:
  # -*- coding: utf-8 -*-
Should have the line[1] as a general principle

This patch removes the 'utf-8' coding line from files that consist
entirely of ASCII characters.

[1]
http://eavesdrop.openstack.org/meetings/ironic/2015/ironic.2015-04-20-17.00.html

Partial-bug: #1325193
Change-Id: I88c1c37f7b580aa805eae9d4a1e66d33302a325f
Fix the final PEP8 errors 2015-03-10T21:38:30+00:00 John L. Villalovos john.l.villalovos@intel.com 2015-03-10T21:07:06+00:00 144e82b163117e95dd14b3fae9d7cc8456c57eb1 Fix PEP8 E126,E127,E128 errors, which were the only ones remaining. Fix PEP8 errors: E126: continuation line over-indented for hanging indent E127: continuation line over-indented for visual indent E128: continuation line under-indented for visual indent Remove the ignore= entries for flake8 in tox.ini Change-Id: I919551121d85d2aab528f4fa5ecdb3cfd940557a 
Fix PEP8 E126,E127,E128 errors, which were the only ones remaining.

Fix PEP8 errors:
E126: continuation line over-indented for hanging indent
E127: continuation line over-indented for visual indent
E128: continuation line under-indented for visual indent

Remove the ignore= entries for flake8 in tox.ini

Change-Id: I919551121d85d2aab528f4fa5ecdb3cfd940557a
Adds basic ironicclient functional testing 2015-03-09T20:45:20+00:00 Adam Gandelman adamg@ubuntu.com 2015-03-06T01:20:03+00:00 d76862b1869ea529da1e149f4e3a00cc5fb9eda6 This moves unit tests to ironicclient/tests/unit and adds a new test directory at ironicclient/tests/functional. These are meant to be functional tests that are run against a living cloud (presumably deployed by devstack as part of a gating job). They depend on a test.conf to exist that contains admin user credentials for said cloud. This includes a simple run_functional.sh script that is meant to create that and serve as the entry point for running the tests from a devstack post_test_hook. Change-Id: I11570c3e22e4f80b94d0643dca6ed8231217c877 
This moves unit tests to ironicclient/tests/unit and adds a new test
directory at ironicclient/tests/functional.  These are meant to be
functional tests that are run against a living cloud (presumably deployed
by devstack as part of a gating job).  They depend on a test.conf to exist
that contains admin user credentials for said cloud.  This includes a simple
run_functional.sh script that is meant to create that and serve as the entry
point for running the tests from a devstack post_test_hook.

Change-Id: I11570c3e22e4f80b94d0643dca6ed8231217c877