delta/openstack/python-ironicclient.git, branch train-em

Provide a clear error message when using client.Client without a session

2020-02-10T12:58:54+00:00

Currently we fail with _construct_http_client() takes at least 1 argument.
This change provides a proper TypeError and updates documentation to make
it clear where a session is required. Also provided are explicit unit
tests on passing a session via various means.

Change-Id: I96073dc80d225a9b88fdc12bb058c0145aca623b
(cherry picked from commit e8914a7ef9eb582441a7067f2663e19209f32822)

Fix AttributeError in negotiate_version

2019-12-04T11:25:39+00:00

Seen in kolla-ansible CI, if ironic inspector starts up before ironic
API is properly up, we see the following error:

The PXE filter DnsmasqFilter, state=initialized encountered an
exception: StrictVersion instance has no attribute 'version'; resetting
the filter: AttributeError: StrictVersion instance has no attribute
'version'

Example: http://paste.openstack.org/show/756342/

The usual cause of this error is when StrictVersion is initialised with
a version of None. This suggests to me that max_ver is None.

This leads to an exception being raised that circumvents the client's
retry mechanisms.

In the particular case of kolla-ansible CI, Ironic API is behind a load
balancer, and all backends are down resulting in a 503. The lack of a
retry caused ironic inspector to fail on startup.

This patch catches the case where we get a 4xx or 5xx return code when
checking the version, and raises an error that works with the client's
retry mechanisms.

Change-Id: Ib62ca3ee4626084e5e9b90e93e4fa97938023457
Story: 2006393
Task: 36266
(cherry picked from commit 0e9bf337f1f6aa41f67df2966dacf9e8e897b7da)

Fix usage of --owner filter during node list

2019-09-24T14:52:17+00:00

When using --owner filter during node list, the CLI returns
this error:

  list() got an unexpected keyword argument 'owner'

Change-Id: Id751336d8d8cb99e62e465e17114e610f619c520
Story: 2006563
Task: 36660
(cherry picked from commit 89088e2aaa8329bbb98380748e5d9716734e0db6)

Merge "Remove the requirement on either endpoint_override or os_ironic_api_version" into stable/train

2019-09-24T14:12:58+00:00

Make it clear that a Session is required for v1.client.Client

2019-09-24T13:33:04+00:00

Change-Id: Icfb5f11a59a6b7cc65dcda0b87240c57c120e228
(cherry picked from commit 66a9c87c39a08727e3a3b8c18ba3281c9999b528)

Remove the requirement on either endpoint_override or os_ironic_api_version

2019-09-24T13:01:53+00:00

It makes zero sense from a caller's perspective. We only use it for efficient
caching of API versions, which can safely be bypassed.

Change-Id: I00508d36ec1679cdcc9c9d1ec744d818dee74e0b
(cherry picked from commit c3e490800aaeb1f814aa0af25a9155fa6f794215)

Merge "Fix TypeError when using endpoint_override with SessionClient" into stable/train

2019-09-24T12:38:03+00:00

Make the dependency on oslo.config explicit

2019-09-24T11:20:39+00:00

The code in ironicclient.client that uses session_loader.get_conf_options
requires oslo.config to operate. This patch makes the dependency explicit.

Story: #2006601
Task: #36764
Change-Id: I472896ddd0ced8535d71d807fb5e01d1471571eb
(cherry picked from commit 7c27668ed6f60062f7ad512388caf65fac87cd79)

Fix TypeError when using endpoint_override with SessionClient

2019-09-24T11:20:25+00:00

First, when endpoint cannot be detected from a session None is returned
from get_endpoint, causing subsequent code to fail. This changes fixes it.

Second, endpoint_override is not passed to a Session (it's an Adapter)
property, doing it has no effect. Use get_endpoint from Adapter instead.

Change-Id: Ia942858abe980abf95c1ca136767983e7a0a285e
Story: #2006600
Task: #36763
(cherry picked from commit 7f003e1e045e3e20b824a94676310315f8fef9fc)

Update TOX/UPPER_CONSTRAINTS_FILE for stable/train

2019-09-10T17:06:45+00:00

Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/train branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I447b0ff53abd202abcb2a6699d31ac7e94577f66