Due to a typo in an attribute named, an Attribute error is raised causing failure in connection to glance through HTTPS Urllib3 PoolManager class has a connection_pool_kw attribute but not connection_kw Change-Id: Id4d6a5bdcf971d09e80043fd2ab399e208fd931c Closes-Bug: #1479020 (cherry picked from commit c41dcc9f4366429d952cc47853496d58d47b7511)
The client currently downloads the image metadata to check if it's deleted or not. This logic belongs to the server and it's already implemented there. Instead of getting the image, send the delete request and catch the 404 error, which is already raised by the server. Change-Id: I1e6ef42340f8e380ff99b9d6ca7ea416e0eebfbc Closes-bug: #1496305 (cherry picked from commit b8a881f5ea89514d715e61b632bc3081a0dde2c6) (cherry picked from commit e82d9df74cbac9accc8a6724c0759760e44bb315)
Now that we have stable branches for clients, it's easier to keep track of the current default image's schema in Glance and update it respectively. This patch adds the current image schema, including the schema-properties. One good reason to do this is to be able to react when a running Glance instance is not around to be introspected. It's really unfortunate that things like help text can't be rendered when there image schema is not available in the system. We could keep the schema in a json file but rather than shipping data files with glanceclient we can just have it in the python modules. Conflicts: glanceclient/v2/shell.py Change-Id: I9b8cc1d18d6717ccf991fb8149ab13c06d653ee4 Closes-bug: #1481729 (cherry picked from commit 3949e0e918e2501c4953a7d9beb58511688d84e1)
Previously when listing images via v2, the first image of each batch was validated against the v2 schema. This could lead to unpredictable behaviour where a particular image which failed the schema check may or may not be the first of a batch. In some cases it also meant that operation by one user could affect the ability of another other to list images. Change-Id: I22974a3e3d9cbdd254099780752ae45ff2a557af Closes-bug: 1477910 (cherry picked from commit 43769d6cc7266d7c81db31ad58b4fa403c35b611)
Changeset I49255255 has added an 'is_base' attribute for Image Schema properties, thus allowing to differentiate between base and custom image properties, but the client hasn't make any use of it. This patch adds appropriate attribute to SchemaProperty class and a helper method which allows to validate if the given property is base or not. The added helper method (is_base_property) should not be confused with the existing is_core_property: the latter just checks if the property is known to the schema, regardless of its being base or not. Change-Id: I7c397196dad9ae5494ed2f8f3aacef3fc1ce70d8 Partial-Bug: #1323660 (cherry picked from commit 90407d9e473014c24eeab294192f9d3208f58ea7)
Currently when you are trying to update the location of an image which is not in queued status you will get an error from the Glance API. The help message for --location and --copy-from arguments should be updated to inform the user that it works only for images in queued status. Co-Authored-By: Abhishek Talwar <abhishek.talwar@tcs.com> Co-Authored-By: Kamil Rykowski <kamil.rykowski@intel.com> Change-Id: I82b14ffde3f301d7ffef68e984ba4ad2ae0f8b0f Closes-Bug: #1220809 (cherry picked from commit 6d864ef65c73905370fe9c817fb81b262714bd2d)