delta/openstack/python-glanceclient.git/glanceclient/v2, branch master opendev.org: openstack/python-glanceclient.git do_image_import: fix argument retrieval 2023-04-18T01:21:03+00:00 Cyril Roelandt cyril@redhat.com 2023-04-18T00:40:54+00:00 e2190c4feb7b237c55a5d7df49e0db340a9d342f The argparse module automatically replaces '-' characters with '_' characters when converting an option string to an attribute: «For optional argument actions, the value of dest is normally inferred from the option strings. ArgumentParser generates the value of dest by taking the first long option string and stripping away the initial -- string. If no long option strings were supplied, dest will be derived from the first short option string by stripping the initial - character. Any internal - characters will be converted to _ characters to make sure the string is a valid attribute name.»[1] This means that the value of the "--remote-region" option of the "image-import" command will be available as "args.remote_region"; "remote-region" would not be a valid attribute anyway. We make sure to retrieve the proper value for the following options: --remote-region, --remote-image-id and --remote-service-interface. [1] https://docs.python.org/3/library/argparse.html#dest Change-Id: I1d8c69acd5d61fdc426469cd87d1ace81871e60f Partial-Bug: #2012442 
The argparse module automatically replaces '-' characters with '_'
characters when converting an option string to an attribute:

«For optional argument actions, the value of dest is normally inferred
from the option strings. ArgumentParser generates the value of dest by
taking the first long option string and stripping away the initial --
string. If no long option strings were supplied, dest will be derived
from the first short option string by stripping the initial - character.
Any internal - characters will be converted to _ characters to make sure
the string is a valid attribute name.»[1]

This means that the value of the "--remote-region" option of the
"image-import" command will be available as "args.remote_region";
"remote-region" would not be a valid attribute anyway.

We make sure to retrieve the proper value for the following
options: --remote-region, --remote-image-id and
--remote-service-interface.

[1] https://docs.python.org/3/library/argparse.html#dest

Change-Id: I1d8c69acd5d61fdc426469cd87d1ace81871e60f
Partial-Bug: #2012442
schema_args: Do not generate option for read-only properties 2022-09-26T21:54:06+00:00 Cyril Roelandt cyril@redhat.com 2022-09-20T16:05:33+00:00 74fa43665719ddc830999fa15bb052a87d69dd14 The schema_args decorator generates command line options based on the properties defined in a schema. This commit makes sure read-only properties are skipped during this process, since trying to modify their value would result in a Glance error. Closes-Bug: #1561828 Change-Id: I7ccc628a23c9ebdaeedcb9e6d43559f497ce9555 
The schema_args decorator generates command line options based on the
properties defined in a schema. This commit makes sure read-only
properties are skipped during this process, since trying to modify their
value would result in a Glance error.

Closes-Bug: #1561828
Change-Id: I7ccc628a23c9ebdaeedcb9e6d43559f497ce9555
Merge "Add support for glance-download import method" 2022-08-30T14:57:55+00:00 Zuul zuul@review.opendev.org 2022-08-30T14:57:55+00:00 f2999ce752e111d93a74c73cae5cccfceb4467c2 






Add support for glance-download import method
2022-08-30T11:20:40+00:00

Pranali Deore
pdeore@redhat.com

2022-08-26T04:18:31+00:00

92cd70a2240dd5106ebfffecd6007942e898903a

Implements: blueprint glance-download-import-support
Change-Id: Ia2bfad82bccf9acb6103b21112e680c44e295d39





Implements: blueprint glance-download-import-support
Change-Id: Ia2bfad82bccf9acb6103b21112e680c44e295d39







Bump default pagesize
2022-08-26T11:46:20+00:00

Erno Kuvaja
jokke@usr.fi

2022-08-26T11:46:20+00:00

219568c2a4b21c26ca4c160a7cf4d71cae524255

Bumping default pagesize to 200. With the previous
default value of 20 glanceclient was doing lots of
extra requests and schema validations.

Based on my tests no performance improvement was
seen over the pagesize of 200.

Change-Id: I6d740ca3a9b32bf5d064d3ea74273bb619b32ad4
Closes-Bug: #1987834





Bumping default pagesize to 200. With the previous
default value of 20 glanceclient was doing lots of
extra requests and schema validations.

Based on my tests no performance improvement was
seen over the pagesize of 200.

Change-Id: I6d740ca3a9b32bf5d064d3ea74273bb619b32ad4
Closes-Bug: #1987834







Check if stdin has isatty attribute
2022-07-07T00:55:10+00:00

Benedikt Loeffler
benedikt.loeffler@bmw.de

2021-10-13T11:50:36+00:00

8df9328a60045edae36dc64cee1f2cf3cd4a09fa

When the stdin is closed, it has no isatty atrribute which leads to a KeyError.

Closes-Bug: #1980890
Change-Id: If9a3bf68b8dfd953b346697241166578d18bb563





When the stdin is closed, it has no isatty atrribute which leads to a KeyError.

Closes-Bug: #1980890
Change-Id: If9a3bf68b8dfd953b346697241166578d18bb563







Add support for Cache API
2022-02-22T16:39:33+00:00

Erno Kuvaja
jokke@usr.fi

2021-07-09T09:41:22+00:00

62f4f67d1d3f1ad74418d1e8cd5bb946cc8425d9

This change provides support for the Cache API changes and
deprecation path for glance-cache-manage command.

Change-Id: I6fca9bbe6bc0bd9b14d8dba685405838131160af





This change provides support for the Cache API changes and
deprecation path for glance-cache-manage command.

Change-Id: I6fca9bbe6bc0bd9b14d8dba685405838131160af







Merge "Add an optional parameter --append"
2022-02-17T18:51:52+00:00

Zuul
zuul@review.opendev.org

2022-02-17T18:51:52+00:00

63bb03a145a7003a7e9ba40dd325995986fa953a












Merge "Add an optional parameter --detail"
2022-02-16T19:32:15+00:00

Zuul
zuul@review.opendev.org

2022-02-16T19:32:15+00:00

683b694fff00c86652df24c36eb00b9c8ab9c78e












Add an optional parameter --append
2022-02-16T14:00:28+00:00

Mridula Joshi
mrjoshi@redhat.com

2021-10-12T07:32:36+00:00

b8863535a823ef2c271ebc4ddd1afd039bbc3f93

This patch will add an optional parameter --append to the glanceclient
command md-tag-create-multiple to provide the facility of appending
the tags.
If the parameter is present  it will append the tags to existing one,
else it will overwrite the existing tags.

Depends-On: https://review.opendev.org/c/openstack/glance/+/804966
Change-Id: I1841e7146da76b13f4cd8925e19f59d0eaf08f7a





This patch will add an optional parameter --append to the glanceclient
command md-tag-create-multiple to provide the facility of appending
the tags.
If the parameter is present  it will append the tags to existing one,
else it will overwrite the existing tags.

Depends-On: https://review.opendev.org/c/openstack/glance/+/804966
Change-Id: I1841e7146da76b13f4cd8925e19f59d0eaf08f7a