delta/openstack/python-glanceclient.git/glanceclient/tests/unit, branch pike-eol

Validate input args before trying image download

2017-07-24T09:24:57+00:00

Currently client is contacting glance service even if the
caller has niether specified any redirection nor '--file'
option. This unnecessary request although isn't causing
any critical issues but can be avoided by simply doing
input validation first.

TrivialFix

Change-Id: I841bebeda38814235079429eca0b1e5fd2f04dae

Merge "Replace assertTrue(isinstance()) with assertIsInstance()"

2017-06-30T21:03:45+00:00

Merge "Replace six.iteritems() with .items()"

2017-06-28T14:49:38+00:00

allow unhandled exceptions to cause test errors

2017-06-26T14:59:29+00:00

Hiding the unhandled exception in the test with a failure makes it
harder to debug the problem. Let them pass unhandled so the test reports
an ERROR instead of FAILURE.

Change-Id: I4e435a6d276fdf161dac28f08c2c7efedd1d6385
Signed-off-by: Doug Hellmann

Replace assertTrue(isinstance()) with assertIsInstance()

2017-06-14T04:03:10+00:00

Some of tests use different method of assertTrue(isinstance(A, B))
or assertEqual(type(A), B). The correct way is to use
assertIsInstance(A, B) provided by test tools.

Change-Id: Ibb5e5f848c5632f7c1895c47b8c1a938f2c746c3

Merge "Allow global_request_id in Client constructor"

2017-06-01T17:22:55+00:00

Allow global_request_id in Client constructor

2017-06-01T14:32:03+00:00

This allows us to pass in a global_request_id in the client
constructor so that subsequent calls with this client pass that to the
servers. This enables cross project request_id tracking.

oslo spec I65de8261746b25d45e105394f4eeb95b9cb3bd42

Change-Id: Iea1e754a263a01dae5ed598fdda134394aff54b0

Downloading image with --progress fails

2017-05-29T12:26:11+00:00

Downloading image with --progress fails with "RequestIdProxy object is
not an iterator". This is because to display download progress
VerboseFileWrapper in progressbar requires object of IterableWithLength,
but after support of returning request-id [1] to caller it returns
RequestIdProxy object which is wrapped around IterableWithLength
and response.

To resolve this issue overridden next and __next__ methods in
RequestIdProxy so that it can act as iterator for python 2.x
and 3.x as well.

[1] 610177a779b95f931356c1e90b05a5bffd2616b3

Closes-Bug: #1670464
Change-Id: I188e67c2487b7e4178ea246f02154bbcbc35a2b1

Merge "Downloading image with --progress fails for python3"

2017-05-29T11:54:55+00:00

v2: Content-Type: application/octet-stream header always added

2017-05-19T19:02:00+00:00

The bug: any existing Content-Type header cannot be found because the
call to headers.get() fails. Therefore we end up with two Content-Type
headers because a new one (applicaion/octet-stream) gets added
unconditionally. The cause: the strings (keys and values) in the headers
dict are converted from unicode sequences of type  to utf-8
sequences of type . This happens in safe_encode()
(oslo_utils/encodeutils.py:66).  !=  even if they appear to
have the same characters.

Hence, for python 3.x, _set_common_request_kwargs() adds content-type
to header even if custom content-type is set in the request.

This results in unsupported media type exception when glance client
is used with keystoneauth and python 3.x

The fix: follow the directions in encode_headers().
It says to do this just before sending the request. Honor this principle;
do not encode headers and then perform more business logic on them.

Change-Id: Idf6079b32f70bc171f5016467048e917d42f296d
Closes-bug: #1641239
Co-Authored-By: Pushkar Umaranikar