<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-glanceclient.git/glanceclient/tests/unit, branch master</title>
<subtitle>opendev.org: openstack/python-glanceclient.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/'/>
<entry>
<title>do_image_import: fix argument retrieval</title>
<updated>2023-04-18T01:21:03+00:00</updated>
<author>
<name>Cyril Roelandt</name>
<email>cyril@redhat.com</email>
</author>
<published>2023-04-18T00:40:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=e2190c4feb7b237c55a5d7df49e0db340a9d342f'/>
<id>e2190c4feb7b237c55a5d7df49e0db340a9d342f</id>
<content type='text'>
The argparse module automatically replaces '-' characters with '_'
characters when converting an option string to an attribute:

«For optional argument actions, the value of dest is normally inferred
from the option strings. ArgumentParser generates the value of dest by
taking the first long option string and stripping away the initial --
string. If no long option strings were supplied, dest will be derived
from the first short option string by stripping the initial - character.
Any internal - characters will be converted to _ characters to make sure
the string is a valid attribute name.»[1]

This means that the value of the "--remote-region" option of the
"image-import" command will be available as "args.remote_region";
"remote-region" would not be a valid attribute anyway.

We make sure to retrieve the proper value for the following
options: --remote-region, --remote-image-id and
--remote-service-interface.

[1] https://docs.python.org/3/library/argparse.html#dest

Change-Id: I1d8c69acd5d61fdc426469cd87d1ace81871e60f
Partial-Bug: #2012442
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The argparse module automatically replaces '-' characters with '_'
characters when converting an option string to an attribute:

«For optional argument actions, the value of dest is normally inferred
from the option strings. ArgumentParser generates the value of dest by
taking the first long option string and stripping away the initial --
string. If no long option strings were supplied, dest will be derived
from the first short option string by stripping the initial - character.
Any internal - characters will be converted to _ characters to make sure
the string is a valid attribute name.»[1]

This means that the value of the "--remote-region" option of the
"image-import" command will be available as "args.remote_region";
"remote-region" would not be a valid attribute anyway.

We make sure to retrieve the proper value for the following
options: --remote-region, --remote-image-id and
--remote-service-interface.

[1] https://docs.python.org/3/library/argparse.html#dest

Change-Id: I1d8c69acd5d61fdc426469cd87d1ace81871e60f
Partial-Bug: #2012442
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Unhardcode the value of DEFAULT_PAGE_SIZE from the tests"</title>
<updated>2023-02-09T15:33:18+00:00</updated>
<author>
<name>Zuul</name>
<email>zuul@review.opendev.org</email>
</author>
<published>2023-02-09T15:33:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=2d893b12ddace765799fd7b4de956b838c3056e8'/>
<id>2d893b12ddace765799fd7b4de956b838c3056e8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Remove unicode-related Python2-only code"</title>
<updated>2023-01-12T22:39:42+00:00</updated>
<author>
<name>Zuul</name>
<email>zuul@review.opendev.org</email>
</author>
<published>2023-01-12T22:39:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=590f793c9fd0cb50df42e3e2f674028201bb102a'/>
<id>590f793c9fd0cb50df42e3e2f674028201bb102a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Boolean options: use strict checking"</title>
<updated>2023-01-12T22:39:41+00:00</updated>
<author>
<name>Zuul</name>
<email>zuul@review.opendev.org</email>
</author>
<published>2023-01-12T22:39:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=9b9c67771505ead95feb2525773f988a59436cf6'/>
<id>9b9c67771505ead95feb2525773f988a59436cf6</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Boolean options: use strict checking</title>
<updated>2022-11-14T16:31:39+00:00</updated>
<author>
<name>Cyril Roelandt</name>
<email>cyril@redhat.com</email>
</author>
<published>2022-09-21T17:38:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=88e3b0ad984797ec1f856429698949e4781dff3a'/>
<id>88e3b0ad984797ec1f856429698949e4781dff3a</id>
<content type='text'>
Boolean options (such as "--protected" for glance md-namespace-update)
should accept a limited amount of valid values, rather than assuming an
"invalid" value means "False".

The following values (no matter the case) will now be interpreted as
True: ‘t’,’true’, ‘on’, ‘y’, ‘yes’, or ‘1’.

The following values (no matter the case) will now be interpreted as
False: ‘f’, ‘false’, ‘off’, ‘n’, ‘no’, or ‘0’.

Change-Id: I0e7942045d883ac398bab4a7a85f2b4ac9b1ed8c
Closes-Bug: #1607317
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Boolean options (such as "--protected" for glance md-namespace-update)
should accept a limited amount of valid values, rather than assuming an
"invalid" value means "False".

The following values (no matter the case) will now be interpreted as
True: ‘t’,’true’, ‘on’, ‘y’, ‘yes’, or ‘1’.

The following values (no matter the case) will now be interpreted as
False: ‘f’, ‘false’, ‘off’, ‘n’, ‘no’, or ‘0’.

Change-Id: I0e7942045d883ac398bab4a7a85f2b4ac9b1ed8c
Closes-Bug: #1607317
</pre>
</div>
</content>
</entry>
<entry>
<title>Unhardcode the value of DEFAULT_PAGE_SIZE from the tests</title>
<updated>2022-11-14T11:04:23+00:00</updated>
<author>
<name>Cyril Roelandt</name>
<email>cyril@redhat.com</email>
</author>
<published>2022-01-12T20:28:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=4bb406d3774be4ad40f561a583f213a7b2a9133e'/>
<id>4bb406d3774be4ad40f561a583f213a7b2a9133e</id>
<content type='text'>
The value of DEFAULT_PAGE_SIZE (20) was hardcoded in multiple places in
the tests, which means all the tests would break should we ever want to
change that value.

Co-Authored-By:	韩春蕾 &lt;1922361860@qq.com&gt;

Change-Id: I6e8dbae32c3a24d3fbeebcea5bfe0dd9ae247035
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The value of DEFAULT_PAGE_SIZE (20) was hardcoded in multiple places in
the tests, which means all the tests would break should we ever want to
change that value.

Co-Authored-By:	韩春蕾 &lt;1922361860@qq.com&gt;

Change-Id: I6e8dbae32c3a24d3fbeebcea5bfe0dd9ae247035
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unicode-related Python2-only code</title>
<updated>2022-11-14T10:49:33+00:00</updated>
<author>
<name>Cyril Roelandt</name>
<email>cyril@redhat.com</email>
</author>
<published>2022-09-13T14:15:13+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=fc8f9ac2edfb4daa0c48a650515de3e8eba18232'/>
<id>fc8f9ac2edfb4daa0c48a650515de3e8eba18232</id>
<content type='text'>
This commit:
- removes the old "u" prefix from all strings
- removes the unicode_key_value_to_string function

Change-Id: I1da347e31e828fd2359f0935a4da47257116d4cb
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit:
- removes the old "u" prefix from all strings
- removes the unicode_key_value_to_string function

Change-Id: I1da347e31e828fd2359f0935a4da47257116d4cb
</pre>
</div>
</content>
</entry>
<entry>
<title>schema_args: Do not generate option for read-only properties</title>
<updated>2022-09-26T21:54:06+00:00</updated>
<author>
<name>Cyril Roelandt</name>
<email>cyril@redhat.com</email>
</author>
<published>2022-09-20T16:05:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=74fa43665719ddc830999fa15bb052a87d69dd14'/>
<id>74fa43665719ddc830999fa15bb052a87d69dd14</id>
<content type='text'>
The schema_args decorator generates command line options based on the
properties defined in a schema. This commit makes sure read-only
properties are skipped during this process, since trying to modify their
value would result in a Glance error.

Closes-Bug: #1561828
Change-Id: I7ccc628a23c9ebdaeedcb9e6d43559f497ce9555
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The schema_args decorator generates command line options based on the
properties defined in a schema. This commit makes sure read-only
properties are skipped during this process, since trying to modify their
value would result in a Glance error.

Closes-Bug: #1561828
Change-Id: I7ccc628a23c9ebdaeedcb9e6d43559f497ce9555
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Add support for glance-download import method"</title>
<updated>2022-08-30T14:57:55+00:00</updated>
<author>
<name>Zuul</name>
<email>zuul@review.opendev.org</email>
</author>
<published>2022-08-30T14:57:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=f2999ce752e111d93a74c73cae5cccfceb4467c2'/>
<id>f2999ce752e111d93a74c73cae5cccfceb4467c2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for glance-download import method</title>
<updated>2022-08-30T11:20:40+00:00</updated>
<author>
<name>Pranali Deore</name>
<email>pdeore@redhat.com</email>
</author>
<published>2022-08-26T04:18:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-glanceclient.git/commit/?id=92cd70a2240dd5106ebfffecd6007942e898903a'/>
<id>92cd70a2240dd5106ebfffecd6007942e898903a</id>
<content type='text'>
Implements: blueprint glance-download-import-support
Change-Id: Ia2bfad82bccf9acb6103b21112e680c44e295d39
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Implements: blueprint glance-download-import-support
Change-Id: Ia2bfad82bccf9acb6103b21112e680c44e295d39
</pre>
</div>
</content>
</entry>
</feed>
