delta/openstack/python-glanceclient.git/glanceclient/common, branch kilo-eol

Fix failure to create glance https connection pool

2015-12-22T16:56:26+00:00

Due to a typo in an attribute named, an Attribute error is raised
causing failure in connection to glance through HTTPS

Urllib3 PoolManager class has a connection_pool_kw attribute
but not connection_kw

Change-Id: Id4d6a5bdcf971d09e80043fd2ab399e208fd931c
Closes-Bug: #1479020
(cherry picked from commit c41dcc9f4366429d952cc47853496d58d47b7511)

Fix client when using no ssl compression

2015-04-16T15:05:53+00:00

Since the release of the 0.16.1 client, using the 'no ssl compression'
option, whether on the command line, or via the library -- Nova does this by
default -- a stack trace was generated.

Closes-bug: 1442664
Related-bug: 1357430

Change-Id: I2b8ddcb0a7ae3cfccdfc20d3ba476f3b4f4ec32d
(cherry picked from commit c698b4e3227b4767f042e435423fcc307d7f6d5c)

Merge "Unify using six.moves.range rename everywhere"

2015-03-04T16:29:50+00:00

Merge "https: Prevent leaking sockets for some operations"

2015-03-04T08:38:19+00:00

Merge "Register our own ConnectionPool without globals"

2015-02-26T21:29:06+00:00

Unify using six.moves.range rename everywhere

2015-02-25T12:17:24+00:00

Mainly to improve consistency, use range() from six.moves
renames across glance.

Behaves consistently like py2 xrange() and py3 range().

Change-Id: I7c573a3a9775f454b98d25f2a14f8e9f5f4ac432

Merge "Reduce the set of supported client SSL ciphers"

2015-02-23T16:06:48+00:00

Merge "Update HTTPS certificate handling for pep-0476"

2015-02-19T17:58:58+00:00

https: Prevent leaking sockets for some operations

2015-02-18T12:31:24+00:00

Other OpenStack services which instantiate a 'https' glanceclient using
ssl_compression=False and insecure=False (eg Nova, Cinder) are leaking
sockets due to glanceclient not closing the connection to the Glance
server.

This could happen for a sub-set of calls, eg 'show', 'delete', 'update'.

netstat -nopd would show the sockets would hang around forever:

... 127.0.0.1:9292          ESTABLISHED 9552/python      off (0.00/0/0)

urllib's ConnectionPool relies on the garbage collector to tear down
sockets which are no longer in use. The 'verify_callback' function used to
validate SSL certs was holding a reference to the VerifiedHTTPSConnection
instance which prevented the sockets being torn down.

Change-Id: Idb3e68151c48ed623ab89d05d88ea48465429838
Closes-bug: 1423165

Register our own ConnectionPool without globals

2015-02-06T19:49:13+00:00

Currently, on systems like Fedora and Debian, it is possible to import
urllib3 as well as requests.packages.urllib3. They functionally point to
the same code but sys.modules considers them to be separate items. When
downstream packagers unvendor urllib3 from requests, they also change
all the imports inside of the package. So if the code imports urllib3
from requests.packages.urllib3 and modifies globals in a submodule, that
will not be visible to requests since it has been rewritten to use
urllib3 (not requests.packages.urllib3). By handling this logic
ourselves, we can issue a release until upstream packages and requests
can fix this and cut a new release.

Change-Id: Ic77ce8a06d9d148a899b4b8695990fca8fdaefc5
Closes-bug: 1396550