delta/openstack/python-cinderclient.git/cinderclient/base.py, branch 1.2.2 opendev.org: openstack/python-cinderclient.git Add findall server side filtering 2015-05-22T10:19:47+00:00 Anton Arefiev aarefiev@mirantis.com 2015-05-06T11:54:15+00:00 0b8b9f2de7270a74fb54d40122a9ed397b6360c7 Findall method in cinderclient/base.py isn't very efficient: it loads the entire list then filters on the Python side. When calling "cinder show 'volName'" on a tenant holding a lot of volumes (> 1000) the run time is too long. On my env show command with 10000 volumes takes ~2 min, after apply this patch few seconds. Closes-Bug: #1449444 Change-Id: I23070d94d5bb100b2dd8677f67d7c8b1e7d34e52 
Findall method in cinderclient/base.py isn't very efficient: it loads
the entire list then filters on the Python side. When calling "cinder
show 'volName'" on a tenant holding a lot of volumes (> 1000) the run
time is too long.

On my env show command with 10000 volumes takes ~2 min, after apply
this patch few seconds.

Closes-Bug: #1449444
Change-Id: I23070d94d5bb100b2dd8677f67d7c8b1e7d34e52
Added type description for volume type client 2014-12-17T15:27:38+00:00 Gloria Gu gloria.gu@hp.com 2014-10-31T18:11:24+00:00 bc2b8bf1be95a8f45eca57e1f75dcc5f6504873a This patch added client handling and unit tests for volume type description: * Added 2 client methods for volume type. default: to get the default volume type update: to upate an existing volume type to update description * Added 2 new command-line operations. type-update (adminitrator only) type-default * type-list should display description. * type-create should have an option for entering the description. The corresponding cinder APIs change volume-type-description: https://review.openstack.org/#/c/131871/ Implements: blueprint volume-type-description Change-Id: I2735d7050d90589d19f45e21096577febdcca8bb 
This patch added client handling and unit tests for volume type description:

* Added 2 client methods for volume type.
  default: to get the default volume type
  update: to upate an existing volume type to update description

* Added 2 new command-line operations.
  type-update (adminitrator only)
  type-default

* type-list should display description.

* type-create should have an option for entering the description.

The corresponding cinder APIs change volume-type-description:
https://review.openstack.org/#/c/131871/

Implements: blueprint volume-type-description
Change-Id: I2735d7050d90589d19f45e21096577febdcca8bb
List all the request items when the list is over osapi_max_limit 2014-12-04T02:20:59+00:00 Vincent Hou sbhou@cn.ibm.com 2014-11-13T08:19:28+00:00 592099475c5c02d281abe036b0a4fa1d6a0a6473 Convert the function _list into a loop function, which can retrieve the items from the next link till the limit or the end of items has been reached. This works for v2 only. So far, only volume list in v2 support limit. The limit parameter work for volume list in v2 only, but other list can extend it in future work. Change-Id: I011f0ed1a4ab639f67db6cae580d978c0b44c1bb closes-bug: #1342192 
Convert the function _list into a loop function, which can retrieve
the items from the next link till the limit or the end of items has
been reached. This works for v2 only.

So far, only volume list in v2 support limit. The limit parameter
work for volume list in v2 only, but other list can extend it in
future work.

Change-Id: I011f0ed1a4ab639f67db6cae580d978c0b44c1bb
closes-bug: #1342192
Remove Python 2.4 compat shim 2014-09-19T14:35:35+00:00 Eric Harney eharney@redhat.com 2014-09-19T14:30:29+00:00 5bf13e1e2bb508468dc3f8f042d94022f179c475 It's clear that we aren't testing against Python 2.4 (not supported by dependencies like six) and no other client projects have this, so we should drop it. Change-Id: I14108964c0261d9144ced16cee7101d14ca7e644 
It's clear that we aren't testing against Python 2.4 (not
supported by dependencies like six) and no other client
projects have this, so we should drop it.

Change-Id: I14108964c0261d9144ced16cee7101d14ca7e644
Reuse Resource from oslo 2014-04-04T07:36:06+00:00 Andrey Kurilin akurilin@mirantis.com 2014-01-08T09:38:47+00:00 14e244f0e90a839857ca6b8c25f950463ac75f1f Class Resource from oslo is equal to code from cinderclient. In the process of unification of the clients code we should reuse common functionality from Oslo. Related to blueprint common-client-library-2 Change-Id: If39e49ff739d659d145725966192acf81975c90c 
Class Resource from oslo is equal to code from cinderclient.
In the process of unification of the clients code we should
reuse common functionality from Oslo.

Related to blueprint common-client-library-2

Change-Id: If39e49ff739d659d145725966192acf81975c90c
Fix typo in cinderclient 2013-11-28T01:28:05+00:00 huangtianhua huangtianhua@huawei.com 2013-11-25T10:08:01+00:00 5aaa68f09e4457b78ef08e9bdb1476fc982392b0 sematics --> semantics hypen-separated --> hyphen-separated typicaly --> typically Change-Id: I5df277ef7036082d0e4b079c23d41da809e5270f Closes-Bug: #1254587 
sematics --> semantics
hypen-separated --> hyphen-separated
typicaly --> typically

Change-Id: I5df277ef7036082d0e4b079c23d41da809e5270f
Closes-Bug: #1254587
Enable del of other tenants resources by name 2013-10-29T16:12:22+00:00 Jay S. Bryant jsbryant@us.ibm.com 2013-10-25T16:43:46+00:00 8a6a291e033e0d191ac8702f05fa3e83206d61f0 Currently, due to the way that resources are being retrieved by the findall() function, an administrator can do a list, snapshot-list, etc. with the --all_tenants option and see other tenants' resources. If the admin then tries to delete the another tenants' resource by name, it fails with a 'No <resource> with a name or ID of <name> exists.' error. The solution to this is to change the call to the list() function in findall() to set the all_tenants search option to 1. This causes the admin to get a list of all the resources that they have access to back when the search is done instead of just a list of their resources. The delete by name is then possible. The server takes care of ensuring that only resources that the user has access to are returned. This will enable delete by name for all resources that use the find_resource function. Closes-bug: 1241682 Change-Id: I4e9957b66c11b7e1081f066d189cedc5a3cb2a6c 
Currently, due to the way that resources are being retrieved by the
findall() function, an administrator can do a list, snapshot-list, etc.
with the --all_tenants option and see other tenants' resources.  If the
admin then tries to delete the another tenants' resource by name, it fails
with a 'No <resource> with a name or ID of <name> exists.' error.

The solution to this is to change the call to the list() function in
findall() to set the all_tenants search option to 1.  This causes the
admin to get a list of all the resources that they have access to back
when the search is done instead of just a list of their resources.  The
delete by name is then possible.  The server takes care of ensuring that
only resources that the user has access to are returned.

This will enable delete by name for all resources that use the find_resource
function.

Closes-bug: 1241682
Change-Id: I4e9957b66c11b7e1081f066d189cedc5a3cb2a6c
python3: Refactor dict for python2/python3 compat 2013-10-11T13:04:49+00:00 Chuck Short chuck.short@canonical.com 2013-10-07T02:39:41+00:00 b0b8afaf55ffdadf5ee329edd92b9cac1be8c2d1 Python3 changed the behavior of dict.keys such that it is now returns a dict_keys object, which is iterable but not indexable. You can get the python2 result back with an explicit call to list. Refactor list(*.keys()) so that it just uses list(). Change-Id: Ib2e9646ac967e9bd7cc4f47e2099f5d1358808a9 Signed-off-by: Chuck Short <chuck.short@canonical.com> 
Python3 changed the behavior of dict.keys such that it is now
returns a dict_keys object, which is iterable but not indexable.
You can get the python2 result back with an explicit call to list.

Refactor list(*.keys()) so that it just uses list().

Change-Id: Ib2e9646ac967e9bd7cc4f47e2099f5d1358808a9
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Replace OpenStack LLC with OpenStack Foundation 2013-09-28T15:13:54+00:00 ZhiQiang Fan aji.zqfan@gmail.com 2013-09-19T19:31:42+00:00 5ad95e9fd236a1f27cbcf1105494d6680a7d8ffe NOTE: * openstack/common/* should be synced from oslo, so i leave them untouched. * add (c) symbol for related lines, leave others untouched. Change-Id: I46a87c7f248d3468b1fdf5661411962faf2fb875 Fixes-Bug: #1214176 
NOTE:
* openstack/common/* should be synced from oslo, so i leave them
untouched.
* add (c) symbol for related lines, leave others untouched.

Change-Id: I46a87c7f248d3468b1fdf5661411962faf2fb875
Fixes-Bug: #1214176
Revert "Use exceptions from oslo" 2013-07-15T16:30:05+00:00 John Griffith john.griffith@solidfire.com 2013-07-15T16:25:40+00:00 3d30126e93b66488b5c680578f6078201cdedc15 This reverts commit a7cce08eab5e2e42275b84bd56127bd09b00f5bf Change-Id: I6c0047adbc33d0d6b5890f11853974578c36c78c 
This reverts commit a7cce08eab5e2e42275b84bd56127bd09b00f5bf

Change-Id: I6c0047adbc33d0d6b5890f11853974578c36c78c