delta/openstack/python-ceilometerclient.git/ceilometerclient/tests, branch stable/icehouse

Merge "Reduce redundant parameter of some commands in CLI"

2014-09-20T00:01:45+00:00

Reduce redundant parameter of some commands in CLI

2014-09-19T13:01:38+00:00

When deleting an alarm, we use "ceilometer alarm-delete -a ",
unlike other deleting commands of openstack, the parameter-a/--alarm_id
is redundant. The similar situations exist in showing alarm, geting alarm
state, showing resource and so on.
It is more easy to use for reducing these parameters.

New behaviour:

$ ceilometer help alarm-show
usage: ceilometer alarm-show []

Show an alarm.

Positional arguments:
    ID of the alarm to show.

$ ceilometer alarm-show
alarm_id should not be empty

$ ceilometer alarm-show abcde
Not Found (HTTP 404)

$ ceilometer alarm-show -a abcde
-a is obsolete! See help for more details.
Not Found (HTTP 404)

$ ceilometer alarm-show --alarm_id abcde
--alarm_id is obsolete! See help for more details.
Not Found (HTTP 404)

Co-Authored-By: Nejc Saje 
Change-Id: I1fbc85aa253929bfbb5e73ed834a725b9cf828b4
Closes-bug: #1268557

Merge "Verify alarm found before modifying"

2014-09-13T07:18:03+00:00

Fix sample-create in v2 api calls

2014-09-10T20:02:31+00:00

A dict embedded in a list is the expected input. In
47934c777c50897b649793e0960eebdaad322c45 the list was lost, this
puts it back.

Note that the _exact_ date of this failure was identified by
existing Rally jobs which started failing in early August. That made
searching the commit logs straightforward.

Change-Id: I37e794de7a23b8ce8e67a086732af5a19f182409
Closes-Bug: #1367867

Verify alarm found before modifying

2014-08-29T14:04:30+00:00

Current behavior is to retrieve alarm by id and conduct operations on the
object.  If the tenant doesn't own the alarm or isn't admin, the user will
receive the message: 'NoneType' object has no attribute 'to_dict'

Above message doesn't provide any useful diagnostic information and indicates a
programming error since an unexpected None-type is encountered and not handled.

This change verifies the alarm is found before using the object.  If alarm not
found it prints the same message for a not found Alarm as other PUT operations
like alarm-state-set:  Alarm not found: .

This message is more useful for diagnosis and gets rid of the uncaught
None-type error.

Change-Id: I66abcd4498b24ac7cadcf29fe3ced3fcda08458c
Closes-Bug: #1348387

Merge "Check if the alarm has time constraints field before displaying"

2014-08-28T18:40:33+00:00

Check if the alarm has time constraints field before displaying

2014-08-25T08:56:16+00:00

Fixes the bug that broke the alarms CLI if the alarm didn't have
a time constraints field.

Reduces code duplication of alarm printing code, so now all the alarm
printing code is actually tested.

Renames some auxiliary methods for more clarity.

Change-Id: Ib691b4a5a6cf5ae133cd0a5576f90e4d0d189a92
Closes-bug: #1316390

Replace assertTrue with assertIsNotNone for check an object

2014-08-11T17:38:53+00:00

assertTrue(*) means to check whether a boolean value/expression
is true or not. For checking an object is not None, we should use
assertIsNotNone(*), which gives more explicit expression.

Change-Id: Ia4d0dcec81e97fe4774bff4e41a017f00b899ef3
Closes-Bug: #1297156

Use HTTPClient from common Oslo code

2014-07-31T15:59:58+00:00

In the process of unification of the clients code we should
reuse common functionality from Oslo.

bp common-client-library-2

Change-Id: I0e027c33ee42b6de032d33269caeea33e7837f40

Merge "Avoid empty entity field in uri path"

2014-07-24T12:32:23+00:00