<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/python-ceilometerclient.git/ceilometerclient/tests/unit, branch 2.9.1</title>
<subtitle>opendev.org: openstack/python-ceilometerclient.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/'/>
<entry>
<title>panko redirect</title>
<updated>2017-01-11T23:11:36+00:00</updated>
<author>
<name>gord chung</name>
<email>gord@live.ca</email>
</author>
<published>2017-01-11T22:52:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=72ea5ef82461d12644f0be6b80ac7dd07a4a2cec'/>
<id>72ea5ef82461d12644f0be6b80ac7dd07a4a2cec</id>
<content type='text'>
same as aodh but with panko_endpoint

Change-Id: Iae7d60e1cf139b79e74caf81ed7bdbd0bf2bc473
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
same as aodh but with panko_endpoint

Change-Id: Iae7d60e1cf139b79e74caf81ed7bdbd0bf2bc473
</pre>
</div>
</content>
</entry>
<entry>
<title>cleanup aodh mocks</title>
<updated>2017-01-11T23:01:47+00:00</updated>
<author>
<name>gord chung</name>
<email>gord@live.ca</email>
</author>
<published>2017-01-11T23:01:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=45f4f9584bb46e1d7f47d32ac9cfaab04a209d34'/>
<id>45f4f9584bb46e1d7f47d32ac9cfaab04a209d34</id>
<content type='text'>
don't pass in arg we don't use

Change-Id: I14b9cd3178f929aa878f5caff97a6ba4318a42a0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
don't pass in arg we don't use

Change-Id: I14b9cd3178f929aa878f5caff97a6ba4318a42a0
</pre>
</div>
</content>
</entry>
<entry>
<title>move old oslo-incubator code out of openstack/common</title>
<updated>2016-11-05T00:18:45+00:00</updated>
<author>
<name>Steve Martinelli</name>
<email>s.martinelli@gmail.com</email>
</author>
<published>2016-10-29T16:05:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=c1141ed5be72ee169a7640b5d4957bfe02ad37ce'/>
<id>c1141ed5be72ee169a7640b5d4957bfe02ad37ce</id>
<content type='text'>
As part of the first community-wide goal, teams were asked
to remove the openstack/common package of their projects
if one existed. This was a byproduct of the old oslo-incubator
form of syncing common functionality.

The package, apiclient, was moved to a top level location
and a new i18n module was created. There is no oslo.apiclient
library or equivalent, the recommended solution is to move it
in tree and maintain it there.

Change-Id: Ia788313e0926dc872a87b090ef0a350898bfb079
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As part of the first community-wide goal, teams were asked
to remove the openstack/common package of their projects
if one existed. This was a byproduct of the old oslo-incubator
form of syncing common functionality.

The package, apiclient, was moved to a top level location
and a new i18n module was created. There is no oslo.apiclient
library or equivalent, the recommended solution is to move it
in tree and maintain it there.

Change-Id: Ia788313e0926dc872a87b090ef0a350898bfb079
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixes SSLError during cclient.meters.list() by https</title>
<updated>2016-10-17T12:16:53+00:00</updated>
<author>
<name>Ekaterina Khripunova</name>
<email>e.khripunova@gmail.com</email>
</author>
<published>2016-10-17T09:24:25+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=5328c3168a7ed011fc2c6ac16ba8f8e4f9c5e380'/>
<id>5328c3168a7ed011fc2c6ac16ba8f8e4f9c5e380</id>
<content type='text'>
    The problem causes the function _adjust_kwargs(kwargs) which creates
    a new dict client_kwargs with new-named keys. It gets 'os_insecure' key
    from kwargs and gives it key-name 'insecure'.
    But the bug is in using kwargs.get('insecure') &lt;which is None&gt; to
    produse value of 'verify'.

Change-Id: If77b2d3c75beddcd1a0a82353b56c84b29184ec7
Closes-Bug: 1634027
Related-Bug: 1394449
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
    The problem causes the function _adjust_kwargs(kwargs) which creates
    a new dict client_kwargs with new-named keys. It gets 'os_insecure' key
    from kwargs and gives it key-name 'insecure'.
    But the bug is in using kwargs.get('insecure') &lt;which is None&gt; to
    produse value of 'verify'.

Change-Id: If77b2d3c75beddcd1a0a82353b56c84b29184ec7
Closes-Bug: 1634027
Related-Bug: 1394449
</pre>
</div>
</content>
</entry>
<entry>
<title>Set code and details on HTTPException</title>
<updated>2016-10-07T12:19:23+00:00</updated>
<author>
<name>Mehdi Abaakouk</name>
<email>sileht@redhat.com</email>
</author>
<published>2016-10-06T14:39:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=b8a78396b273c23ba7a633d98365a5dfc969b1f2'/>
<id>b8a78396b273c23ba7a633d98365a5dfc969b1f2</id>
<content type='text'>
Even the HTTPException is unknown for ceilometer we should set the code
and print it with the details.

Closes-bug: #1626404
Change-Id: Ib244d8822f7a1ebc1b8ec1b95d13b20bbb69ece0
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Even the HTTPException is unknown for ceilometer we should set the code
and print it with the details.

Closes-bug: #1626404
Change-Id: Ib244d8822f7a1ebc1b8ec1b95d13b20bbb69ece0
</pre>
</div>
</content>
</entry>
<entry>
<title>Using assertIsNone() instead of assertEqual(None)</title>
<updated>2016-09-27T02:14:00+00:00</updated>
<author>
<name>Anh Tran</name>
<email>anhtt@vn.fujitsu.com</email>
</author>
<published>2016-09-27T02:11:44+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=6ed98bd6d67e730fc7dc652dcb020b2883e49916'/>
<id>6ed98bd6d67e730fc7dc652dcb020b2883e49916</id>
<content type='text'>
Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None)

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: Iae83c4360336cf07b6045615ff38933f52844499
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Following OpenStack Style Guidelines[1]:
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None)

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: Iae83c4360336cf07b6045615ff38933f52844499
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace assertEqual(None, ...) with assertIsNone(...)</title>
<updated>2016-09-19T16:59:53+00:00</updated>
<author>
<name>Hanxi Liu</name>
<email>hanxi.liu@easystack.cn</email>
</author>
<published>2016-09-19T15:11:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=1c53f7d09837dc670e00886e201152e05084ed14'/>
<id>1c53f7d09837dc670e00886e201152e05084ed14</id>
<content type='text'>
From OpenStack Style Guidelines [1], [H203] Use assertIs(Not)None to
check for None.

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: Ib60e025af418678884d9bea91e1c318b3aadf4c9
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
From OpenStack Style Guidelines [1], [H203] Use assertIs(Not)None to
check for None.

[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises

Change-Id: Ib60e025af418678884d9bea91e1c318b3aadf4c9
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix from_response method to process response from requests</title>
<updated>2016-09-07T09:45:25+00:00</updated>
<author>
<name>Andrey Kurilin</name>
<email>akurilin@mirantis.com</email>
</author>
<published>2016-09-07T09:39:12+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=1b1917ab9b56fe92235ce336d3df3e7a8c1c81d2'/>
<id>1b1917ab9b56fe92235ce336d3df3e7a8c1c81d2</id>
<content type='text'>
SessionClient uses requests library. It's response class doesn't have
"status" property[1], so in case of any errors(with status code &gt; 400),
from_response method is called and raises AttributeError.

Also, HTTPClient implementation uses requests lib by default[2](if 'http'
argument was not transmitted), so from_response method will raise
AttributeError too.

[1] - http://docs.python-requests.org/en/master/api/#requests.Response.status_code
[2] - https://github.com/openstack/python-ceilometerclient/blob/2.6.0/ceilometerclient/openstack/common/apiclient/client.py#L99-L100

Change-Id: Id8fb2f386e8101951716f30a6365c9aa15bd4b24
Closes-Bug: #1620974
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
SessionClient uses requests library. It's response class doesn't have
"status" property[1], so in case of any errors(with status code &gt; 400),
from_response method is called and raises AttributeError.

Also, HTTPClient implementation uses requests lib by default[2](if 'http'
argument was not transmitted), so from_response method will raise
AttributeError too.

[1] - http://docs.python-requests.org/en/master/api/#requests.Response.status_code
[2] - https://github.com/openstack/python-ceilometerclient/blob/2.6.0/ceilometerclient/openstack/common/apiclient/client.py#L99-L100

Change-Id: Id8fb2f386e8101951716f30a6365c9aa15bd4b24
Closes-Bug: #1620974
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "Correct the parameters's position of assertEqual"</title>
<updated>2016-08-08T15:20:45+00:00</updated>
<author>
<name>Jenkins</name>
<email>jenkins@review.openstack.org</email>
</author>
<published>2016-08-08T15:20:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=7c6cc05ff0e9e95313384303deee69ef11929bc1'/>
<id>7c6cc05ff0e9e95313384303deee69ef11929bc1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Correct the parameters's position of assertEqual</title>
<updated>2016-07-29T03:08:36+00:00</updated>
<author>
<name>xiaozhuangqing</name>
<email>zhuangqing.xiao@easystack.cn</email>
</author>
<published>2016-07-29T02:47:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/python-ceilometerclient.git/commit/?id=481cd7d33bf5f91c39888fa695238c562eda7945'/>
<id>481cd7d33bf5f91c39888fa695238c562eda7945</id>
<content type='text'>
assertEqual using should be assertEqual(expected, actual)

misplace have two impacts:
1.giving confusing messages when some tests failed.
2.mislead other developer,new test modules may follow these wrong pattern

see Partial-Bug  https://bugs.launchpad.net/oslo.config/+bug/1604213

Change-Id: I4467d5efb1eed9f4c473c947c93afcfaf9be6ea6
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
assertEqual using should be assertEqual(expected, actual)

misplace have two impacts:
1.giving confusing messages when some tests failed.
2.mislead other developer,new test modules may follow these wrong pattern

see Partial-Bug  https://bugs.launchpad.net/oslo.config/+bug/1604213

Change-Id: I4467d5efb1eed9f4c473c947c93afcfaf9be6ea6
</pre>
</div>
</content>
</entry>
</feed>
