From 3fdfb00bc7c3656786d80b1c4881d016d0b86550 Mon Sep 17 00:00:00 2001 From: Ghanshyam Mann Date: Tue, 12 May 2020 18:27:17 -0500 Subject: Fix hacking min version to 3.0.1 flake8 new release 3.8.0 added new checks and gate pep8 job start failing. hacking 3.0.1 fix the pinning of flake8 to avoid bringing in a new version with new checks. Though it is fixed in latest hacking but 2.0 and 3.0 has cap for flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also break the pep8 job if new check are added. To avoid similar gate break in future, we need to bump the hacking min version. Also removing the hacking and other related dep from lower-constraints file as theose are blacklisted requirements and does not need to be present there. - http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html Change-Id: Ib3d13c83dcc9f660d89669c53c7782ca68da8e64 --- lower-constraints.txt | 4 ---- test-requirements.txt | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lower-constraints.txt b/lower-constraints.txt index d120b45..3d81a75 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -7,9 +7,7 @@ docutils==0.11 dulwich==0.15.0 extras==1.0.0 fixtures==3.0.0 -flake8==2.2.4 flake8-docstrings==0.2.1.post1 -hacking==0.10.3 imagesize==0.7.1 iso8601==0.1.11 Jinja2==2.10 @@ -31,8 +29,6 @@ oslo.utils==3.33.0 oslotest==3.2.0 pbr==2.0.0 pep257==0.7.0 -pep8==1.5.7 -pyflakes==0.8.1 Pygments==2.2.0 pyparsing==2.1.0 python-mimeparse==1.6.0 diff --git a/test-requirements.txt b/test-requirements.txt index c1d3c32..c6b0ddb 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -2,7 +2,7 @@ # of appearance. Changing the order has an impact on the overall integration # process, which may cause wedges in the gate later. # Hacking already pins down pep8, pyflakes and flake8 -hacking>=3.0,<3.1.0 # Apache-2.0 +hacking>=3.0.1,<3.1.0 # Apache-2.0 flake8-docstrings==0.2.1.post1 # MIT coverage!=4.4,>=4.0 # Apache-2.0 -- cgit v1.2.1