From d49d5944824f15d00e04e1b9c7f8c3b03b440c95 Mon Sep 17 00:00:00 2001 From: Brian Rosmaita Date: Fri, 11 Nov 2022 16:14:47 -0500 Subject: [imageutils] Fix __str__ for QemuImgInfo Code is calling 'appened' on a list; correct this to 'append'. Closes-bug: #1996426 Change-Id: I8729cf180f92f43519c942e22f3b285377a5612f --- oslo_utils/imageutils.py | 2 +- oslo_utils/tests/test_imageutils.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/oslo_utils/imageutils.py b/oslo_utils/imageutils.py index 4808091..e3951d1 100644 --- a/oslo_utils/imageutils.py +++ b/oslo_utils/imageutils.py @@ -100,7 +100,7 @@ class QemuImgInfo(object): if self.encrypted: lines.append("encrypted: %s" % self.encrypted) if self.format_specific: - lines.appened("format_specific: %s" % self.format_specific) + lines.append("format_specific: %s" % self.format_specific) return "\n".join(lines) def _canonicalize(self, field): diff --git a/oslo_utils/tests/test_imageutils.py b/oslo_utils/tests/test_imageutils.py index 5705ca8..952e067 100644 --- a/oslo_utils/tests/test_imageutils.py +++ b/oslo_utils/tests/test_imageutils.py @@ -264,6 +264,9 @@ class ImageUtilsJSONTestCase(test_base.BaseTestCase): self.assertEqual(13168640, image_info.disk_size) self.assertEqual("bar", image_info.format_specific["data"]["foo"]) self.assertEqual('yes', image_info.encrypted) + # test for Bug #1996426 + expected_str = "format_specific: {'data': {'foo': 'bar'}}" + self.assertIn(expected_str, str(image_info)) @mock.patch("debtcollector.deprecate") def test_qemu_img_info_blank(self, mock_deprecate): -- cgit v1.2.1