diff options
author | Claudiu Belu <cbelu@cloudbasesolutions.com> | 2016-06-13 08:29:47 +0300 |
---|---|---|
committer | Claudiu Belu <cbelu@cloudbasesolutions.com> | 2016-06-23 19:53:29 +0300 |
commit | eacdbc3d8e9042c584c751d599da59ddcaf98a1c (patch) | |
tree | dea4a4f2e4a0b87666e867471d699e748c35cd1e /nova/tests/unit/policy_fixture.py | |
parent | d8891f8d45346ec94e253c77868130d79cb921fa (diff) | |
download | nova-eacdbc3d8e9042c584c751d599da59ddcaf98a1c.tar.gz |
policy: Add defaults in code (part 1)
Adds default values for policy rules in code and removes
them from etc/policy.json file. The change is validated
by the nova.tests.unit.test_policy unit tests.
Adds default policy rules in policy_fixture. The policy_fixture
is currently loading an incomplete set of policy rules (from
policy.json or fake_policy), resulting in unit tests running
with an incomplete set of policy rules.
Co-Authored-By: Andrew Laski <andrew@lascii.com>
Partially-Implements: bp policy-in-code
Change-Id: I7a7dc2a111d536380a763169320a0820b0715a11
Diffstat (limited to 'nova/tests/unit/policy_fixture.py')
-rw-r--r-- | nova/tests/unit/policy_fixture.py | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/nova/tests/unit/policy_fixture.py b/nova/tests/unit/policy_fixture.py index df2c9c5800..b112ac1a9e 100644 --- a/nova/tests/unit/policy_fixture.py +++ b/nova/tests/unit/policy_fixture.py @@ -21,6 +21,7 @@ import six import nova.conf from nova.conf import paths +from nova import policies import nova.policy from nova.tests.unit import fake_policy @@ -57,6 +58,18 @@ class RealPolicyFixture(fixtures.Fixture): policy = nova.policy._ENFORCER policy.set_rules(oslo_policy.Rules.from_dict(rules)) + def add_missing_default_rules(self, rules): + """Adds default rules and their values to the given rules dict. + + The given rulen dict may have an incomplete set of policy rules. + This method will add the default policy rules and their values to + the dict. It will not override the existing rules. + """ + + for rule in policies.list_rules(): + if rule.name not in rules: + rules[rule.name] = rule.check_str + class PolicyFixture(RealPolicyFixture): """Load a fake policy from nova.tests.unit.fake_policy @@ -77,8 +90,12 @@ class PolicyFixture(RealPolicyFixture): self.policy_dir = self.useFixture(fixtures.TempDir()) self.policy_file = os.path.join(self.policy_dir.path, 'policy.json') + + # load the fake_policy data and add the missing default rules. + policy_rules = jsonutils.loads(fake_policy.policy_data) + self.add_missing_default_rules(policy_rules) with open(self.policy_file, 'w') as f: - f.write(fake_policy.policy_data) + jsonutils.dump(policy_rules, f) CONF.set_override('policy_dirs', [], group='oslo_policy') @@ -103,6 +120,7 @@ class RoleBasedPolicyFixture(RealPolicyFixture): with open(CONF.oslo_policy.policy_file) as fp: policy = fp.read() policy = jsonutils.loads(policy) + self.add_missing_default_rules(policy) # Convert all actions to require specified role for action, rule in six.iteritems(policy): |