delta/openstack/nova.git/nova/virt/imagecache.py, branch master opendev.org: openstack/nova.git Include removal of ephemeral backing files in the image cache manager 2020-10-09T11:24:06+00:00 Surya Seetharaman suryaseetharaman.9@gmail.com 2019-10-18T10:41:02+00:00 f44700935ff4cab7a36cc06356aefcf4c9b48880 If CONF.image_cache.remove_unused_base_images is True, the base and swap files are removed during the image cache manager's periodic task while the ephemeral backing files are never deleted. This is a long standing bug and this patch proposes to remove the ephemeral backing files in the same way as for the swap files. Change-Id: Ibf722265a4450fb81d40dee635667e39bc5b3edc Closes-bug: #1602193 
If CONF.image_cache.remove_unused_base_images is True, the base and
swap files are removed during the image cache manager's periodic
task while the ephemeral backing files are never deleted. This is a
long standing bug and this patch proposes to remove the ephemeral
backing files in the same way as for the swap files.

Change-Id: Ibf722265a4450fb81d40dee635667e39bc5b3edc
Closes-bug: #1602193
Reserve DISK_GB resource for the image cache 2020-05-19T15:47:50+00:00 Balazs Gibizer balazs.gibizer@est.tech 2020-05-15T13:00:20+00:00 89fe504abfbd41a9c37f9b544c0ce98b23b45799 If the nova compute image cache is on the same disk as the instance directory then the images in the cache will consume the same disk resource as the nova instances which can lead to disk overallocation. This patch adds a new config option [workarounds]/reserve_disk_resource_for_image_cache . If it is set the libvirt driver will reserve DISK_GB resources in placement for the actual size of the image cache. This is a low complexity solution with known limitations: * Reservation is updated long after the image is downloaded * This code allows the reservation to push the provider into negative available resource if the reservation + allocations exceed the total inventory. Change-Id: If874f018ea996587e178219569c2903c2ee923cf Closes-Bug: #1878024 
If the nova compute image cache is on the same disk as the instance
directory then the images in the cache will consume the same disk
resource as the nova instances which can lead to disk overallocation.

This patch adds a new config option
[workarounds]/reserve_disk_resource_for_image_cache . If it is set the
libvirt driver will reserve DISK_GB resources in placement for the
actual size of the image cache.

This is a low complexity solution with known limitations:
* Reservation is updated long after the image is downloaded
* This code allows the reservation to push the provider into negative
available resource if the reservation + allocations exceed the total
inventory.

Change-Id: If874f018ea996587e178219569c2903c2ee923cf
Closes-Bug: #1878024
Consolidate [image_cache] conf options 2019-11-13T17:09:03+00:00 Eric Fried openstack@fried.cc 2019-10-23T19:41:36+00:00 828e8047e5c8651ea757bda7922670889d5e8818 Blueprint image-precache-support added a conf section called [image_cache], so it makes sense to move all the existing image cache-related conf options into it. Old: [DEFAULT]image_cache_manager_interval [DEFAULT]image_cache_subdirectory_name [DEFAULT]remove_unused_base_images [DEFAULT]remove_unused_original_minimum_age_seconds [libvirt]remove_unused_resized_minimum_age_seconds New: [image_cache]manager_interval [image_cache]subdirectory_name [image_cache]remove_unused_base_images [image_cache]remove_unused_original_minimum_age_seconds [image_cache]remove_unused_resized_minimum_age_seconds Change-Id: I3c49825ac0d70152b6c8ee4c8ca01546265f4b80 Partial-Bug: #1847302 
Blueprint image-precache-support added a conf section called
[image_cache], so it makes sense to move all the existing image
cache-related conf options into it.

Old:
[DEFAULT]image_cache_manager_interval
[DEFAULT]image_cache_subdirectory_name
[DEFAULT]remove_unused_base_images
[DEFAULT]remove_unused_original_minimum_age_seconds
[libvirt]remove_unused_resized_minimum_age_seconds

New:
[image_cache]manager_interval
[image_cache]subdirectory_name
[image_cache]remove_unused_base_images
[image_cache]remove_unused_original_minimum_age_seconds
[image_cache]remove_unused_resized_minimum_age_seconds

Change-Id: I3c49825ac0d70152b6c8ee4c8ca01546265f4b80
Partial-Bug: #1847302
Rename ImageCacheManager._list_base_images to _scan_base_images 2016-05-26T13:45:42+00:00 Matthew Booth mbooth@redhat.com 2016-05-26T09:06:54+00:00 cb15d34cc1caf980c636eace5cae0be2b1b5108f The method's return value is never used, only its side-effects are used. We rename it to reflect its actual usage, and remove the unused return value to avoid confusion. NOTE(mdbooth): The use of global state is a large part of what makes ImageCacheManager hard to read. I don't mean to imply with this change that's what should be done here, only to make it clearer to the reader that it is what's being done currently. Change-Id: Ic82f6d4f00fd1226673750538019339937a623bc 
The method's return value is never used, only its side-effects are
used. We rename it to reflect its actual usage, and remove the unused
return value to avoid confusion.

NOTE(mdbooth): The use of global state is a large part of what makes
ImageCacheManager hard to read. I don't mean to imply with this change
that's what should be done here, only to make it clearer to the reader
that it is what's being done currently.

Change-Id: Ic82f6d4f00fd1226673750538019339937a623bc
Remove all references to image_popularity from image cache 2016-05-26T13:44:51+00:00 Matthew Booth mbooth@redhat.com 2016-05-26T09:28:33+00:00 d661db6a990138125db27aff757181a5ba9e971b Nothing ever reads it. Change-Id: Ieeb068b992263cf0208c2d8dc3a8d6f0683bf18c 
Nothing ever reads it.

Change-Id: Ieeb068b992263cf0208c2d8dc3a8d6f0683bf18c
Config options: Centralize netconf options 2016-04-24T18:15:05+00:00 Pushkar Umaranikar pushkar.umaranikar@intel.com 2016-03-17T20:30:39+00:00 d619ad6ba15df1cf7dc92ddf84d1c65af018682f The config options of the section "nova/netconf" got moved to the new central location "nova/conf/netconf.py" Change-Id: I8a17b6f00b15e03de55385fc0206bdc82441304a Depends-On: I0da2ad7daa942b85c3395dc4861c6e18368ece88 Implements: blueprint centralize-config-options-newton 
The config options of the section
"nova/netconf" got moved to the
new central location
"nova/conf/netconf.py"

Change-Id: I8a17b6f00b15e03de55385fc0206bdc82441304a
Depends-On: I0da2ad7daa942b85c3395dc4861c6e18368ece88
Implements: blueprint centralize-config-options-newton
config options: Centralise 'virt.imagecache' options 2016-03-30T11:47:53+00:00 Stephen Finucane stephen.finucane@intel.com 2016-01-14T10:44:05+00:00 1154923f8e218162222353b40e1ada9e664e40ef Add options from 'virt.imagecache'. These options are part of the 'DEFAULT' group but are included in the "nova.conf.virt" file in hope that they can eventually be moved to their own group. Change-Id: I0e683c08b0479e41487c6b05de7d588f5d88ad0e Implements: bp centralize-config-options-newton 
Add options from 'virt.imagecache'. These options are part of the
'DEFAULT' group but are included in the "nova.conf.virt" file in hope
that they can eventually be moved to their own group.

Change-Id: I0e683c08b0479e41487c6b05de7d588f5d88ad0e
Implements: bp centralize-config-options-newton
Reduce number of db calls during image cache manager periodic task 2016-03-28T08:57:56+00:00 Hans Lindgren hanlind@kth.se 2016-03-26T18:58:49+00:00 990eafe4c40e736744494624ca06d137ff6d49ea Make a single db call to get bdms for all instances instead of one call per instance. Change-Id: I74864b398f2d17a24b9ed676945183401e9872a0 Closes-Bug: #1484847 
Make a single db call to get bdms for all instances instead of one
call per instance.

Change-Id: I74864b398f2d17a24b9ed676945183401e9872a0
Closes-Bug: #1484847
Switch to using oslo_* instead of oslo.* 2015-02-06T11:03:10+00:00 Davanum Srinivas dims@linux.vnet.ibm.com 2015-01-11T03:26:32+00:00 af2d6c9576b1ac5f3b3768870bb15d9b5cf1610b The oslo team is recommending everyone to switch to the non-namespaced versions of libraries. Updating the hacking rule to include a check to prevent oslo.* import from creeping back in. This commit includes: - using oslo_utils instead of oslo.utils - using oslo_serialization instead of oslo.serialization - using oslo_db instead of oslo.db - using oslo_i18n instead of oslo.i18n - using oslo_middleware instead of oslo.middleware - using oslo_config instead of oslo.config - using oslo_messaging instead of "from oslo import messaging" - using oslo_vmware instead of oslo.vmware Change-Id: I3e2eb147b321ce3e928817b62abcb7d023c5f13f 
The oslo team is recommending everyone to switch to the
non-namespaced versions of libraries. Updating the hacking
rule to include a check to prevent oslo.* import from
creeping back in.

This commit includes:
- using oslo_utils instead of oslo.utils
- using oslo_serialization instead of oslo.serialization
- using oslo_db instead of oslo.db
- using oslo_i18n instead of oslo.i18n
- using oslo_middleware instead of oslo.middleware
- using oslo_config instead of oslo.config
- using oslo_messaging instead of "from oslo import messaging"
- using oslo_vmware instead of oslo.vmware

Change-Id: I3e2eb147b321ce3e928817b62abcb7d023c5f13f
image cache clean-up to clean swap disk 2014-11-11T07:27:40+00:00 jichenjc jichenjc@cn.ibm.com 2014-10-29T01:36:58+00:00 7252839c9ecbdfc01342a940ed43aed5f1377a7a Currently swap backing files are never removed from the system. The image clean-up code should recognise at least obsolete unused files need to be removed. Change-Id: I09519a73c7233f2dc6f46f6cd094a3e1cc3dc395 Partial-Bug: 1253991a 
Currently swap backing files are never removed from the system.
The image clean-up code should recognise at least obsolete unused files
need to be removed.

Change-Id: I09519a73c7233f2dc6f46f6cd094a3e1cc3dc395
Partial-Bug: 1253991a