The InstanceMapping user_id field is a new, non-nullable field representing the user_id for the instance. When new instance create requests come in, we create the instance mapping. We will set user_id here before creating the record. Some virtual interface online data migration and map_instances routine create InstanceMapping records and since the user_id field did not previously exist, they were not setting it. We will populate user_id in these cases. Finally, whenever an API does a compute_api.get(), we can opportunistically set and save user_id on the instance mapping if it is not set. Part of blueprint count-quota-usage-from-placement Change-Id: Ic4bb7b49b90a3d6d7ce6c6c62d87836f96309f06
In change [1] we modified _heal_instance_info_cache periodic task to use Neutron point of view while rebuilding InstanceInfoCache objects. The crucial point was how we know the previous order of ports, if the cache was broken. We decided to use VirtualInterfaceList objects as source of port order. For instances older than Newton VirtualInterface objects doesn't exist, so we need to introduce a way of creating it. This script should be executed while upgrading to Stein release. [1] https://review.openstack.org/#/c/591607 Change-Id: Ic26d4ce3d071691a621d3c925dc5cd436b2005f1 Related-Bug: 1751923
nova/db/__init__.py was importing * from nova.db.api. This meant that any time any code anywhere within the nova.db package was imported then nova.db.api was too, leading to a cascade of imports that may not have been desired. Also, in general, code in __init__.py is a pain. Therefore, this change adjusts code that so that either: * nova.db.api is used directly * nova.db.api is imported as 'db' In either case, the functionality remains the same. The primary goal of this change was to make it possible to import the model files without having to import the db api. Moving the model files to a different place in the directory hierarchy was considered, but given that "code in __init__.py is a pain" this mode was chosen. This looks like a very large change, but it is essentially adjusting package names, many in mocks. Change-Id: Ic1fd7c87ceda05eeb96735da2a415ef37060bb1a
This adds a destroy() method for VirtualInterface which has not been required before but is now. Change-Id: Ie00f52153a816049f8efcc9aa8071371ce0b7e5a Related-Bug: #1602357
Neutron does not require global uniqueness for MAC addresses, but nova-network did. Since VirtualInterface was designed for n-net and is still used to enforce its requirements for such uniqueness, we can simply use the extra space in the address field to namespace our MAC address in neutron to avoid the constraint. We can hide this behavior in the object so nothing else needs to know, and we have 255 characters in the field, which is enough for a uuid and a mac address to fit. Closes-Bug: #1597770 Change-Id: I23480d98ca339c119100e8ab7df633ed8b80b1e9
I always have to check if the VirtualInterface.address field is an IP or a MAC address, so add a comment about what it is. Change-Id: I2fd31f2bcc00a0bba15b625c2d97f7d50e40e929
Adding a save method to the virtual_interface object and an update method to its database model. Partially implements blueprint virt-device-role-tagging Co-authored-by: Artom Lifshitz <alifshit@redhat.com> Change-Id: I52673fc297cb578995be5c7a075c5693b0793bf5
This patch series adds the ability for a user to specify a tag to be applied to a network interface or a disk when booting an instance. This tag is then exposed through the metadata API. For example, a user boots a VM with two network interfaces. One is connected to a private network, the other to the public Internet. There is currently no direct way to tell which interface is which. Specifying tags allows the user to distinguish between the two interfaces. This patch contains the database migration to add a 'tag' column to the virtual_interfaces and block_device_mapping tables as well as the corresponding change to the VirtualInterface and BlockDeviceMapping objects. Implements: blueprint virt-device-role-tagging Co-authored-by: Vladik Romanovsky <vromanso@redhat.com> Change-Id: Ic8be3de4e970116772f9b6ce01c55e26b829e6cb
Use enginefacade in 'vif' and 'task_log' sections. Implements: blueprint new-oslodb-enginefacade Co-Authored-By: Sergey Nikitin <snikitin@mirantis.com> Change-Id: I377e2b22eea0cc18d3727e8fb6e869d48c3608bc