Change [1] added new fields 'src|dst_supports_numa_live_migration'
to LibvirtLiveMigrateData object, but missed if condition for
dst_supports_numa_live_migration field in obj_make_compatible
method.

This change adds the if condition as well as fix typo in unit test
because of which this wasn't catched earlier.

Closes-Bug: #1975891
Change-Id: Ice5a2c7aca77f47ea6328a10d835854d9aff408e
(cherry picked from commit 3aa77a3999a7dcabbd4c0141d4c56b07a4624128)
(cherry picked from commit dfa05d62da441eeaf144e312cf33ba0e029452f0)
(cherry picked from commit 7c4059669c079787e5dbdc873a1cf767a95b2c54)

I8e349849db0b1a540d295c903f1470917b82fd97 has bumped MIN_LIBVIRT_VERSION
past this so remove the constant and associated logic.

Change-Id: I952f36fe201aad37297c7630ed562b579c90f64a

This is no longer used by anything.

Change-Id: I39231b18fc0efcddba43be59ad06591d0b551ec4
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

This patch contains the Nova object modifications that will eventually
enable NUMA live migration:

* (src|dst)_supports_numa_live_migration are added to
LibvirtLiveMigrateData. They will be used by the source and
destination hosts to signal to each other that they can perform a
NUMA-aware live migration.

* LibvirtLiveMigrateNUMAInfo is a new object that encodes how the
instance's NUMA-y things will fit on the destination host. It contains
things like the new CPU pins, the new NUMA cell pins, and the new
emulator thread pins.

* dst_numa_info is added to LibvirtLiveMigrateData. It contains a
LibvirtLiveMigrateNUMAInfo object. It will be set by the destination
and will be used by the source to update the instance's XML.

Implements blueprint numa-aware-live-migration
Change-Id: I7c7f54ab142f01808ee4b46d27b4a336e476cc77

The following methods have not been used any more
since the following change IDs or a commit.

* _add_vif_extension

  I56d859beb675199b209587bfe0a23cd9b75233ad

* _node_dict

  Ia76e41a8a3b7230701872ae7a1975edc3d9ea847

* _bdms_from_legacy and _bdms_to_legacy

  I01c108ceb539bb99491ed542c683e36fbf0c2bbe

* _create_block_device_mapping

  Ib0e0b708c46e4330e51f8f8fdfbb02d45aaf0f44

* _get_folder

  If734e22af223836b424561e8e9ca65e6c39fe5c2

* _details_map

  This method has not been used since the commit
  that added the method (initial commit).
  https://opendev.org/openstack/nova/commit/e7562217edf80afdb5ca8254b624c401f549ec1e

Change-Id: Ica00c013961366d044f5a4ad3ed24568d60288b3

As we now provide the original source bdms during rollback we can also
use them to reset any volume attachment ids to the ids used by the
source compute host.

Change-Id: Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0

This commit addresses some of the non-blocking comments/nits
in[1].

Main changes:
- Add 'source' property to InstancePCIRequest object
  which contains the source of the request i.e. flavor alias
  or neutron port. this avoids duplication of logic
  and comments in the code.

- Move class method create_skeleton_migrate_vifs from
  LiveMigrateData object to VIFMigrateData object as
  frankly its more sensible to have it there.

- Separate unit test, test__claim_pci_for_instance_vifs,
  to two separate unit tests for clarity.

- Some trivial nits and typos.

[1] https://review.opendev.org/#/c/620115/

Change-Id: I292a0e2d840bbf657ba6d0932f9a3decbcb2778f

Thorough replacement of git.openstack.org URLs with their opendev.org
counterparts.

Change-Id: I3e0af55e0707f04428a422b973d016ad30c82a12

This patch, builds on previous patches and enables
Live migration with SR-IOV indirect ports.

Prior to this change migration would have either:
  - Failed with instance running on the source node.
  - Failed with two VMs booted on both source and destination
    nodes, VM state is set to migrating, duplicate MACs on
    source and destination node and improper PCI resource claiming.
    This scenario is observed in the case of macvtap port type and
    neutron does not support multiple port binding API extension.
    With very little, non user friendly information in the log.

Conductor Changes:
- Allow live migration only with VIF related PCI devices to allow
  properly claiming PCI resources on the destination node.
  With this change live migration with generic flavor based
  PCI passthrough devices will not be supported due to libvirt and
  qemu constraint.

- Add a check to allow live migration with VIF related PCI allocation
  only when neutron supports multiple ports binding API extension
  and compute nodes are up to date.

- update the migrating VIF with the correct profile when binding the
  ports on the destination host, this will allow proper binding against
  the destination host and ensure VIF will be plugged correctly by Nova.

Compute Changes:
- Create VIFMigrateData for all VIFs in
  check_can_live_migrate_destination()

- For every VIF that contains a PCI device in its profile
  claim a PCI device on the destination node using the matching
  InstancePCIRequest of the instance being migrated.

- Update the relevant VIFMigrateData profile with the newly
  claimed PCI device.

- Free PCI devices on source and allocate on destination upon
  a successful migration or free claimed PCI devices on destination
  upon failure.

NeutronV2 Changes:
- Don't update binding profile with PCI devices if migration type is
  live-migration as the profile was already updated when an inactive
  port binding was created during bind_ports_to_host() call
  from conductor.

  Note: This builds on multiple ports binding API.

Change-Id: I734cc01dce13f9e75a16639faf890ddb1661b7eb
Partial-Implement: blueprint libvirt-neutron-sriov-livemigration