This was being called within the 'InstanceInfoCache' object. Remove it
in its entirety, given that nothing should be calling it now.

An 'update_cells' argument is removed from a number of functions as
these all resulted in a call to the cells v1 RPC API, a call that is now
removed.

Part of blueprint remove-cells-v1

Change-Id: Ia8da8cd040d104d745bd7adf20438b8eec558680
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

nova/db/__init__.py was importing * from nova.db.api. This meant that
any time any code anywhere within the nova.db package was imported
then nova.db.api was too, leading to a cascade of imports that may
not have been desired. Also, in general, code in __init__.py is a pain.

Therefore, this change adjusts code that so that either:

* nova.db.api is used directly
* nova.db.api is imported as 'db'

In either case, the functionality remains the same.

The primary goal of this change was to make it possible to import the
model files without having to import the db api. Moving the model files
to a different place in the directory hierarchy was considered, but
given that "code in __init__.py is a pain" this mode was chosen.

This looks like a very large change, but it is essentially adjusting
package names, many in mocks.

Change-Id: Ic1fd7c87ceda05eeb96735da2a415ef37060bb1a

The i18n team has decided not to translate the logs because it
seems like it not very useful; operators prefer to have them in
English so that they can search for those strings on the internet.

Partially fix on nova/keymgr, nova/network, nova/notifications,
nova/objects and nova/pci other paths will be fixed on next commits

Change-Id: Ie3a83fef0dc689b9d37ac43e047ce5d48f567adc

This changes over all occurrences of dictionary syntax on the
instance_info_cache object to use object syntax.

Change-Id: I87f4acf99a6fa8061e08f8a941f8f0c60e26c51f
Partially-Implements: bp rm-object-dict-compat-newton

Currently, a primitivized object is sent to sync to the API cell
in Instance.save because instance_update_at_top has not yet been
converted to handle objects. This change does the conversion and
makes Instance.save send an object for the sync.

This change should also address a race where deleting an instance
can result in an "undeleted" instance if an update from a child
occurs after the instance has been destroyed at the top, because
in instance_update_at_top() it uses read_deleted='yes' and
db.instance_update() will update all fields provided, unlike
objects which only update fields that have changed.

Closes-Bug: #1460350

Change-Id: I4e8c1a82a3c9c86038faa7f528b9dfb835f82ee6

In oslo.versionedobjects, the registry is opt-in instead of implicit.
This patch sets the stage for moving to that by defining a no-op
registry with a compatible register method so that we can go ahead and
decorate the object classes and then move the registry underneath them.

Related to blueprint use-oslo-objects

Change-Id: Iddc68a2d8a9b103621bc60a7426fe495edf80aad

The InstanceInfoCache save method calls db.instance_info_cache_update
to update the database and receives an updated sqlalchemy model as a
return value. However, the result isn't saved to the self.fields of
the InstanceInfoCache object, though it is sent to update cells,
which is inconsistent. It doesn't seem critical as we expect to
receive mostly the same data back from the database as we already
have, except for the "created_at" and "updated_at" fields.

Change-Id: I64be855a194990f898ce4e572f42975a07bf1d3c

This is the final step in removing the context parameter from the
signature of a remotable method.

This includes a change of most of the object hashes, without version
bumps. That's because the hashing algorithm is just looking for changes
in things like a call signature, in order to signal that a version bump is
required. Since context is in the signature, removing it triggers the
alert. However, context is not _actually_ part of the on-the-wire API,
as it is stripped out on the caller side, and re-added on the callee side
(hence why we're making this change in the first place). If the test had
been uuber-pedantic to exclude context from consideration, then the hashes
would not be changing here, but alas.

In short, the hash changes are false alarms and do not mean we need
version bumps for all the things.

Related to blueprint kilo-objects

Change-Id: I89464c0ab7e6e0d84e677b9a69a86468727b6438

This removes the use of the context parameter in remotable methods
in these objects. This is a precursor to actually removing the
context from the call, but we need to remove dependence on the
argument first. Remotable methods should be using the bundled object
context.

Related to blueprint kilo-objects

Change-Id: If89e6e03d1e15f8ce688166ff2faa4794280c112