<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/openstack/nova.git/nova/objects/console_auth_token.py, branch 23.2.2</title>
<subtitle>opendev.org: openstack/nova.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/'/>
<entry>
<title>Remove six.moves</title>
<updated>2020-11-07T03:25:02+00:00</updated>
<author>
<name>Takashi Natsume</name>
<email>takanattie@gmail.com</email>
</author>
<published>2020-05-12T14:52:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=1d0a0e8c2068c01366575bb989f15c2fd8962154'/>
<id>1d0a0e8c2068c01366575bb989f15c2fd8962154</id>
<content type='text'>
Replace the following items with Python 3 style code.

- six.moves.configparser
- six.moves.StringIO
- six.moves.cStringIO
- six.moves.urllib
- six.moves.builtins
- six.moves.range
- six.moves.xmlrpc_client
- six.moves.http_client
- six.moves.http_cookies
- six.moves.queue
- six.moves.zip
- six.moves.reload_module
- six.StringIO
- six.BytesIO

Subsequent patches will replace other six usages.

Change-Id: Ib2c406327fef2fb4868d8050fc476a7d17706e23
Implements: blueprint six-removal
Signed-off-by: Takashi Natsume &lt;takanattie@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace the following items with Python 3 style code.

- six.moves.configparser
- six.moves.StringIO
- six.moves.cStringIO
- six.moves.urllib
- six.moves.builtins
- six.moves.range
- six.moves.xmlrpc_client
- six.moves.http_client
- six.moves.http_cookies
- six.moves.queue
- six.moves.zip
- six.moves.reload_module
- six.StringIO
- six.BytesIO

Subsequent patches will replace other six usages.

Change-Id: Ib2c406327fef2fb4868d8050fc476a7d17706e23
Implements: blueprint six-removal
Signed-off-by: Takashi Natsume &lt;takanattie@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Reduce scope of 'path' query parameter to noVNC consoles</title>
<updated>2019-09-27T13:50:52+00:00</updated>
<author>
<name>melanie witt</name>
<email>melwittt@gmail.com</email>
</author>
<published>2019-09-27T02:10:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=54125a75fb056dbea115408610f90e7d6eee5139'/>
<id>54125a75fb056dbea115408610f90e7d6eee5139</id>
<content type='text'>
This is a partial revert of commit
9606c80402f6db20d62b689c58aa8f024183628a which added the 'path' query
parameter to work with noVNC v1.1.0. This broke all other console types
using websockify server (serial, spice) because the websockify server
itself doesn't know how to handle the 'path' query parameter. It is the
noVNC vnc_lite.html file which parses the 'path' variable and uses it
as the url to the websockify server. So, all other console types should
*not* be generating a console access url with a 'path' query parameter,
only noVNC.

Closes-Bug: #1845243

TODO(melwitt): Figure out how to test serial and/or spice console in
the gate

Change-Id: I9521f21a685edc44121d75bdf534c201fa87c2d7
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is a partial revert of commit
9606c80402f6db20d62b689c58aa8f024183628a which added the 'path' query
parameter to work with noVNC v1.1.0. This broke all other console types
using websockify server (serial, spice) because the websockify server
itself doesn't know how to handle the 'path' query parameter. It is the
noVNC vnc_lite.html file which parses the 'path' variable and uses it
as the url to the websockify server. So, all other console types should
*not* be generating a console access url with a 'path' query parameter,
only noVNC.

Closes-Bug: #1845243

TODO(melwitt): Figure out how to test serial and/or spice console in
the gate

Change-Id: I9521f21a685edc44121d75bdf534c201fa87c2d7
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge "objects: Remove ConsoleAuthToken.to_dict"</title>
<updated>2019-09-06T18:51:31+00:00</updated>
<author>
<name>Zuul</name>
<email>zuul@review.opendev.org</email>
</author>
<published>2019-09-06T18:51:30+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=840a556bd2ec752c1bb8d273da215897f9342982'/>
<id>840a556bd2ec752c1bb8d273da215897f9342982</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix cleaning up console tokens</title>
<updated>2019-07-19T02:36:15+00:00</updated>
<author>
<name>Takashi NATSUME</name>
<email>natsume.takashi@lab.ntt.co.jp</email>
</author>
<published>2019-05-03T13:19:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=57112a7174945cdcd9f395d20fd6a242cecf5072'/>
<id>57112a7174945cdcd9f395d20fd6a242cecf5072</id>
<content type='text'>
The periodic task to clean up expired console_auth tokens
does not work properly because there are cases that 'host'
in the 'console_auth_tokens' table is different from
hosts where nova-compute processes run.

So make the periodic task to clear all expired console tokens
regardless of hosts where nova-compute processes run.

Change-Id: I61cee4245e612b4bef1ffaacc634a8302cf836e9
Closes-Bug: #1816399
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The periodic task to clean up expired console_auth tokens
does not work properly because there are cases that 'host'
in the 'console_auth_tokens' table is different from
hosts where nova-compute processes run.

So make the periodic task to clear all expired console tokens
regardless of hosts where nova-compute processes run.

Change-Id: I61cee4245e612b4bef1ffaacc634a8302cf836e9
Closes-Bug: #1816399
</pre>
</div>
</content>
</entry>
<entry>
<title>Add 'path' query parameter to console access url</title>
<updated>2019-06-14T18:01:24+00:00</updated>
<author>
<name>Mohammed Naser</name>
<email>mnaser@vexxhost.com</email>
</author>
<published>2019-04-02T15:34:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=9606c80402f6db20d62b689c58aa8f024183628a'/>
<id>9606c80402f6db20d62b689c58aa8f024183628a</id>
<content type='text'>
Starting in noVNC v1.1.0, the token query parameter is no longer
forwarded via cookie [1]. We must instead use the 'path' query
parameter to pass the token through to the websocketproxy [2].
This means that if someone deploys noVNC v1.1.0, VNC consoles will
break in nova because the code is relying on the cookie functionality
that v1.1.0 removed.

This modifies the ConsoleAuthToken.access_url property to include the
'path' query parameter as part of the returned access_url that the
client will use to call the console proxy service.

This change is backward compatible with noVNC &lt; v1.1.0. The 'path' query
parameter is a long supported feature in noVNC.

Co-Authored-By: melanie witt &lt;melwittt@gmail.com&gt;

Closes-Bug: #1822676

[1] https://github.com/novnc/noVNC/commit/51f9f0098d306bbc67cc8e02ae547921b6f6585c
[2] https://github.com/novnc/noVNC/pull/1220

Change-Id: I2ddf0f4d768b698e980594dd67206464a9cea37b
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Starting in noVNC v1.1.0, the token query parameter is no longer
forwarded via cookie [1]. We must instead use the 'path' query
parameter to pass the token through to the websocketproxy [2].
This means that if someone deploys noVNC v1.1.0, VNC consoles will
break in nova because the code is relying on the cookie functionality
that v1.1.0 removed.

This modifies the ConsoleAuthToken.access_url property to include the
'path' query parameter as part of the returned access_url that the
client will use to call the console proxy service.

This change is backward compatible with noVNC &lt; v1.1.0. The 'path' query
parameter is a long supported feature in noVNC.

Co-Authored-By: melanie witt &lt;melwittt@gmail.com&gt;

Closes-Bug: #1822676

[1] https://github.com/novnc/noVNC/commit/51f9f0098d306bbc67cc8e02ae547921b6f6585c
[2] https://github.com/novnc/noVNC/pull/1220

Change-Id: I2ddf0f4d768b698e980594dd67206464a9cea37b
</pre>
</div>
</content>
</entry>
<entry>
<title>objects: Remove ConsoleAuthToken.to_dict</title>
<updated>2019-04-16T10:26:23+00:00</updated>
<author>
<name>Stephen Finucane</name>
<email>sfinucan@redhat.com</email>
</author>
<published>2019-04-16T10:26:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=0c7262cce408d2bc36ecd6962f3a3e6b18e8724f'/>
<id>0c7262cce408d2bc36ecd6962f3a3e6b18e8724f</id>
<content type='text'>
This is only used in three places now, each of which can be removed.

Part of blueprint remove-consoleauth

Change-Id: I89df8f8fa111b730ddd0aa73ae09a8cd5d152dad
Signed-off-by: Stephen Finucane &lt;sfinucan@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is only used in three places now, each of which can be removed.

Part of blueprint remove-consoleauth

Change-Id: I89df8f8fa111b730ddd0aa73ae09a8cd5d152dad
Signed-off-by: Stephen Finucane &lt;sfinucan@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Use nova-consoleauth only if workaround enabled</title>
<updated>2018-10-11T18:23:02+00:00</updated>
<author>
<name>melanie witt</name>
<email>melwittt@gmail.com</email>
</author>
<published>2018-10-01T23:47:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=b49209cc29f5ccd529b8074b68be074c5a2f742f'/>
<id>b49209cc29f5ccd529b8074b68be074c5a2f742f</id>
<content type='text'>
In Rocky, we deprecated the nova-consoleauth service but there were
unconditional calls to nova-consoleauth in the compute/api, which
made it impossible to avoid running the nova-consoleauth service.

This adds conditional checks to call nova-consoleauth only if the
[workarounds]enable_consoleauth configuration option is True. The
option defaults to False because the default console token auth TTL
is 10 minutes and only operators who have configured much longer TTL
or otherwise wish to avoid resetting all consoles at upgrade time
need to use the option.

This also updates the /os-console-auth-tokens/{console_token} API to
use nova-consoleauth only if the [workarounds] option is enabled. This
had to be done in the same change because the conditional checks in
the compute/api code caused the /os-console-auth-tokens API functional
tests to fail to find token authorizations in nova-consoleauth.

Closes-Bug: #1788470
Closes-Bug: #1795982

Change-Id: Iff6020f1a10afc476864f979faf251ef5a1a6184
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In Rocky, we deprecated the nova-consoleauth service but there were
unconditional calls to nova-consoleauth in the compute/api, which
made it impossible to avoid running the nova-consoleauth service.

This adds conditional checks to call nova-consoleauth only if the
[workarounds]enable_consoleauth configuration option is True. The
option defaults to False because the default console token auth TTL
is 10 minutes and only operators who have configured much longer TTL
or otherwise wish to avoid resetting all consoles at upgrade time
need to use the option.

This also updates the /os-console-auth-tokens/{console_token} API to
use nova-consoleauth only if the [workarounds] option is enabled. This
had to be done in the same change because the conditional checks in
the compute/api code caused the /os-console-auth-tokens API functional
tests to fail to find token authorizations in nova-consoleauth.

Closes-Bug: #1788470
Closes-Bug: #1795982

Change-Id: Iff6020f1a10afc476864f979faf251ef5a1a6184
</pre>
</div>
</content>
</entry>
<entry>
<title>Use nova.db.api directly</title>
<updated>2018-07-10T14:56:27+00:00</updated>
<author>
<name>Chris Dent</name>
<email>cdent@anticdent.org</email>
</author>
<published>2018-02-11T21:58:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=def4b17934a3b2cf783d0177d6a9632916dfd10f'/>
<id>def4b17934a3b2cf783d0177d6a9632916dfd10f</id>
<content type='text'>
nova/db/__init__.py was importing * from nova.db.api. This meant that
any time any code anywhere within the nova.db package was imported
then nova.db.api was too, leading to a cascade of imports that may
not have been desired. Also, in general, code in __init__.py is a pain.

Therefore, this change adjusts code that so that either:

* nova.db.api is used directly
* nova.db.api is imported as 'db'

In either case, the functionality remains the same.

The primary goal of this change was to make it possible to import the
model files without having to import the db api. Moving the model files
to a different place in the directory hierarchy was considered, but
given that "code in __init__.py is a pain" this mode was chosen.

This looks like a very large change, but it is essentially adjusting
package names, many in mocks.

Change-Id: Ic1fd7c87ceda05eeb96735da2a415ef37060bb1a
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
nova/db/__init__.py was importing * from nova.db.api. This meant that
any time any code anywhere within the nova.db package was imported
then nova.db.api was too, leading to a cascade of imports that may
not have been desired. Also, in general, code in __init__.py is a pain.

Therefore, this change adjusts code that so that either:

* nova.db.api is used directly
* nova.db.api is imported as 'db'

In either case, the functionality remains the same.

The primary goal of this change was to make it possible to import the
model files without having to import the db api. Moving the model files
to a different place in the directory hierarchy was considered, but
given that "code in __init__.py is a pain" this mode was chosen.

This looks like a very large change, but it is essentially adjusting
package names, many in mocks.

Change-Id: Ic1fd7c87ceda05eeb96735da2a415ef37060bb1a
</pre>
</div>
</content>
</entry>
<entry>
<title>remove unnecessary conf imports</title>
<updated>2018-03-09T19:30:10+00:00</updated>
<author>
<name>Matthew Edmonds</name>
<email>edmondsw@us.ibm.com</email>
</author>
<published>2018-01-22T14:46:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=dc32774ecc9335860677bc2562451093d8e952a1'/>
<id>dc32774ecc9335860677bc2562451093d8e952a1</id>
<content type='text'>
There are a bunch of files that define CONF but don't ever reference
it. This cleans that up, removing unnecessary imports.

In order to get flake8 to pass I also had to remove some (unrelated)
unused imports from touched files.

Change-Id: Ib96ebeeb5e4bfedb20afb02c56da1521df9fac4f
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are a bunch of files that define CONF but don't ever reference
it. This cleans that up, removing unnecessary imports.

In order to get flake8 to pass I also had to remove some (unrelated)
unused imports from touched files.

Change-Id: Ib96ebeeb5e4bfedb20afb02c56da1521df9fac4f
</pre>
</div>
</content>
</entry>
<entry>
<title>Add ConsoleAuthToken object</title>
<updated>2018-01-06T02:03:50+00:00</updated>
<author>
<name>Paul Murray</name>
<email>pmurray@hpe.com</email>
</author>
<published>2016-05-23T17:06:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/openstack/nova.git/commit/?id=9c458e795607c05a2f6e48b8a3b5bac334110f38'/>
<id>9c458e795607c05a2f6e48b8a3b5bac334110f38</id>
<content type='text'>
Console connection authorizations will be saved in
the database instead of in memory in a console auth
server.

The ConsoleAuthToken object has class methods
that replace the rpc methods used by the console
auth service. To use this object instead of that
service the calling code will use these methods
instead of call the service rpc API.

Co-Authored-By: Eli Qiao &lt;qiaoliyong@gmail.com&gt;
Co-Authored-By: melanie witt &lt;melwittt@gmail.com&gt;

partially-implements: blueprint convert-consoles-to-objects

Change-Id: Ia13591906ab2b3b7b7d5bc8f4b965c117f08fc9b
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Console connection authorizations will be saved in
the database instead of in memory in a console auth
server.

The ConsoleAuthToken object has class methods
that replace the rpc methods used by the console
auth service. To use this object instead of that
service the calling code will use these methods
instead of call the service rpc API.

Co-Authored-By: Eli Qiao &lt;qiaoliyong@gmail.com&gt;
Co-Authored-By: melanie witt &lt;melwittt@gmail.com&gt;

partially-implements: blueprint convert-consoles-to-objects

Change-Id: Ia13591906ab2b3b7b7d5bc8f4b965c117f08fc9b
</pre>
</div>
</content>
</entry>
</feed>
