We were registering the 'remote_debug' CLI opts as part of the
'nova.conf' init code. This meant not only every service we used (bar
'nova-console') but also every CLI tool we provided was exposing these
options, even though they made zero sense in the latter option.

Resolve this by explicitly registering the options against the services
that we want them in. Specifically, these are the API services (nova-api,
nova-api-metadata, nova-api-os-compute), the console proxy services
(nova-novncproxy, nova-serialproxy, nova-spicehtml5proxy), nova-compute,
nova-conductor and nova-scheduler.

While we're here, we also clean up the documentation for these options
since there are a few non-rST'y things in there.

Change-Id: I7b7489e8412cc93d49904d4ef08a775b07b27d26
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>

This change moves the spice configuration options previously
defined in the nova/spice and nova/cmd folders to the nova/conf
folder.

Implements: blueprint centralize-config-options-newton
Change-Id: I2a8130b51ce3975c6cfd3c6181ea7e7d53fbc49f
Co-Authored-By: Allen Gao <wanlong.gao@gmail.com>

The latest oslo.config supports a minimum and maximum value for
IntOpt options.  This patch utilizes this for a number of options
with well known ranges.

Change-Id: I897d8870fdf67a095915c8fcdf239024b092e9e3

Following patch I2d46b926f1c895aba412d84b4ee059fda3df9011, if
proxy_host/proxy_port is configured in nova.conf or passed via
command line, they are not taking effect for novncproxy, spice
htmlproxy and serial proxy. This patch fixes the issue by
parsing the arguments before calling baseproxy.

Closes-Bug: #1424647
Change-Id: I183309d7f0a3b86881f05e7fe65d1399170b5a3d

The oslo team is recommending everyone to switch to the
non-namespaced versions of libraries. Updating the hacking
rule to include a check to prevent oslo.* import from
creeping back in.

This commit includes:
- using oslo_utils instead of oslo.utils
- using oslo_serialization instead of oslo.serialization
- using oslo_db instead of oslo.db
- using oslo_i18n instead of oslo.i18n
- using oslo_middleware instead of oslo.middleware
- using oslo_config instead of oslo.config
- using oslo_messaging instead of "from oslo import messaging"
- using oslo_vmware instead of oslo.vmware

Change-Id: I3e2eb147b321ce3e928817b62abcb7d023c5f13f

Introduces a new module baseproxy that provides the base
code shared between novncproxy, serialproxy, spicehtml5proxy
Updates them to use this new module.

Change-Id: I2d46b926f1c895aba412d84b4ee059fda3df9011

Now that we are in Kilo, remove options deprecated in Juno.

Options deprecated in I36c014c8b8a0796cda494f9450a1fc30104504a1

Change-Id: I2c634197229977a1d54444e5be56ad910c664231

Websockify version 0.6 bring with it several bugfixes
and new features that affect Nova (including a fix for
novncproxy zombies hanging around and better support
for the python logging framework).  However, it also
broke backwards compatibility due to a refactor which
brought it inline with other Python socket server libraries.

This patch updates the websockify code to function with
websockify version 0.6 as well as websockify version 0.5.x.

Change-Id: I7858dbb49bee8de3fe725beb6793eac3ecba71b6

All spice configuration should be read from the spice group
in the nova config. As it's currently being done in the nova.spice
module.
Renaming spicehtml5proxy_{host, port} parameters to
html5proxy_{host, port}

DocImpact
Change-Id: I36c014c8b8a0796cda494f9450a1fc30104504a1
Closes-Bug: #1308418

This commit integrates functionality from the
`openstack.common.report` module into Nova.
This enables Nova services to receive SIGUSR1
and print a Guru Meditation Report to stderr.
The required modules were added to
'openstack-common.conf' as well.

Change-Id: I224a426dad084f0e738069207ffbffe7f7935a17
Implements: blueprint guru-meditation-report