From cea9e39dd70e6b5c5f0e5aac5e9b7fc477ab990c Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Sat, 23 Feb 2013 10:35:28 +0000 Subject: Add common test base class to hold common things. There are several common fixtures that every test case wants. Following the pattern in Nova, add a common base test case class to hold these things. Change-Id: I2d2cd91e5051d9cbf230e6f48985d6eddcb7b58a --- HACKING.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'HACKING.rst') diff --git a/HACKING.rst b/HACKING.rst index 4333d25685..84e81af97d 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -199,7 +199,10 @@ bug that had no unit test, a new passing unit test should be added. If a submitted bug fix does have a unit test, be sure to add a new one that fails without the patch and passes with the patch. -All unittest classes must ultimately inherit from testtools.TestCase. +All unittest classes must ultimately inherit from testtools.TestCase. In the +Quantum test suite, this should be done by inheriting from +quantum.tests.base.BaseTestCase. + All setUp and tearDown methods must upcall using the super() method. tearDown methods should be avoided and addCleanup calls should be preferred. Never manually create tempfiles. Always use the tempfile fixtures from -- cgit v1.2.1