summaryrefslogtreecommitdiff
path: root/ironic/tests/unit/db
diff options
context:
space:
mode:
authorKaifeng Wang <kaifeng.w@gmail.com>2020-11-28 01:07:18 +0800
committerKaifeng Wang <kaifeng.w@gmail.com>2020-11-29 13:37:55 +0800
commitb7ddeb314d98961b5d169f5356a451eec78c8cc7 (patch)
tree9c61c95a37ae1379dcf666da137a34a33075eb21 /ironic/tests/unit/db
parenta08da8551a66815bedef7c6444fde5f9082a6aea (diff)
downloadironic-b7ddeb314d98961b5d169f5356a451eec78c8cc7.tar.gz
Support port name
MAC address is not user friendly for port management, having a name field is also a feature parity with other resources. This patch implements db related change. Change-Id: Ibad9a1b6bbfddc0af1950def4e27db3757904cb1 Story: 2003091 Task: 23180
Diffstat (limited to 'ironic/tests/unit/db')
-rw-r--r--ironic/tests/unit/db/sqlalchemy/test_migrations.py5
-rw-r--r--ironic/tests/unit/db/test_ports.py7
-rw-r--r--ironic/tests/unit/db/utils.py1
3 files changed, 12 insertions, 1 deletions
diff --git a/ironic/tests/unit/db/sqlalchemy/test_migrations.py b/ironic/tests/unit/db/sqlalchemy/test_migrations.py
index 39293c6ac..7a2641323 100644
--- a/ironic/tests/unit/db/sqlalchemy/test_migrations.py
+++ b/ironic/tests/unit/db/sqlalchemy/test_migrations.py
@@ -1002,6 +1002,11 @@ class MigrationCheckersMixin(object):
col_names = [column.name for column in nodes.c]
self.assertIn('lessee', col_names)
+ def _check_c0455649680c(self, engine, data):
+ ports = db_utils.get_table(engine, 'ports')
+ col_names = [column.name for column in ports.c]
+ self.assertIn('name', col_names)
+
def test_upgrade_and_version(self):
with patch_with_engine(self.engine):
self.migration_api.upgrade('head')
diff --git a/ironic/tests/unit/db/test_ports.py b/ironic/tests/unit/db/test_ports.py
index d2434d603..18b8a9032 100644
--- a/ironic/tests/unit/db/test_ports.py
+++ b/ironic/tests/unit/db/test_ports.py
@@ -32,7 +32,8 @@ class DbPortTestCase(base.DbTestCase):
lessee='54321')
self.portgroup = db_utils.create_test_portgroup(node_id=self.node.id)
self.port = db_utils.create_test_port(node_id=self.node.id,
- portgroup_id=self.portgroup.id)
+ portgroup_id=self.portgroup.id,
+ name='port-name')
def test_get_port_by_id(self):
res = self.dbapi.get_port_by_id(self.port.id)
@@ -68,6 +69,10 @@ class DbPortTestCase(base.DbTestCase):
self.port.address,
project='55555')
+ def test_get_port_by_name(self):
+ res = self.dbapi.get_port_by_name(self.port.name)
+ self.assertEqual(self.port.id, res.id)
+
def test_get_port_list(self):
uuids = []
for i in range(1, 6):
diff --git a/ironic/tests/unit/db/utils.py b/ironic/tests/unit/db/utils.py
index 96254889d..436849054 100644
--- a/ironic/tests/unit/db/utils.py
+++ b/ironic/tests/unit/db/utils.py
@@ -277,6 +277,7 @@ def get_test_port(**kw):
'internal_info': kw.get('internal_info', {"bar": "buzz"}),
'physical_network': kw.get('physical_network'),
'is_smartnic': kw.get('is_smartnic', False),
+ 'name': kw.get('name'),
}